scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-06 13:18:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #127303 from omerap12/issue_127287

Browse Source 
Improve message prefer a domain-qualified finalizer
This commit is contained in:
Kubernetes Prow Robot
2024-09-13 03:51:12 +01:00
committed by GitHub
parent 359b9ba9bf 6aa674dc5a
commit 8d402c9941
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/integration/apiserver/field_validation_test.go
View File

@@ -2937,6 +2937,13 @@ func testFinalizerValidationApplyCreateAndUpdateCRD(t *testing.T, rest rest.Inte
name: "create-crd-with-valid-finalizer",
finalizer: []string{"kubernetes.io/valid-finalizer"},
},
{
name: "create-crd-with-fqdn-like-finalizer-without-path",
finalizer: []string{"finalizer.without.valid-path.io"},
expectCreateWarnings: []string{
`metadata.finalizers: "finalizer.without.valid-path.io": prefer a domain-qualified finalizer name including a path (/) to avoid accidental conflicts with other finalizer writers`,
},
},
{
name: "update-crd-with-invalid-finalizer",
finalizer: []string{"invalid-finalizer"},