mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-03 19:58:17 +00:00 
			
		
		
		
	Move from glog to klog
- Move from the old github.com/golang/glog to k8s.io/klog - klog as explicit InitFlags() so we add them as necessary - we update the other repositories that we vendor that made a similar change from glog to klog * github.com/kubernetes/repo-infra * k8s.io/gengo/ * k8s.io/kube-openapi/ * github.com/google/cadvisor - Entirely remove all references to glog - Fix some tests by explicit InitFlags in their init() methods Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
This commit is contained in:
		@@ -38,7 +38,7 @@ import (
 | 
			
		||||
	api "k8s.io/kubernetes/pkg/apis/core"
 | 
			
		||||
	"k8s.io/kubernetes/pkg/serviceaccount"
 | 
			
		||||
 | 
			
		||||
	"github.com/golang/glog"
 | 
			
		||||
	"k8s.io/klog"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
// ControllerClientBuilder allows you to get clients and configs for controllers
 | 
			
		||||
@@ -65,7 +65,7 @@ func (b SimpleControllerClientBuilder) Config(name string) (*restclient.Config,
 | 
			
		||||
func (b SimpleControllerClientBuilder) ConfigOrDie(name string) *restclient.Config {
 | 
			
		||||
	clientConfig, err := b.Config(name)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		glog.Fatal(err)
 | 
			
		||||
		klog.Fatal(err)
 | 
			
		||||
	}
 | 
			
		||||
	return clientConfig
 | 
			
		||||
}
 | 
			
		||||
@@ -81,7 +81,7 @@ func (b SimpleControllerClientBuilder) Client(name string) (clientset.Interface,
 | 
			
		||||
func (b SimpleControllerClientBuilder) ClientOrDie(name string) clientset.Interface {
 | 
			
		||||
	client, err := b.Client(name)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		glog.Fatal(err)
 | 
			
		||||
		klog.Fatal(err)
 | 
			
		||||
	}
 | 
			
		||||
	return client
 | 
			
		||||
}
 | 
			
		||||
@@ -146,15 +146,15 @@ func (b SAControllerClientBuilder) Config(name string) (*restclient.Config, erro
 | 
			
		||||
				}
 | 
			
		||||
				validConfig, valid, err := b.getAuthenticatedConfig(sa, string(secret.Data[v1.ServiceAccountTokenKey]))
 | 
			
		||||
				if err != nil {
 | 
			
		||||
					glog.Warningf("error validating API token for %s/%s in secret %s: %v", sa.Name, sa.Namespace, secret.Name, err)
 | 
			
		||||
					klog.Warningf("error validating API token for %s/%s in secret %s: %v", sa.Name, sa.Namespace, secret.Name, err)
 | 
			
		||||
					// continue watching for good tokens
 | 
			
		||||
					return false, nil
 | 
			
		||||
				}
 | 
			
		||||
				if !valid {
 | 
			
		||||
					glog.Warningf("secret %s contained an invalid API token for %s/%s", secret.Name, sa.Name, sa.Namespace)
 | 
			
		||||
					klog.Warningf("secret %s contained an invalid API token for %s/%s", secret.Name, sa.Name, sa.Namespace)
 | 
			
		||||
					// try to delete the secret containing the invalid token
 | 
			
		||||
					if err := b.CoreClient.Secrets(secret.Namespace).Delete(secret.Name, &metav1.DeleteOptions{}); err != nil && !apierrors.IsNotFound(err) {
 | 
			
		||||
						glog.Warningf("error deleting secret %s containing invalid API token for %s/%s: %v", secret.Name, sa.Name, sa.Namespace, err)
 | 
			
		||||
						klog.Warningf("error deleting secret %s containing invalid API token for %s/%s: %v", secret.Name, sa.Name, sa.Namespace, err)
 | 
			
		||||
					}
 | 
			
		||||
					// continue watching for good tokens
 | 
			
		||||
					return false, nil
 | 
			
		||||
@@ -208,14 +208,14 @@ func (b SAControllerClientBuilder) getAuthenticatedConfig(sa *v1.ServiceAccount,
 | 
			
		||||
	tokenReview := &v1authenticationapi.TokenReview{Spec: v1authenticationapi.TokenReviewSpec{Token: token}}
 | 
			
		||||
	if tokenResult, err := b.AuthenticationClient.TokenReviews().Create(tokenReview); err == nil {
 | 
			
		||||
		if !tokenResult.Status.Authenticated {
 | 
			
		||||
			glog.Warningf("Token for %s/%s did not authenticate correctly", sa.Name, sa.Namespace)
 | 
			
		||||
			klog.Warningf("Token for %s/%s did not authenticate correctly", sa.Name, sa.Namespace)
 | 
			
		||||
			return nil, false, nil
 | 
			
		||||
		}
 | 
			
		||||
		if tokenResult.Status.User.Username != username {
 | 
			
		||||
			glog.Warningf("Token for %s/%s authenticated as unexpected username: %s", sa.Name, sa.Namespace, tokenResult.Status.User.Username)
 | 
			
		||||
			klog.Warningf("Token for %s/%s authenticated as unexpected username: %s", sa.Name, sa.Namespace, tokenResult.Status.User.Username)
 | 
			
		||||
			return nil, false, nil
 | 
			
		||||
		}
 | 
			
		||||
		glog.V(4).Infof("Verified credential for %s/%s", sa.Name, sa.Namespace)
 | 
			
		||||
		klog.V(4).Infof("Verified credential for %s/%s", sa.Name, sa.Namespace)
 | 
			
		||||
		return clientConfig, true, nil
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
@@ -229,7 +229,7 @@ func (b SAControllerClientBuilder) getAuthenticatedConfig(sa *v1.ServiceAccount,
 | 
			
		||||
	}
 | 
			
		||||
	err = client.Get().AbsPath("/apis").Do().Error()
 | 
			
		||||
	if apierrors.IsUnauthorized(err) {
 | 
			
		||||
		glog.Warningf("Token for %s/%s did not authenticate correctly: %v", sa.Name, sa.Namespace, err)
 | 
			
		||||
		klog.Warningf("Token for %s/%s did not authenticate correctly: %v", sa.Name, sa.Namespace, err)
 | 
			
		||||
		return nil, false, nil
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
@@ -239,7 +239,7 @@ func (b SAControllerClientBuilder) getAuthenticatedConfig(sa *v1.ServiceAccount,
 | 
			
		||||
func (b SAControllerClientBuilder) ConfigOrDie(name string) *restclient.Config {
 | 
			
		||||
	clientConfig, err := b.Config(name)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		glog.Fatal(err)
 | 
			
		||||
		klog.Fatal(err)
 | 
			
		||||
	}
 | 
			
		||||
	return clientConfig
 | 
			
		||||
}
 | 
			
		||||
@@ -255,7 +255,7 @@ func (b SAControllerClientBuilder) Client(name string) (clientset.Interface, err
 | 
			
		||||
func (b SAControllerClientBuilder) ClientOrDie(name string) clientset.Interface {
 | 
			
		||||
	client, err := b.Client(name)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		glog.Fatal(err)
 | 
			
		||||
		klog.Fatal(err)
 | 
			
		||||
	}
 | 
			
		||||
	return client
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user