scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #25755 from pmorie/flakes-be-gone

Browse Source 
Automatic merge from submit-queue

Add notes about endgame for test flakes

@lavalamp as we discussed last week, sorry for the latency.
This commit is contained in:
k8s-merge-robot
2016-05-18 00:13:45 -07:00
parent 6e5db87304 e157febfe2
commit a10a62f5e7
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
docs/devel/flaky-tests.md
View File

@@ -88,11 +88,20 @@ we have the following guidelines:
3. If you can reproduce it (or it's obvious from the logs what happened), you 3. If you can reproduce it (or it's obvious from the logs what happened), you
should then be able to fix it, or in the case where someone is clearly more should then be able to fix it, or in the case where someone is clearly more
qualified to fix it, reassign it with very clear instructions. qualified to fix it, reassign it with very clear instructions.
4. If you can't reproduce it: __don't just close it!__ Every time a flake comes 4. PRs that fix or help debug flakes may have the P0 priority set to get them
through the merge queue as fast as possible.
5. Once you have made a change that you believe fixes a flake, it is conservative
to keep the issue for the flake open and see if it manifests again after the
change is merged.
6. If you can't reproduce a flake: __don't just close it!__ Every time a flake comes
back, at least 2 hours of merge time is wasted. So we need to make monotonic back, at least 2 hours of merge time is wasted. So we need to make monotonic
progress towards narrowing it down every time a flake occurs. If you can't progress towards narrowing it down every time a flake occurs. If you can't
figure it out from the logs, add log messages that would have help you figure figure it out from the logs, add log messages that would have help you figure
it out. it out. If you make changes to make a flake more reproducible, please link
your pull request to the flake you're working on.
7. If a flake has been open, could not be reproduced, and has not manifested in
3 months, it is reasonable to close the flake issue with a note saying
why.
# Reproducing unit test flakes # Reproducing unit test flakes