mirror of
https://github.com/optim-enterprises-bv/kubernetes.git
synced 2025-11-27 03:44:04 +00:00
Merge pull request #54820 from sjevs/test/issue-54645-kubectl-apply-view-last-applied
Automatic merge from submit-queue (batch tested with PRs 54774, 54820, 52192, 54827). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Added a test for proper `%s` handling when display last applied confi… **What this PR does / why we need it**: Added missing tests which checks proper handling of `%s` in arguments for command `kubectl apply view-last-applied` **Which issue this PR fixes** #54645 **Special notes for your reviewer**: Added a test case to cover specific issue described. It fails on version `v1.7.3`..`v1.7.9` and passes since `v1.8.0`. P.S. Not sure if there is already a lower level test which covers this case in the k8s test suite. I would recommend to add this test, so the issue would not reoccur. **Release note**: ```release-note NONE ```
This commit is contained in:
20
test/fixtures/pkg/kubectl/cmd/apply/rc-args.yaml
vendored
Normal file
20
test/fixtures/pkg/kubectl/cmd/apply/rc-args.yaml
vendored
Normal file
@@ -0,0 +1,20 @@
|
||||
apiVersion: v1
|
||||
kind: ReplicationController
|
||||
metadata:
|
||||
name: test-rc
|
||||
labels:
|
||||
name: test-rc
|
||||
spec:
|
||||
replicas: 1
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
name: test-rc
|
||||
spec:
|
||||
containers:
|
||||
- name: test-rc
|
||||
image: nginx
|
||||
args:
|
||||
- -random_flag=%s@domain.com
|
||||
ports:
|
||||
- containerPort: 80
|
||||
23
test/fixtures/pkg/kubectl/cmd/apply/rc-lastapplied-args.yaml
vendored
Normal file
23
test/fixtures/pkg/kubectl/cmd/apply/rc-lastapplied-args.yaml
vendored
Normal file
@@ -0,0 +1,23 @@
|
||||
apiVersion: v1
|
||||
kind: ReplicationController
|
||||
metadata:
|
||||
annotations:
|
||||
kubectl.kubernetes.io/last-applied-configuration: |
|
||||
{"args":"-random_flag=%s@domain.com"}
|
||||
name: test-rc
|
||||
labels:
|
||||
name: test-rc
|
||||
spec:
|
||||
replicas: 1
|
||||
template:
|
||||
metadata:
|
||||
labels:
|
||||
name: test-rc
|
||||
spec:
|
||||
containers:
|
||||
- name: test-rc
|
||||
image: nginx
|
||||
args:
|
||||
- -random_flag=%s@domain.com
|
||||
ports:
|
||||
- containerPort: 80
|
||||
Reference in New Issue
Block a user