scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

kubectl/deployment: add BaseDeploymentGenerator to reduce duplication

Browse Source 
BaseDeploymentGenerator performs the functionality that was common to
both of the "create deployment" generators.
This commit is contained in:
Alexander Campbell
2017-07-14 09:42:41 -07:00
parent ebf24c14a9
commit a7c79711d5
3 changed files with 115 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
pkg/kubectl/cmd/create_deployment_test.go
View File

@@ -47,17 +47,29 @@ func Test_generatorFromName(t *testing.T) {
generator, ok = generatorFromName(basicName, imageNames, deploymentName)
assert.True(t, ok)
assert.Equal(t, &kubectl.DeploymentBasicGeneratorV1{
Name: deploymentName,
Images: imageNames,
}, generator)
{
expectedGenerator := &kubectl.DeploymentBasicGeneratorV1{
BaseDeploymentGenerator: kubectl.BaseDeploymentGenerator{
Name: deploymentName,
Images: imageNames,
},
}
assert.Equal(t, expectedGenerator, generator)
}
generator, ok = generatorFromName(basicAppsName, imageNames, deploymentName)
assert.True(t, ok)
assert.Equal(t, &kubectl.DeploymentBasicAppsGeneratorV1{
Name: deploymentName,
Images: imageNames,
}, generator)
{
expectedGenerator := &kubectl.DeploymentBasicAppsGeneratorV1{
BaseDeploymentGenerator: kubectl.BaseDeploymentGenerator{
Name: deploymentName,
Images: imageNames,
},
}
assert.Equal(t, expectedGenerator, generator)
}
}
func TestCreateDeployment(t *testing.T) {