scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-10-31 10:18:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #43682 from jeffvance/e2e-featureVolumes

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 42662, 43035, 42578, 43682)

Apply [Feature:Volumes] to subset of tests in volumes.go

**What this PR does / why we need it**:
According to [this test doc](https://github.com/kubernetes/community/blob/master/contributors/devel/e2e-tests.md#kinds-of-tests), the `[Feature:xyz]` tag indicates that the tests have a non-default requirements and should not be run in the core suite. Previously all test in _e2e/volumes.go_ were tagged `[Feature:Volumes]` but I believe only six of the tests warrant this tag: iSCSI, GlusterFS, Ceph-RBD, Ceph-FS, vSPhere, and Cinder. The remaining tests (NFS, PD, ConfigMap) do not need the `Feature:` tag.

**Special notes for your reviewer**:
I moved the `[Volume]` tags from the `It`'s to the outer `KubeDescribe` to simplify the `It` text and remove redundancy.

**Release note**:
```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue
2017-03-30 11:00:36 -07:00
committed by GitHub
parent 7331d9ed83 6a17c4c7f8
commit b4235038b3
1 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/e2e/volumes.go
View File

@@ -381,9 +381,8 @@ func deleteCinderVolume(name string) error {
return err return err
} }
// These tests need privileged containers, which are disabled by default. Run // These tests need privileged containers, which are disabled by default.
// the test with "go run hack/e2e.go ... --ginkgo.focus=[Feature:Volumes]" var _ = framework.KubeDescribe("Volumes [Volume]", func() {
var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
f := framework.NewDefaultFramework("volume") f := framework.NewDefaultFramework("volume")
// If 'false', the test won't clear its volumes upon completion. Useful for debugging, // If 'false', the test won't clear its volumes upon completion. Useful for debugging,
@@ -403,7 +402,7 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("NFS", func() { framework.KubeDescribe("NFS", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
prefix: "nfs", prefix: "nfs",
@@ -442,8 +441,8 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
// Gluster // Gluster
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("GlusterFS", func() { framework.KubeDescribe("GlusterFS [Feature:Volumes]", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
prefix: "gluster", prefix: "gluster",
@@ -527,8 +526,8 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
// are installed on all nodes! // are installed on all nodes!
// Run the test with "go run hack/e2e.go ... --ginkgo.focus=iSCSI" // Run the test with "go run hack/e2e.go ... --ginkgo.focus=iSCSI"
framework.KubeDescribe("iSCSI", func() { framework.KubeDescribe("iSCSI [Feature:Volumes]", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
prefix: "iscsi", prefix: "iscsi",
@@ -574,8 +573,8 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
// Ceph RBD // Ceph RBD
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("Ceph RBD", func() { framework.KubeDescribe("Ceph RBD [Feature:Volumes]", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
prefix: "rbd", prefix: "rbd",
@@ -652,8 +651,8 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
// Ceph // Ceph
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("CephFS", func() { framework.KubeDescribe("CephFS [Feature:Volumes]", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
prefix: "cephfs", prefix: "cephfs",
@@ -730,8 +729,8 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
// and that the usual OpenStack authentication env. variables are set // and that the usual OpenStack authentication env. variables are set
// (OS_USERNAME, OS_PASSWORD, OS_TENANT_NAME at least). // (OS_USERNAME, OS_PASSWORD, OS_TENANT_NAME at least).
framework.KubeDescribe("Cinder", func() { framework.KubeDescribe("Cinder [Feature:Volumes]", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
framework.SkipUnlessProviderIs("openstack") framework.SkipUnlessProviderIs("openstack")
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
@@ -807,7 +806,7 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("PD", func() { framework.KubeDescribe("PD", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
framework.SkipUnlessProviderIs("gce", "gke") framework.SkipUnlessProviderIs("gce", "gke")
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
@@ -857,7 +856,7 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("ConfigMap", func() { framework.KubeDescribe("ConfigMap", func() {
It("should be mountable [Volume]", func() { It("should be mountable", func() {
config := VolumeTestConfig{ config := VolumeTestConfig{
namespace: namespace.Name, namespace: namespace.Name,
prefix: "configmap", prefix: "configmap",
@@ -934,7 +933,7 @@ var _ = framework.KubeDescribe("Volumes [Feature:Volumes]", func() {
// vSphere // vSphere
//////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////
framework.KubeDescribe("vsphere", func() { framework.KubeDescribe("vsphere [Feature:Volumes]", func() {
It("should be mountable", func() { It("should be mountable", func() {
framework.SkipUnlessProviderIs("vsphere") framework.SkipUnlessProviderIs("vsphere")
var ( var (