scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-07 22:03:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

e2e: fix return value of WaitForPodsWithLabelRunningReady

Browse Source 
Because of a := assignment, the anonymous function assigned the pod
list to a local variable instead of the
WaitForPodsWithLabelRunningReady return value which therefore always
was nil.

The correct code is an assignment with = as in WaitForPodsWithLabelScheduled.
This commit is contained in:
Patrick Ohly
2019-06-04 13:35:32 +02:00
parent eaf89cfbb4
commit baef3e44cd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/e2e/framework/pod/wait.go
View File

@@ -534,7 +534,7 @@ func WaitForPodsWithLabelRunningReady(c clientset.Interface, ns string, label la
var current int var current int
err = wait.Poll(poll, timeout, err = wait.Poll(poll, timeout,
func() (bool, error) { func() (bool, error) {
pods, err := WaitForPodsWithLabel(c, ns, label) pods, err = WaitForPodsWithLabel(c, ns, label)
if err != nil { if err != nil {
e2elog.Logf("Failed to list pods: %v", err) e2elog.Logf("Failed to list pods: %v", err)
if testutils.IsRetryableAPIError(err) { if testutils.IsRetryableAPIError(err) {