scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-04 04:08:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #124516 from danwinship/cloud-hostname-override

Browse Source 
Fix behavior with external cloud provider and --hostname-override
This commit is contained in:
Kubernetes Prow Robot
2024-04-25 14:47:24 -07:00
committed by GitHub
parent 4bb8debb1f 30972710bd
commit bf454d7c59
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/kubelet/nodestatus/setters.go
View File

@@ -135,6 +135,9 @@ func NodeAddress(nodeIPs []net.IP, // typically Kubelet.nodeIPs
// in https://github.com/kubernetes/kubernetes/issues/120720. // in https://github.com/kubernetes/kubernetes/issues/120720.
// We are already hinting the external cloud provider via the annotation AnnotationAlphaProvidedIPAddr. // We are already hinting the external cloud provider via the annotation AnnotationAlphaProvidedIPAddr.
if !nodeIPSpecified { if !nodeIPSpecified {
node.Status.Addresses = []v1.NodeAddress{
{Type: v1.NodeHostName, Address: hostname},
}
return nil return nil
} }
} }

8
pkg/kubelet/nodestatus/setters_test.go
View File

@@ -238,14 +238,18 @@ func TestNodeAddress(t *testing.T) {
nodeIP: netutils.ParseIPSloppy("::"), nodeIP: netutils.ParseIPSloppy("::"),
nodeAddresses: []v1.NodeAddress{}, nodeAddresses: []v1.NodeAddress{},
cloudProviderType: cloudProviderExternal, cloudProviderType: cloudProviderExternal,
expectedAddresses: []v1.NodeAddress{}, expectedAddresses: []v1.NodeAddress{
{Type: v1.NodeHostName, Address: testKubeletHostname},
},
shouldError: false, shouldError: false,
}, },
{ {
name: "cloud provider is external and no nodeIP", name: "cloud provider is external and no nodeIP",
nodeAddresses: []v1.NodeAddress{}, nodeAddresses: []v1.NodeAddress{},
cloudProviderType: cloudProviderExternal, cloudProviderType: cloudProviderExternal,
expectedAddresses: []v1.NodeAddress{}, expectedAddresses: []v1.NodeAddress{
{Type: v1.NodeHostName, Address: testKubeletHostname},
},
shouldError: false, shouldError: false,
}, },
{ {