scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-10-31 18:28:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix ginkgo deprecation warning

Browse Source 
Fixed ginkgo warning
   You're using deprecated Ginkgo functionality:
   =============================================
   --untilItFails is deprecated, use --until-it-fails instead

Used consistent approach with this flag in e2e_node and e2e scripts.
This commit is contained in:
Ed Bartosh
2023-05-31 12:53:11 +03:00
parent 7935006af2
commit c48c4c679a
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/root/Makefile
View File

@@ -213,7 +213,7 @@ define TEST_E2E_NODE_HELP_INFO
# Defaults to "\[Flaky\]|\[Slow\]|\[Serial\]". # Defaults to "\[Flaky\]|\[Slow\]|\[Serial\]".
# TEST_ARGS: A space-separated list of arguments to pass to node e2e test. # TEST_ARGS: A space-separated list of arguments to pass to node e2e test.
# Defaults to "". # Defaults to "".
# RUN_UNTIL_FAILURE: If true, pass --untilItFails to ginkgo so tests are run # RUN_UNTIL_FAILURE: If true, pass --until-it-fails=true to ginkgo so tests are run
# repeatedly until they fail. Defaults to false. # repeatedly until they fail. Defaults to false.
# REMOTE: If true, run the tests on a remote host. Defaults to false. # REMOTE: If true, run the tests on a remote host. Defaults to false.
# REMOTE_MODE: For REMOTE=true only. Mode for remote execution (eg. gce, ssh). # REMOTE_MODE: For REMOTE=true only. Mode for remote execution (eg. gce, ssh).

2
hack/ginkgo-e2e.sh
View File

@@ -149,7 +149,7 @@ if [[ -n "${CONFORMANCE_TEST_SKIP_REGEX:-}" ]]; then
fi fi
if [[ "${GINKGO_UNTIL_IT_FAILS:-}" == true ]]; then if [[ "${GINKGO_UNTIL_IT_FAILS:-}" == true ]]; then
ginkgo_args+=("--untilItFails=true") ginkgo_args+=("--until-it-fails=true")
fi fi
FLAKE_ATTEMPTS=1 FLAKE_ATTEMPTS=1

4
hack/make-rules/test-e2e-node.sh
View File

@@ -66,8 +66,8 @@ if [[ ${skip} != "" ]]; then
ginkgoflags="${ginkgoflags} -skip=\"${skip}\" " ginkgoflags="${ginkgoflags} -skip=\"${skip}\" "
fi fi
if [[ ${run_until_failure} != "" ]]; then if [[ ${run_until_failure} == "true" ]]; then
ginkgoflags="${ginkgoflags} -untilItFails=${run_until_failure} " ginkgoflags="${ginkgoflags} --until-it-fails=true "
fi fi
# Setup the directory to copy test artifacts (logs, junit.xml, etc) from remote host to local host # Setup the directory to copy test artifacts (logs, junit.xml, etc) from remote host to local host