scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-05 04:38:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix submit queue when there are multiple LGTMs

Browse Source
This commit is contained in:
Brendan Burns
2015-08-04 21:51:54 -07:00
parent 714b39f025
commit c5643c3c03
2 changed files with 57 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
contrib/submit-queue/github/github_test.go
View File

@@ -424,6 +424,60 @@ func TestValidateLGTMAfterPush(t *testing.T) {
lastModified: time.Unix(11, 0),
shouldPass: false,
},
{
issueEvents: []github.IssueEvent{
{
Event: stringPtr("labeled"),
Label: &github.Label{
Name: stringPtr("lgtm"),
},
CreatedAt: timePtr(time.Unix(12, 0)),
},
{
Event: stringPtr("labeled"),
Label: &github.Label{
Name: stringPtr("lgtm"),
},
CreatedAt: timePtr(time.Unix(11, 0)),
},
{
Event: stringPtr("labeled"),
Label: &github.Label{
Name: stringPtr("lgtm"),
},
CreatedAt: timePtr(time.Unix(10, 0)),
},
},
lastModified: time.Unix(11, 0),
shouldPass: true,
},
{
issueEvents: []github.IssueEvent{
{
Event: stringPtr("labeled"),
Label: &github.Label{
Name: stringPtr("lgtm"),
},
CreatedAt: timePtr(time.Unix(10, 0)),
},
{
Event: stringPtr("labeled"),
Label: &github.Label{
Name: stringPtr("lgtm"),
},
CreatedAt: timePtr(time.Unix(11, 0)),
},
{
Event: stringPtr("labeled"),
Label: &github.Label{
Name: stringPtr("lgtm"),
},
CreatedAt: timePtr(time.Unix(12, 0)),
},
},
lastModified: time.Unix(11, 0),
shouldPass: true,
},
}
for _, test := range tests {
client, server, mux := initTest()