mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-03 19:58:17 +00:00 
			
		
		
		
	Merge pull request #63914 from superbrothers/completion-init-containers
Automatic merge from submit-queue (batch tested with PRs 63914, 63887, 64116, 64026, 62933). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add initContainers into completion suggestions for kubectl logs/attach **What this PR does / why we need it**: This PR improves autocomplete of kubectl logs/attach to add initContainers into completion suggestions in addition to containers. ``` $ cat <<EOL | kubectl apply -f - apiVersion: v1 kind: Pod metadata: name: myapp-pod spec: initContainers: - name: init-myservice image: busybox command: ['sh', '-c', 'until nslookup myservice; do echo waiting for myservice; sleep 2; done;'] - name: init-mydb image: busybox command: ['sh', '-c', 'until nslookup mydb; do echo waiting for mydb; sleep 2; done;'] containers: - name: myapp-container image: busybox command: ['sh', '-c', 'echo The app is running! && sleep 3600'] EOL $ kubectl logs myapp-pod <tab><tab> init-mydb init-myservice myapp-container ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
This commit is contained in:
		@@ -148,7 +148,7 @@ __kubectl_get_resource_clusterrole()
 | 
				
			|||||||
__kubectl_get_containers()
 | 
					__kubectl_get_containers()
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
    local template
 | 
					    local template
 | 
				
			||||||
    template="{{ range .spec.containers  }}{{ .name }} {{ end }}"
 | 
					    template="{{ range .spec.initContainers }}{{ .name }} {{end}}{{ range .spec.containers  }}{{ .name }} {{ end }}"
 | 
				
			||||||
    __kubectl_debug "${FUNCNAME} nouns are ${nouns[*]}"
 | 
					    __kubectl_debug "${FUNCNAME} nouns are ${nouns[*]}"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    local len="${#nouns[@]}"
 | 
					    local len="${#nouns[@]}"
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user