scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-04 04:08:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow disruptive conformance tests and marks 2

Browse Source 
- Adjusts tooling to allow disrutpive tests to be marked conformance
 - Updates the corresponding tests
 - Marks 2 tests as disruptive
This commit is contained in:
John Schnake
2019-09-12 14:31:37 -05:00
parent 06fc5b7f17
commit d0ab1f06fb
3 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/conformance/walk.go
View File

@@ -44,7 +44,7 @@ var (
totalConfTests, totalLegacyTests, missingComments int totalConfTests, totalLegacyTests, missingComments int
// If a test name contains any of these tags, it is ineligble for promotion to conformance // If a test name contains any of these tags, it is ineligble for promotion to conformance
regexIneligibleTags = regexp.MustCompile(`\[(Alpha|Disruptive|Feature:[^\]]+|Flaky)\]`) regexIneligibleTags = regexp.MustCompile(`\[(Alpha|Feature:[^\]]+|Flaky)\]`)
) )
const regexDescribe = "Describe|KubeDescribe|SIGDescribe" const regexDescribe = "Describe|KubeDescribe|SIGDescribe"

14
test/conformance/walk_test.go
View File

@@ -156,17 +156,13 @@ func TestValidateTestName(t *testing.T) {
"", "",
}, },
{ {
"a test case with valid tags [LinuxOnly] [NodeConformance] [Serial]", "a test case with valid tags [LinuxOnly] [NodeConformance] [Serial] [Disruptive]",
"", "",
}, },
{ {
"a flaky test case that is invalid [Flaky]", "a flaky test case that is invalid [Flaky]",
"[Flaky]", "[Flaky]",
}, },
{
"a disruptive test case that is invalid [Disruptive]",
"[Disruptive]",
},
{ {
"a feature test case that is invalid [Feature:Awesome]", "a feature test case that is invalid [Feature:Awesome]",
"[Feature:Awesome]", "[Feature:Awesome]",
@@ -176,12 +172,12 @@ func TestValidateTestName(t *testing.T) {
"[Alpha]", "[Alpha]",
}, },
{ {
"a test case with multiple invalid tags [Flaky][Disruptive] [Feature:Awesome] [Alpha]", "a test case with multiple invalid tags [Flaky] [Feature:Awesome] [Alpha]",
"[Flaky],[Disruptive],[Feature:Awesome],[Alpha]", "[Flaky],[Feature:Awesome],[Alpha]",
}, },
{ {
"[sig-awesome] [Disruptive] a test case with valid and invalid tags [Alpha] [Serial] [Flaky]", "[sig-awesome] [Alpha] [Disruptive] a test case with valid and invalid tags [Serial] [Flaky]",
"[Disruptive],[Alpha],[Flaky]", "[Alpha],[Flaky]",
}, },
} }
for i, tc := range testCases { for i, tc := range testCases {

4
test/e2e/scheduling/taints.go
View File

@@ -283,7 +283,7 @@ var _ = SIGDescribe("NoExecuteTaintManager Single Pod [Serial]", func() {
Description: The Pod with toleration timeout scheduled on a tainted Node MUST not be Description: The Pod with toleration timeout scheduled on a tainted Node MUST not be
evicted if the taint is removed before toleration time ends. evicted if the taint is removed before toleration time ends.
*/ */
framework.ConformanceIt("removing taint cancels eviction", func() { framework.ConformanceIt("removing taint cancels eviction [Disruptive]", func() {
podName := "taint-eviction-4" podName := "taint-eviction-4"
pod := createPodForTaintsTest(true, 2*additionalWaitPerDeleteSeconds, podName, podName, ns) pod := createPodForTaintsTest(true, 2*additionalWaitPerDeleteSeconds, podName, podName, ns)
observedDeletions := make(chan string, 100) observedDeletions := make(chan string, 100)
@@ -413,7 +413,7 @@ var _ = SIGDescribe("NoExecuteTaintManager Multiple Pods [Serial]", func() {
Description: In a multi-pods scenario with tolerationSeconds, the pods MUST be evicted as per Description: In a multi-pods scenario with tolerationSeconds, the pods MUST be evicted as per
the toleration time limit. the toleration time limit.
*/ */
framework.ConformanceIt("evicts pods with minTolerationSeconds", func() { framework.ConformanceIt("evicts pods with minTolerationSeconds [Disruptive]", func() {
podGroup := "taint-eviction-b" podGroup := "taint-eviction-b"
observedDeletions := make(chan string, 100) observedDeletions := make(chan string, 100)
stopCh := make(chan struct{}) stopCh := make(chan struct{})