scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-04 12:18:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7644 from liggitt/conversion_test

Browse Source 
Output generated conversion functions/names
This commit is contained in:
Wojciech Tyczynski
2015-05-04 08:17:03 +02:00
parent 982cac3e78 26caf9e0de
commit e225a2e777
1 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
pkg/conversion/code_generation_test.go
View File

@@ -21,6 +21,7 @@ import (
"bytes" "bytes"
"fmt" "fmt"
"io" "io"
"io/ioutil"
"os" "os"
"testing" "testing"
@@ -114,7 +115,8 @@ func bufferExistingConversions(t *testing.T, fileName string) (bytes.Buffer, byt
return functions, names return functions, names
} }
func compareBuffers(t *testing.T, existing, generated bytes.Buffer) { func compareBuffers(t *testing.T, generatedFile string, existing, generated bytes.Buffer) bool {
ok := true
for { for {
existingLine, existingErr := existing.ReadString('\n') existingLine, existingErr := existing.ReadString('\n')
generatedLine, generatedErr := generated.ReadString('\n') generatedLine, generatedErr := generated.ReadString('\n')
@@ -122,18 +124,22 @@ func compareBuffers(t *testing.T, existing, generated bytes.Buffer) {
break break
} }
if existingErr != generatedErr { if existingErr != generatedErr {
ok = false
t.Errorf("reading errors: existing %v generated %v", existingErr, generatedErr) t.Errorf("reading errors: existing %v generated %v", existingErr, generatedErr)
return return ok
} }
if existingErr != nil { if existingErr != nil {
ok = false
t.Errorf("error while reading: %v", existingErr) t.Errorf("error while reading: %v", existingErr)
} }
if existingLine != generatedLine { if existingLine != generatedLine {
ok = false
diff := fmt.Sprintf("first difference: expected %s, got %s", generatedLine, existingLine) diff := fmt.Sprintf("first difference: expected %s, got %s", generatedLine, existingLine)
t.Errorf("please regenerate conversion functions; %s", diff) t.Errorf("please update conversion functions; generated: %s; diff: %s", generatedFile, diff)
return return ok
} }
} }
return ok
} }
func TestNoManualChangesToGenerateConversions(t *testing.T) { func TestNoManualChangesToGenerateConversions(t *testing.T) {
@@ -145,7 +151,17 @@ func TestNoManualChangesToGenerateConversions(t *testing.T) {
existingFunctions, existingNames := bufferExistingConversions(t, fileName) existingFunctions, existingNames := bufferExistingConversions(t, fileName)
generatedFunctions, generatedNames := generateConversions(t, version) generatedFunctions, generatedNames := generateConversions(t, version)
compareBuffers(t, existingFunctions, generatedFunctions) functionsTxt := fmt.Sprintf("%s.functions.txt", version)
compareBuffers(t, existingNames, generatedNames) ioutil.WriteFile(functionsTxt, generatedFunctions.Bytes(), os.FileMode(0644))
namesTxt := fmt.Sprintf("%s.names.txt", version)
ioutil.WriteFile(namesTxt, generatedNames.Bytes(), os.FileMode(0644))
if ok := compareBuffers(t, functionsTxt, existingFunctions, generatedFunctions); ok {
os.Remove(functionsTxt)
}
if ok := compareBuffers(t, namesTxt, existingNames, generatedNames); ok {
os.Remove(namesTxt)
}
} }
} }