mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-03 19:58:17 +00:00 
			
		
		
		
	Increase the annotation size limit to 256k
This commit is contained in:
		@@ -60,7 +60,7 @@ var pdPartitionErrorMsg string = intervalErrorMsg(0, 255)
 | 
			
		||||
var portRangeErrorMsg string = intervalErrorMsg(0, 65536)
 | 
			
		||||
var portNameErrorMsg string = fmt.Sprintf(`must be an IANA_SVC_NAME (at most 15 characters, matching regex %s, it must contain at least one letter [a-z], and hyphens cannot be adjacent to other hyphens): e.g. "http"`, validation.IdentifierNoHyphensBeginEndFmt)
 | 
			
		||||
 | 
			
		||||
const totalAnnotationSizeLimitB int = 64 * (1 << 10) // 64 kB
 | 
			
		||||
const totalAnnotationSizeLimitB int = 256 * (1 << 10) // 256 kB
 | 
			
		||||
 | 
			
		||||
func ValidateLabelName(labelName, fieldName string) errs.ValidationErrorList {
 | 
			
		||||
	allErrs := errs.ValidationErrorList{}
 | 
			
		||||
 
 | 
			
		||||
@@ -191,10 +191,10 @@ func TestValidateAnnotations(t *testing.T) {
 | 
			
		||||
		{"1234/5678": "bar"},
 | 
			
		||||
		{"1.2.3.4/5678": "bar"},
 | 
			
		||||
		{"UpperCase123": "bar"},
 | 
			
		||||
		{"a": strings.Repeat("b", (64*1024)-1)},
 | 
			
		||||
		{"a": strings.Repeat("b", totalAnnotationSizeLimitB-1)},
 | 
			
		||||
		{
 | 
			
		||||
			"a": strings.Repeat("b", (32*1024)-1),
 | 
			
		||||
			"c": strings.Repeat("d", (32*1024)-1),
 | 
			
		||||
			"a": strings.Repeat("b", totalAnnotationSizeLimitB/2-1),
 | 
			
		||||
			"c": strings.Repeat("d", totalAnnotationSizeLimitB/2-1),
 | 
			
		||||
		},
 | 
			
		||||
	}
 | 
			
		||||
	for i := range successCases {
 | 
			
		||||
@@ -221,10 +221,10 @@ func TestValidateAnnotations(t *testing.T) {
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
	totalSizeErrorCases := []map[string]string{
 | 
			
		||||
		{"a": strings.Repeat("b", 64*1024)},
 | 
			
		||||
		{"a": strings.Repeat("b", totalAnnotationSizeLimitB)},
 | 
			
		||||
		{
 | 
			
		||||
			"a": strings.Repeat("b", 32*1024),
 | 
			
		||||
			"c": strings.Repeat("d", 32*1024),
 | 
			
		||||
			"a": strings.Repeat("b", totalAnnotationSizeLimitB/2),
 | 
			
		||||
			"c": strings.Repeat("d", totalAnnotationSizeLimitB/2),
 | 
			
		||||
		},
 | 
			
		||||
	}
 | 
			
		||||
	for i := range totalSizeErrorCases {
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user