mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-02 19:28:16 +00:00 
			
		
		
		
	Merge pull request #41877 from bruceauyeung/k8s-branch-preflight-check-etcd-version
Automatic merge from submit-queue (batch tested with PRs 41954, 40528, 41875, 41165, 41877) preflight check external etcd version when kubeadm init **What this PR does / why we need it**: 1. preflight check if verson of external etcd server meets the demand of kubeadm, currently requires >= 3.0.14 2. support mixed http endpoints and https endpoints **Which issue this PR fixes** : fixes https://github.com/kubernetes/kubeadm/issues/174 **Special notes for your reviewer**: i have tested against single endpoint including http etcd server , https etcd server, but multiple endpoints not tested yet. i'll do it tomorrow
This commit is contained in:
		@@ -94,6 +94,9 @@ const (
 | 
			
		||||
	CSVTokenBootstrapGroup = "kubeadm:kubelet-bootstrap"
 | 
			
		||||
	// The file name of the tokens file that can be used for bootstrapping
 | 
			
		||||
	CSVTokenFileName = "tokens.csv"
 | 
			
		||||
 | 
			
		||||
	// MinExternalEtcdVersion indicates minimum external etcd version which kubeadm supports
 | 
			
		||||
	MinExternalEtcdVersion = "3.0.14"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
var (
 | 
			
		||||
 
 | 
			
		||||
@@ -20,6 +20,8 @@ go_library(
 | 
			
		||||
        "//pkg/util/initsystem:go_default_library",
 | 
			
		||||
        "//pkg/util/node:go_default_library",
 | 
			
		||||
        "//test/e2e_node/system:go_default_library",
 | 
			
		||||
        "//vendor:github.com/PuerkitoBio/purell",
 | 
			
		||||
        "//vendor:github.com/blang/semver",
 | 
			
		||||
        "//vendor:k8s.io/apimachinery/pkg/util/errors",
 | 
			
		||||
    ],
 | 
			
		||||
)
 | 
			
		||||
@@ -29,7 +31,10 @@ go_test(
 | 
			
		||||
    srcs = ["checks_test.go"],
 | 
			
		||||
    library = ":go_default_library",
 | 
			
		||||
    tags = ["automanaged"],
 | 
			
		||||
    deps = ["//cmd/kubeadm/app/apis/kubeadm:go_default_library"],
 | 
			
		||||
    deps = [
 | 
			
		||||
        "//cmd/kubeadm/app/apis/kubeadm:go_default_library",
 | 
			
		||||
        "//vendor:github.com/renstrom/dedent",
 | 
			
		||||
    ],
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
filegroup(
 | 
			
		||||
 
 | 
			
		||||
@@ -19,13 +19,24 @@ package preflight
 | 
			
		||||
import (
 | 
			
		||||
	"bufio"
 | 
			
		||||
	"bytes"
 | 
			
		||||
	"encoding/json"
 | 
			
		||||
	"fmt"
 | 
			
		||||
	"io"
 | 
			
		||||
	"io/ioutil"
 | 
			
		||||
	"net"
 | 
			
		||||
	"net/http"
 | 
			
		||||
	"os"
 | 
			
		||||
	"os/exec"
 | 
			
		||||
	"path/filepath"
 | 
			
		||||
	"time"
 | 
			
		||||
 | 
			
		||||
	"crypto/tls"
 | 
			
		||||
	"crypto/x509"
 | 
			
		||||
 | 
			
		||||
	"github.com/PuerkitoBio/purell"
 | 
			
		||||
	"github.com/blang/semver"
 | 
			
		||||
 | 
			
		||||
	"net/url"
 | 
			
		||||
 | 
			
		||||
	utilerrors "k8s.io/apimachinery/pkg/util/errors"
 | 
			
		||||
	kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
 | 
			
		||||
@@ -37,7 +48,16 @@ import (
 | 
			
		||||
	"k8s.io/kubernetes/test/e2e_node/system"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
const bridgenf string = "/proc/sys/net/bridge/bridge-nf-call-iptables"
 | 
			
		||||
const (
 | 
			
		||||
	bridgenf                    = "/proc/sys/net/bridge/bridge-nf-call-iptables"
 | 
			
		||||
	externalEtcdRequestTimeout  = time.Duration(10 * time.Second)
 | 
			
		||||
	externalEtcdRequestRetries  = 3
 | 
			
		||||
	externalEtcdRequestInterval = time.Duration(5 * time.Second)
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
var (
 | 
			
		||||
	minExternalEtcdVersion = semver.MustParse(kubeadmconstants.MinExternalEtcdVersion)
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
type Error struct {
 | 
			
		||||
	Msg string
 | 
			
		||||
@@ -326,6 +346,139 @@ func (sysver SystemVerificationCheck) Check() (warnings, errors []error) {
 | 
			
		||||
	return nil, nil
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
type etcdVersionResponse struct {
 | 
			
		||||
	Etcdserver  string `json:"etcdserver"`
 | 
			
		||||
	Etcdcluster string `json:"etcdcluster"`
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// ExternalEtcdVersionCheck checks if version of external etcd meets the demand of kubeadm
 | 
			
		||||
type ExternalEtcdVersionCheck struct {
 | 
			
		||||
	Etcd kubeadmapi.Etcd
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func (evc ExternalEtcdVersionCheck) Check() (warnings, errors []error) {
 | 
			
		||||
	var config *tls.Config
 | 
			
		||||
	var err error
 | 
			
		||||
	if config, err = evc.configRootCAs(config); err != nil {
 | 
			
		||||
		errors = append(errors, err)
 | 
			
		||||
		return nil, errors
 | 
			
		||||
	}
 | 
			
		||||
	if config, err = evc.configCertAndKey(config); err != nil {
 | 
			
		||||
		errors = append(errors, err)
 | 
			
		||||
		return nil, errors
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	client := evc.getHTTPClient(config)
 | 
			
		||||
	for _, endpoint := range evc.Etcd.Endpoints {
 | 
			
		||||
		if _, err := url.Parse(endpoint); err != nil {
 | 
			
		||||
			errors = append(errors, fmt.Errorf("failed to parse external etcd endpoint %s : %v", endpoint, err))
 | 
			
		||||
			continue
 | 
			
		||||
		}
 | 
			
		||||
		resp := etcdVersionResponse{}
 | 
			
		||||
		var err error
 | 
			
		||||
		versionURL := fmt.Sprintf("%s/%s", endpoint, "version")
 | 
			
		||||
		if tmpVersionURL, err := purell.NormalizeURLString(versionURL, purell.FlagRemoveDuplicateSlashes); err != nil {
 | 
			
		||||
			errors = append(errors, fmt.Errorf("failed to normalize external etcd version url %s : %v", versionURL, err))
 | 
			
		||||
			continue
 | 
			
		||||
		} else {
 | 
			
		||||
			versionURL = tmpVersionURL
 | 
			
		||||
		}
 | 
			
		||||
		if err = getEtcdVersionResponse(client, versionURL, &resp); err != nil {
 | 
			
		||||
			errors = append(errors, err)
 | 
			
		||||
			continue
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		etcdVersion, err := semver.Parse(resp.Etcdserver)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			errors = append(errors, fmt.Errorf("couldn't parse external etcd version %q: %v", resp.Etcdserver, err))
 | 
			
		||||
			continue
 | 
			
		||||
		}
 | 
			
		||||
		if etcdVersion.LT(minExternalEtcdVersion) {
 | 
			
		||||
			errors = append(errors, fmt.Errorf("this version of kubeadm only supports external etcd version >= %s. Current version: %s", kubeadmconstants.MinExternalEtcdVersion, resp.Etcdserver))
 | 
			
		||||
			continue
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	return nil, errors
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// configRootCAs configures and returns a reference to tls.Config instance if CAFile is provided
 | 
			
		||||
func (evc ExternalEtcdVersionCheck) configRootCAs(config *tls.Config) (*tls.Config, error) {
 | 
			
		||||
	var CACertPool *x509.CertPool
 | 
			
		||||
	if evc.Etcd.CAFile != "" {
 | 
			
		||||
		CACert, err := ioutil.ReadFile(evc.Etcd.CAFile)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			return nil, fmt.Errorf("couldn't load external etcd's server certificate %s: %v", evc.Etcd.CAFile, err)
 | 
			
		||||
		}
 | 
			
		||||
		CACertPool = x509.NewCertPool()
 | 
			
		||||
		CACertPool.AppendCertsFromPEM(CACert)
 | 
			
		||||
	}
 | 
			
		||||
	if CACertPool != nil {
 | 
			
		||||
		if config == nil {
 | 
			
		||||
			config = &tls.Config{}
 | 
			
		||||
		}
 | 
			
		||||
		config.RootCAs = CACertPool
 | 
			
		||||
	}
 | 
			
		||||
	return config, nil
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
// configCertAndKey configures and returns a reference to tls.Config instance if CertFile and KeyFile pair is provided
 | 
			
		||||
func (evc ExternalEtcdVersionCheck) configCertAndKey(config *tls.Config) (*tls.Config, error) {
 | 
			
		||||
	var cert tls.Certificate
 | 
			
		||||
	if evc.Etcd.CertFile != "" && evc.Etcd.KeyFile != "" {
 | 
			
		||||
		var err error
 | 
			
		||||
		cert, err = tls.LoadX509KeyPair(evc.Etcd.CertFile, evc.Etcd.KeyFile)
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			return nil, fmt.Errorf("couldn't load external etcd's certificate and key pair %s, %s: %v", evc.Etcd.CertFile, evc.Etcd.KeyFile, err)
 | 
			
		||||
		}
 | 
			
		||||
		if config == nil {
 | 
			
		||||
			config = &tls.Config{}
 | 
			
		||||
		}
 | 
			
		||||
		config.Certificates = []tls.Certificate{cert}
 | 
			
		||||
	}
 | 
			
		||||
	return config, nil
 | 
			
		||||
}
 | 
			
		||||
func (evc ExternalEtcdVersionCheck) getHTTPClient(config *tls.Config) *http.Client {
 | 
			
		||||
	if config != nil {
 | 
			
		||||
		transport := &http.Transport{
 | 
			
		||||
			TLSClientConfig: config,
 | 
			
		||||
		}
 | 
			
		||||
		return &http.Client{
 | 
			
		||||
			Transport: transport,
 | 
			
		||||
			Timeout:   externalEtcdRequestTimeout,
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
	return &http.Client{Timeout: externalEtcdRequestTimeout}
 | 
			
		||||
}
 | 
			
		||||
func getEtcdVersionResponse(client *http.Client, url string, target interface{}) error {
 | 
			
		||||
	loopCount := externalEtcdRequestRetries + 1
 | 
			
		||||
	var err error
 | 
			
		||||
	var stopRetry bool
 | 
			
		||||
	for loopCount > 0 {
 | 
			
		||||
		if loopCount <= externalEtcdRequestRetries {
 | 
			
		||||
			time.Sleep(externalEtcdRequestInterval)
 | 
			
		||||
		}
 | 
			
		||||
		stopRetry, err = func() (stopRetry bool, err error) {
 | 
			
		||||
			r, err := client.Get(url)
 | 
			
		||||
			if err != nil {
 | 
			
		||||
				loopCount--
 | 
			
		||||
				return false, nil
 | 
			
		||||
			}
 | 
			
		||||
			defer r.Body.Close()
 | 
			
		||||
 | 
			
		||||
			if r != nil && r.StatusCode >= 500 && r.StatusCode <= 599 {
 | 
			
		||||
				loopCount--
 | 
			
		||||
				return false, nil
 | 
			
		||||
			}
 | 
			
		||||
			return true, json.NewDecoder(r.Body).Decode(target)
 | 
			
		||||
 | 
			
		||||
		}()
 | 
			
		||||
		if stopRetry {
 | 
			
		||||
			break
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
	return err
 | 
			
		||||
}
 | 
			
		||||
func RunInitMasterChecks(cfg *kubeadmapi.MasterConfiguration) error {
 | 
			
		||||
	checks := []Checker{
 | 
			
		||||
		SystemVerificationCheck{},
 | 
			
		||||
@@ -360,6 +513,11 @@ func RunInitMasterChecks(cfg *kubeadmapi.MasterConfiguration) error {
 | 
			
		||||
			PortOpenCheck{port: 2379},
 | 
			
		||||
			DirAvailableCheck{Path: "/var/lib/etcd"},
 | 
			
		||||
		)
 | 
			
		||||
	} else {
 | 
			
		||||
		// Only check etcd version when external endpoints are specified
 | 
			
		||||
		checks = append(checks,
 | 
			
		||||
			ExternalEtcdVersionCheck{Etcd: cfg.Etcd},
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	// Check the config for authorization mode
 | 
			
		||||
 
 | 
			
		||||
@@ -19,12 +19,146 @@ package preflight
 | 
			
		||||
import (
 | 
			
		||||
	"bytes"
 | 
			
		||||
	"fmt"
 | 
			
		||||
	"io/ioutil"
 | 
			
		||||
	"testing"
 | 
			
		||||
 | 
			
		||||
	"github.com/renstrom/dedent"
 | 
			
		||||
 | 
			
		||||
	"os"
 | 
			
		||||
 | 
			
		||||
	"k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
 | 
			
		||||
	kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
var (
 | 
			
		||||
	externalEtcdRootCAFileContent = dedent.Dedent(`
 | 
			
		||||
		-----BEGIN CERTIFICATE-----
 | 
			
		||||
		MIIFrjCCA5agAwIBAgIUJAM5bQz/Ann8qye8T7Uyl+cAt3wwDQYJKoZIhvcNAQEN
 | 
			
		||||
		BQAwbzEOMAwGA1UEBhMFQ2hpbmExDzANBgNVBAgTBkhhaW5hbjEOMAwGA1UEBxMF
 | 
			
		||||
		U2FueWExDTALBgNVBAoTBGV0Y2QxFjAUBgNVBAsTDWV0Y2Qgc2VjdXJpdHkxFTAT
 | 
			
		||||
		BgNVBAMTDGV0Y2Qtcm9vdC1jYTAeFw0xNzAyMjIwNzEyMDBaFw0yMjAyMjEwNzEy
 | 
			
		||||
		MDBaMG8xDjAMBgNVBAYTBUNoaW5hMQ8wDQYDVQQIEwZIYWluYW4xDjAMBgNVBAcT
 | 
			
		||||
		BVNhbnlhMQ0wCwYDVQQKEwRldGNkMRYwFAYDVQQLEw1ldGNkIHNlY3VyaXR5MRUw
 | 
			
		||||
		EwYDVQQDEwxldGNkLXJvb3QtY2EwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIK
 | 
			
		||||
		AoICAQDD16VNTwvEvy1yd/vt8Eq2NwTw51mKHGYlZwsDqdqMEnEiWoJ7Iv9HZ+cl
 | 
			
		||||
		jX0FnahKnaV76j3xPO73L5WOvRYxnZ8MvU/aBdDO+Tct4ht3m7TJaav6s55otjDy
 | 
			
		||||
		dQNmlpBt4fFEB/nDozQaocfu2mqr5nyKJOjJpe+57Uw4h0LshreDOlzHEs8CkP6W
 | 
			
		||||
		/B9yGFARVyz84YgVtemUX8WTB3cVU49KEYMCuhqXY8s97xSTGT/4Tq/MruKb2V+w
 | 
			
		||||
		uUPjvyO5eIUcWetjBhgEGsS37NrsSFhoUNMp/PtIkth0LQoWb9sjnG069KIQqm61
 | 
			
		||||
		1PKxH7jgLYLf4q455iAuTFr0lF1OcmICTeJB+GiS+3ubOb1TH3AYICXvQUniNWJx
 | 
			
		||||
		sDz3qUUu4GLHk9wHtdNmX2FXYB8kHMZAidDM4Zw3IhZZap6n6BlGVVBV5h8sNM3t
 | 
			
		||||
		SB+pDLuAaZLx3/ah2ds6AwkfaMdYDsE/MWcWQqzBfhOp758Mx3dF16IY+6IQp0RS
 | 
			
		||||
		8qGKxgLDnTF9LgyHVOait2N/pT54faf8//ShSqTqzTK1wzHCkYwL6/B259zXWxeX
 | 
			
		||||
		z4gOpQOk4rO4pgm/65QW9aKzHoQnpQ7lFQL2cdsKJv2tyC7pDfVrFy2uHWaUibbP
 | 
			
		||||
		7pDw3OD8MQwR1TuhflK1AIicpMQe/kTAuRwH4fneeaGVdddBQQIDAQABo0IwQDAO
 | 
			
		||||
		BgNVHQ8BAf8EBAMCAQYwDwYDVR0TAQH/BAUwAwEB/zAdBgNVHQ4EFgQUtoqcReNJ
 | 
			
		||||
		p8z8Hz1/Q7XMK2fgi74wDQYJKoZIhvcNAQENBQADggIBADbh4HB//Gb0TUUEPoSw
 | 
			
		||||
		VMJSUK1pb6KVTqAITSCKPwGT8KfCvVpUxEjh9J3dm1L8wbdr48yffdjhdl96cx2F
 | 
			
		||||
		aGWdUIxRBIcpt5xvauBoj0OwfNcD5B9q1aKuh5XPNu4BndNeGw51vdJ8bJbtrZa8
 | 
			
		||||
		wKWF/PHciCo/wlzE/YgsemHeY5bYeXawXVP/+ocoLH82Fb8Aq0Af3ZABiA6fmawz
 | 
			
		||||
		FiZlnIrZnHVJYSap4yDhC/AQECXKY5gj7kjSnDebsIYds5OrW0D3LeRzs+q5nQXE
 | 
			
		||||
		xR35qg834kxUULS8AywqmR3+zjfeymm2FtsjT/PuzEImA80y29qpLZIpPg0meKHF
 | 
			
		||||
		pCMJkEHaRh4/JAinLaKCGLpnchqBy7CR6yvVnGkx93J0louIbVyUfn63R6mxCvd7
 | 
			
		||||
		kL16a2xBMKgV4RDFcu+VYjbJTFdWOTGFrxPBmd/rLdwD3XNiwPtI0vXGM7I35DDP
 | 
			
		||||
		SWwKVvR97F3uEnIQ1u8vHa1pNfQ1qSf/+hUJx2D9ypr7LTQ0LpLh1vUeTeUAVHmT
 | 
			
		||||
		EEpcqzDg6lsqXw6KHJ55kd3QR/hRXd/Vr6EWUawDEnGjxyFVV2dTBbunsbSobNI4
 | 
			
		||||
		eKV+60oCk3NMwrZoLw4Fv5qs2saS62dgJNfxbKqBX9ljSQxGzHjRwh+hVByCnG8m
 | 
			
		||||
		Z9JkQayesM6D7uwbQJXd5rgy
 | 
			
		||||
		-----END CERTIFICATE-----
 | 
			
		||||
	`)
 | 
			
		||||
 | 
			
		||||
	externalEtcdCertFileContent = dedent.Dedent(`
 | 
			
		||||
		-----BEGIN CERTIFICATE-----
 | 
			
		||||
		MIIGEjCCA/qgAwIBAgIURHJFslbPveA1WwQ4FaPJg1x6B8YwDQYJKoZIhvcNAQEN
 | 
			
		||||
		BQAwbzEOMAwGA1UEBhMFQ2hpbmExDzANBgNVBAgTBkhhaW5hbjEOMAwGA1UEBxMF
 | 
			
		||||
		U2FueWExDTALBgNVBAoTBGV0Y2QxFjAUBgNVBAsTDWV0Y2Qgc2VjdXJpdHkxFTAT
 | 
			
		||||
		BgNVBAMTDGV0Y2Qtcm9vdC1jYTAeFw0xNzAyMjIwNzE0MDBaFw0yNzAyMjAwNzE0
 | 
			
		||||
		MDBaMGwxDjAMBgNVBAYTBUNoaW5hMQ8wDQYDVQQIEwZIYWluYW4xDjAMBgNVBAcT
 | 
			
		||||
		BVNhbnlhMQ0wCwYDVQQKEwRldGNkMRYwFAYDVQQLEw1ldGNkIHNlY3VyaXR5MRIw
 | 
			
		||||
		EAYDVQQDEwlteS1ldGNkLTEwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoIC
 | 
			
		||||
		AQCmCR4OSRrUCES90sUbj5tvjF24lPCMj7qP9MBUxcVvWfaJM12o4AxqBr8OThgd
 | 
			
		||||
		lpNvlbKmRpfvbraXiDnuGty1vPa3z7RmKbwFgENfgKHz4fUw/MQ7CALOQ5PAvgf1
 | 
			
		||||
		rQ6Ii4cr49nWctpQmBXHtZRjvquBYnw70KrWfQ121DwPYy7cb/StuHLsTgqsgzhl
 | 
			
		||||
		ECILWCj9GNqcGQr5+ZvwUxa2yam2CS1M+PLbB6HxX/4RBBTWKAt8+kjt6TxxMaSE
 | 
			
		||||
		bNDHNDLWzQSpxg5qTLOQtrubFD4O3JT2E8DEj+LvXJKH7pJd1Z+r0m3ymQvBAIXr
 | 
			
		||||
		6OJs+sHbaaxKWS35k9m88NRojR+r5KPoEcBgxhtBtXUfMS5v5dTtcNsHl/mHmTC+
 | 
			
		||||
		gWiqpzA+tF55uUEWhRoA+pN7Ie2PviRhG43t99l7bsHVnrxZQqWsWlvCxMN1c2+7
 | 
			
		||||
		PRwhsYZFITyKcMSvd19Nb5HGc5hT7btZlWc2xKS2YNnDXbD8C5SdxZek5Cb/xRxL
 | 
			
		||||
		T8taf2c1bHs8sZrzIK2DCGvaN3471WEnmaCuRWr2fqyJeCPwsvvWeNDVmgPP6v7g
 | 
			
		||||
		ncyy+4QyyfNrdURTZFyw81ZbCiznPc070u7vtIYt3Sa0NXd0oEG1ybAZwBIYhMOY
 | 
			
		||||
		5ctepJLf7QxHXR70RdI0ksHEmZGZ1igk7gzhmHEgQM87pQIDAQABo4GoMIGlMA4G
 | 
			
		||||
		A1UdDwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDAQYIKwYBBQUHAwIwDAYD
 | 
			
		||||
		VR0TAQH/BAIwADAdBgNVHQ4EFgQU0U/Zn4mc95UXm+LVO67wqJpL9gIwHwYDVR0j
 | 
			
		||||
		BBgwFoAUtoqcReNJp8z8Hz1/Q7XMK2fgi74wJgYDVR0RBB8wHYIJbG9jYWxob3N0
 | 
			
		||||
		hwR/AAABhwQKcjPGhwQKcgwwMA0GCSqGSIb3DQEBDQUAA4ICAQCikW5SNpndBxEz
 | 
			
		||||
		qblER72KkfSEXMFhQry3RZJeAw6rQiOl+PMJqMnylcepOAUrNi20emS270dQDh3z
 | 
			
		||||
		Hw/JBgKftZ1JrjbF9NF4oFUZcFUKmTgyWYnhLH0BskgwJf2u+DpugFa4U8niQf15
 | 
			
		||||
		ciZGoUfWCGOJbgVP7esdnyhH/P/DpOEObWf8vOfvfQ49r7MzATyzMESyJjdtAH/F
 | 
			
		||||
		c5JKACxpJhaYfTZ78F43jSw0vswBdLQ7fJWqg/sJBlTG0GBFJcEJzFVpwzYUxwZ4
 | 
			
		||||
		rUpAn4A02M2V9XDNlptrWvcQz/5Vs/aCmehz7GOiMJB6SLWcMSpJRLMqoJjaFVfO
 | 
			
		||||
		OPm7bWMMaVOUPedzvcBKRXmEAg7HQnm3ibkVNjTW8Hr66n34Yk/dO9WXD+6IXnOQ
 | 
			
		||||
		bMY+Mf9vpIsscSpGTO15sAKqiXCzHR9RWqNd4U3jvo3JtewkNMhIKzPThgYNfsO3
 | 
			
		||||
		7HSrlfffeEQKc59rDUaC3Y9YSc5ERJRMC+mdOqXNMy2iedZnNEsmgYlaVDg6xfG8
 | 
			
		||||
		65w9UkMOe+DTJtMHnMxP4rT6WE4cKysQeSYxkyo/jh+8rKEy9+AyuEntJAknABUc
 | 
			
		||||
		N5mizdYu8nrtiSu9jdLKhwO41gC2IlXPUHizylo6g24RFVBjHLlzYAAsVMMMSQW1
 | 
			
		||||
		XRMVQjawUTknbAgHuE7/rEX8c27WUA==
 | 
			
		||||
		-----END CERTIFICATE-----
 | 
			
		||||
	`)
 | 
			
		||||
	externalEtcdKeyFileContent = dedent.Dedent(`
 | 
			
		||||
		-----BEGIN RSA PRIVATE KEY-----
 | 
			
		||||
		MIIJKAIBAAKCAgEApgkeDkka1AhEvdLFG4+bb4xduJTwjI+6j/TAVMXFb1n2iTNd
 | 
			
		||||
		qOAMaga/Dk4YHZaTb5WypkaX7262l4g57hrctbz2t8+0Zim8BYBDX4Ch8+H1MPzE
 | 
			
		||||
		OwgCzkOTwL4H9a0OiIuHK+PZ1nLaUJgVx7WUY76rgWJ8O9Cq1n0NdtQ8D2Mu3G/0
 | 
			
		||||
		rbhy7E4KrIM4ZRAiC1go/RjanBkK+fmb8FMWtsmptgktTPjy2weh8V/+EQQU1igL
 | 
			
		||||
		fPpI7ek8cTGkhGzQxzQy1s0EqcYOakyzkLa7mxQ+DtyU9hPAxI/i71ySh+6SXdWf
 | 
			
		||||
		q9Jt8pkLwQCF6+jibPrB22msSlkt+ZPZvPDUaI0fq+Sj6BHAYMYbQbV1HzEub+XU
 | 
			
		||||
		7XDbB5f5h5kwvoFoqqcwPrReeblBFoUaAPqTeyHtj74kYRuN7ffZe27B1Z68WUKl
 | 
			
		||||
		rFpbwsTDdXNvuz0cIbGGRSE8inDEr3dfTW+RxnOYU+27WZVnNsSktmDZw12w/AuU
 | 
			
		||||
		ncWXpOQm/8UcS0/LWn9nNWx7PLGa8yCtgwhr2jd+O9VhJ5mgrkVq9n6siXgj8LL7
 | 
			
		||||
		1njQ1ZoDz+r+4J3MsvuEMsnza3VEU2RcsPNWWwos5z3NO9Lu77SGLd0mtDV3dKBB
 | 
			
		||||
		tcmwGcASGITDmOXLXqSS3+0MR10e9EXSNJLBxJmRmdYoJO4M4ZhxIEDPO6UCAwEA
 | 
			
		||||
		AQKCAgEAmr3OlDPP3CLkpiFEcJ5TmA+y3S96TRY7IqVRhvBXRKMMoOwNczF0gHBP
 | 
			
		||||
		Ka7gzNqkCA/1UwBh49VEOU/N5bqFTp+RNNhQYhKtWFck82H4Dkrd8EzzOa0KqF/U
 | 
			
		||||
		2YKB+pbR/7JCRUZypGmgTBKh4eG6LYfrYYd/D2Q3g/VCUigU3aZrayiwWiOYf+Fw
 | 
			
		||||
		Ez2slowFnpsIgHHkdCzmzPi0O7PEbJDgKXa+EInIFRg09renGwa5wKnLoyvEQm7o
 | 
			
		||||
		VPqWQJEFt1JPu1+R5ARhNPLNO6cCi9K+z60G65yXQNp0/u5A5o0TPn609DcHH11B
 | 
			
		||||
		1ht9tNL0C+tcNvhyiUw6C+uet3egDVu1TqptzAfb2Y3MQK6UV/by7KJxcFxBAzWl
 | 
			
		||||
		UQ4zDaQzCcU81T92zI+XeRSJuCPuOL61mH7zEiPZZPOLV8MbxBX/7lj+IJTBL+vJ
 | 
			
		||||
		Idq7Nn/+LRtuSy5PH2MzZ5DzIMmjkjQ/ScpzAr9Zpkm3dpTcGTpFV0uqHseE77Re
 | 
			
		||||
		55tz9uB7pxV1n6Gz4uMNnsioEYsFIRfzst4QWDdaQqcYJQuKvW9pXNmgRgSCIlft
 | 
			
		||||
		54DxQ98a1PVFmS40TT9mjUg0P66m+8bk5vEb58iAjoYJRcoriZhlT6cOcuPW6hos
 | 
			
		||||
		3PfA2gMXuWu61mAjzdP0zbzNBXCn5nRppqLNmWMVZCI0nLjmyZUCggEBAMEpCQu9
 | 
			
		||||
		cRWc/GjvmnfXHewvqQHu3A3J1HCLR0VqJo8rcIIvhSe7dPRAMtUFxV1R2eOfMvSZ
 | 
			
		||||
		Y4y69tMHZPVTgnp2t5TSavjpMqSQLvXyBkgL8FnGEl5l6HEQTm8y0C13Cm+CUB5a
 | 
			
		||||
		uxQnQflkX539SjWX0XdOmYuLORmrKGxgcDOd9652fDJcFSXYa0mx6KN2JZHh9psA
 | 
			
		||||
		9ldHhUIq1ngoVnrctlK53MptckPrFwMFdXRCKiMfkvpUkXTeXu4D7Z1VNh2V/3gF
 | 
			
		||||
		lmRNioXaxp7W8omBSQlwaHY5btPj5jktiC9/so4ORqJjHvbCURrIvdkPPaXi/YJy
 | 
			
		||||
		HdoOgHYFnn3p6M8CggEBANwNDtdbHWwwVC7Op6TNc8qK+SWAId5RqPOmM70XBVvg
 | 
			
		||||
		u9nxT7a5vmRTs81fcVoxtE0t+KWIfOXquxqTbk0ONqIsl2CLTiTFaNHoHlvwgFBT
 | 
			
		||||
		aYukORiGILIzOJr82RPugAw1+j8jmw3OsCOXnf2odGs+oC/V9vEd9NyZpDHPohtK
 | 
			
		||||
		a8Bk8p326mQam23ArUesIqnw31fG22KRpoLXuk/9nNcAAAZd1Qd9hGWf0HHxunXB
 | 
			
		||||
		wj6e3VTm0G4NPTli5vmVavYRPMFUUJpU5lwTHhlrHTSmANHTjZGnn0mEOfIrfodF
 | 
			
		||||
		ODwJjwoyq4rPls0fqOvyAyBCnhop4fC8yOd4cQcLSUsCggEAbv9Br3lhLmZTtYla
 | 
			
		||||
		XltDWqHYoL+9vD6q0TF39y+UkNkJggYEolxaTLFHhJoYXBPY/bBR+7TZO9mEVKf/
 | 
			
		||||
		H+qpI+5seByiU/7NlzszgSle6q/RogTsMUqmU7JnIAc3EalCWemsWIUS0/XrN4Cy
 | 
			
		||||
		YXtX1Yw0VjbYjROn8FQmmoCgeUjhN2Pm4pl/nYvLu0F8ydHurPIIX/IhnO4AaZFs
 | 
			
		||||
		RQgJCfki3E7pzXkvHFBPnPDaGcCbritKrodCPsI6EtQ3Cx4YRtAXScUMMv9MBrc9
 | 
			
		||||
		Q7GJFfMxITdzD9zZDvH7Lgg4JfNfi7owZMhI1su7B4UrczwK1PSncPpapR+IOkno
 | 
			
		||||
		VbrAiQKCAQB2xGV6PqdGuV72VHuPK4SPkSqf3uRoxdJWjyHlsQMnb8hz/RZ1HRNx
 | 
			
		||||
		uuuUsSrQ73rNHT7SuTQQM/0AfwpNdJpwNXkOlqF6n0HP6WRZYxkeQab5w409e0cy
 | 
			
		||||
		ZwrqPAY+B7/81zVV1rXdYe0XiMGxIraTG54Bs44w3WZHmnVQnSx1Zll54gJA1//y
 | 
			
		||||
		P5ocRp4/zNx4tJUXHzFRpiMlA6J/gfag5FMfHI3aGRjYcMVken+VBxr8CWqUZG+i
 | 
			
		||||
		tmqRCpx3oPm2Dd+oyQUoByK+F2NrfLCqtd5DYddLAhmq6D8OQgNspyOO4+ncKzUD
 | 
			
		||||
		Gr/dvnTBxEGDq/EBVhGoiXw10n/OuXy5AoIBAAUAoTyt4gQjjC0ddtMLN7+R1Ymp
 | 
			
		||||
		eNULpq2XTvidj7jaysIW9Q52ncvN6h2Vds/Z3Ujvdne2jMq7Q/C96fKcrhgMH9ca
 | 
			
		||||
		ADGLWtD+VkP4NgFjj7R2jabF8d9IQdJDXAgvR/kokojF0RsJuvD2hawN6lQkkj6S
 | 
			
		||||
		fNNGMBk4sGyt7gzAn3iO4Zoy+QjtALNnZcaH6s7oIg3UKf6OwskiBB60Q5P1U3/E
 | 
			
		||||
		RPtTxhex3jFuySNJ413JgyGkvcP+qjuzi6eyVDxkfiyNohQYGuZ8rieFX7QfQFAY
 | 
			
		||||
		TIXptchVUTxmGKWzcpLC3AfkwFvV2IPoMk8YnDSp270D30cqWiI9puSEcxQ=
 | 
			
		||||
		-----END RSA PRIVATE KEY-----
 | 
			
		||||
	`)
 | 
			
		||||
)
 | 
			
		||||
 | 
			
		||||
type preflightCheckTest struct {
 | 
			
		||||
	msg string
 | 
			
		||||
}
 | 
			
		||||
@@ -125,3 +259,80 @@ func TestRunChecks(t *testing.T) {
 | 
			
		||||
		}
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
func TestConfigRootCAs(t *testing.T) {
 | 
			
		||||
	f, err := ioutil.TempFile(os.TempDir(), "kubeadm-external-etcd-test-cafile")
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		t.Errorf("failed configRootCAs:\n\texpected: succeed creating temp CA file\n\tactual:%v", err)
 | 
			
		||||
	}
 | 
			
		||||
	defer os.Remove(f.Name())
 | 
			
		||||
	if err := ioutil.WriteFile(f.Name(), []byte(externalEtcdRootCAFileContent), 0644); err != nil {
 | 
			
		||||
		t.Errorf("failed configRootCAs:\n\texpected: succeed writing contents to temp CA file %s\n\tactual:%v", f.Name(), err)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	c := ExternalEtcdVersionCheck{Etcd: kubeadmapi.Etcd{CAFile: f.Name()}}
 | 
			
		||||
 | 
			
		||||
	config, err := c.configRootCAs(nil)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configRootCAs:\n\texpected: has no error\n\tactual:%v",
 | 
			
		||||
			err,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
	if config.RootCAs == nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configRootCAs:\n\texpected: RootCAs not equal to nil\n\tactual:%v",
 | 
			
		||||
			config.RootCAs,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
func TestConfigCertAndKey(t *testing.T) {
 | 
			
		||||
	certFile, err := ioutil.TempFile(os.TempDir(), "kubeadm-external-etcd-test-certfile")
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configCertAndKey:\n\texpected: succeed creating temp CertFile file\n\tactual:%v",
 | 
			
		||||
			err,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
	defer os.Remove(certFile.Name())
 | 
			
		||||
	if err := ioutil.WriteFile(certFile.Name(), []byte(externalEtcdCertFileContent), 0644); err != nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configCertAndKey:\n\texpected: succeed writing contents to temp CertFile file %s\n\tactual:%v",
 | 
			
		||||
			certFile.Name(),
 | 
			
		||||
			err,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	keyFile, err := ioutil.TempFile(os.TempDir(), "kubeadm-external-etcd-test-keyfile")
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configCertAndKey:\n\texpected: succeed creating temp KeyFile file\n\tactual:%v",
 | 
			
		||||
			err,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
	defer os.Remove(keyFile.Name())
 | 
			
		||||
	if err := ioutil.WriteFile(keyFile.Name(), []byte(externalEtcdKeyFileContent), 0644); err != nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configCertAndKey:\n\texpected: succeed writing contents to temp KeyFile file %s\n\tactual:%v",
 | 
			
		||||
			keyFile.Name(),
 | 
			
		||||
			err,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
	c := ExternalEtcdVersionCheck{Etcd: kubeadmapi.Etcd{
 | 
			
		||||
		CertFile: certFile.Name(),
 | 
			
		||||
		KeyFile:  keyFile.Name(),
 | 
			
		||||
	}}
 | 
			
		||||
 | 
			
		||||
	config, err := c.configCertAndKey(nil)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configCertAndKey:\n\texpected: has no error\n\tactual:%v",
 | 
			
		||||
			err,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
	if config.Certificates == nil {
 | 
			
		||||
		t.Errorf(
 | 
			
		||||
			"failed configCertAndKey:\n\texpected: Certificates not equal to nil\n\tactual:%v",
 | 
			
		||||
			config.Certificates,
 | 
			
		||||
		)
 | 
			
		||||
	}
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user