mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-03 19:58:17 +00:00 
			
		
		
		
	Return error for empty sysctl names
This commit is contained in:
		@@ -577,7 +577,7 @@ func SysctlsFromPodAnnotation(annotation string) ([]Sysctl, error) {
 | 
			
		||||
	sysctls := make([]Sysctl, len(kvs))
 | 
			
		||||
	for i, kv := range kvs {
 | 
			
		||||
		cs := strings.Split(kv, "=")
 | 
			
		||||
		if len(cs) != 2 {
 | 
			
		||||
		if len(cs) != 2 || len(cs[0]) == 0 {
 | 
			
		||||
			return nil, fmt.Errorf("sysctl %q not of the format sysctl_name=value", kv)
 | 
			
		||||
		}
 | 
			
		||||
		sysctls[i].Name = cs[0]
 | 
			
		||||
 
 | 
			
		||||
@@ -508,6 +508,14 @@ func TestSysctlsFromPodAnnotation(t *testing.T) {
 | 
			
		||||
			annotation: "foo.bar",
 | 
			
		||||
			expectErr:  true,
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			annotation: "=123",
 | 
			
		||||
			expectErr:  true,
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			annotation:  "foo.bar=",
 | 
			
		||||
			expectValue: []Sysctl{{Name: "foo.bar", Value: ""}},
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			annotation:  "foo.bar=42",
 | 
			
		||||
			expectValue: []Sysctl{{Name: "foo.bar", Value: "42"}},
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user