mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-04 04:08:16 +00:00 
			
		
		
		
	don't wait blindly
This commit is contained in:
		@@ -574,8 +574,18 @@ var _ = SIGDescribe("Garbage collector", func() {
 | 
				
			|||||||
		if err := deployClient.Delete(deployment.ObjectMeta.Name, deleteOptions); err != nil {
 | 
							if err := deployClient.Delete(deployment.ObjectMeta.Name, deleteOptions); err != nil {
 | 
				
			||||||
			framework.Failf("failed to delete the deployment: %v", err)
 | 
								framework.Failf("failed to delete the deployment: %v", err)
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
		ginkgo.By("wait for 30 seconds to see if the garbage collector mistakenly deletes the rs")
 | 
							ginkgo.By("wait for deployment deletion to see if the garbage collector mistakenly deletes the rs")
 | 
				
			||||||
		time.Sleep(30 * time.Second)
 | 
							err = wait.PollImmediate(500*time.Millisecond, 1*time.Minute, func() (bool, error) {
 | 
				
			||||||
 | 
								dList, err := deployClient.List(metav1.ListOptions{})
 | 
				
			||||||
 | 
								if err != nil {
 | 
				
			||||||
 | 
									return false, fmt.Errorf("failed to list deployments: %v", err)
 | 
				
			||||||
 | 
								}
 | 
				
			||||||
 | 
								return len(dList.Items) == 0, nil
 | 
				
			||||||
 | 
							})
 | 
				
			||||||
 | 
							if err != nil {
 | 
				
			||||||
 | 
								framework.Failf("Failed to wait for the Deployment to be deleted: %v", err)
 | 
				
			||||||
 | 
							}
 | 
				
			||||||
 | 
							// Once the deployment object is gone, we'll know the GC has finished performing any relevant actions.
 | 
				
			||||||
		objects := map[string]int{"Deployments": 0, "ReplicaSets": 1, "Pods": 2}
 | 
							objects := map[string]int{"Deployments": 0, "ReplicaSets": 1, "Pods": 2}
 | 
				
			||||||
		ok, err := verifyRemainingObjects(f, objects)
 | 
							ok, err := verifyRemainingObjects(f, objects)
 | 
				
			||||||
		if err != nil {
 | 
							if err != nil {
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user