scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-12-16 21:07:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update scheduler's RunFilterPlugins to return a plugin to status map

Browse Source
This commit is contained in:
Abdullah Gharaibeh
2020-01-08 13:26:10 -05:00
parent 79bb357193
commit f3c7a4c823
6 changed files with 116 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
pkg/scheduler/framework/v1alpha1/framework.go
View File

@@ -415,37 +415,36 @@ func (f *framework) RunFilterPlugins(
state *CycleState,
pod *v1.Pod,
nodeInfo *schedulernodeinfo.NodeInfo,
) (finalStatus *Status) {
) PluginToStatus {
var firstFailedStatus *Status
if state.ShouldRecordFrameworkMetrics() {
startTime := time.Now()
defer func() {
f.metricsRecorder.observeExtensionPointDurationAsync(filter, finalStatus, metrics.SinceInSeconds(startTime))
f.metricsRecorder.observeExtensionPointDurationAsync(filter, firstFailedStatus, metrics.SinceInSeconds(startTime))
}()
}
statuses := make(PluginToStatus)
for _, pl := range f.filterPlugins {
pluginStatus := f.runFilterPlugin(ctx, pl, state, pod, nodeInfo)
if len(statuses) == 0 {
firstFailedStatus = pluginStatus
}
if !pluginStatus.IsSuccess() {
if !pluginStatus.IsUnschedulable() {
// Filter plugins are not supposed to return any status other than
// Success or Unschedulable.
return NewStatus(Error, fmt.Sprintf("running %q filter plugin for pod %q: %v", pl.Name(), pod.Name, pluginStatus.Message()))
firstFailedStatus = NewStatus(Error, fmt.Sprintf("running %q filter plugin for pod %q: %v", pl.Name(), pod.Name, pluginStatus.Message()))
return map[string]*Status{pl.Name(): firstFailedStatus}
}
statuses[pl.Name()] = pluginStatus
if !f.runAllFilters {
// Exit early if we don't need to run all filters.
return pluginStatus
return statuses
}
// We need to continue and run all filters.
if finalStatus.IsSuccess() {
// This is the first failed plugin.
finalStatus = pluginStatus
continue
}
// We get here only if more than one Filter return unschedulable and runAllFilters is true.
finalStatus.reasons = append(finalStatus.reasons, pluginStatus.reasons...)
}
}
return finalStatus
return statuses
}
func (f *framework) runFilterPlugin(ctx context.Context, pl FilterPlugin, state *CycleState, pod *v1.Pod, nodeInfo *schedulernodeinfo.NodeInfo) *Status {