cleanup TODOs in dockershim

This commit is contained in:
Pengfei Ni
2016-11-07 11:41:06 +08:00
parent 3aee57d4ae
commit f8e5f81fed
4 changed files with 17 additions and 13 deletions

View File

@@ -61,6 +61,9 @@ func TestModifyContainerConfig(t *testing.T) {
func TestModifyHostConfig(t *testing.T) {
priv := true
setNetworkHC := &dockercontainer.HostConfig{
NetworkMode: "none",
}
setPrivSC := &runtimeapi.LinuxContainerSecurityContext{}
setPrivSC.Privileged = &priv
setPrivHC := &dockercontainer.HostConfig{
@@ -92,6 +95,11 @@ func TestModifyHostConfig(t *testing.T) {
sc: fullValidSecurityContext(),
expected: fullValidHostConfig(),
},
{
name: "empty container.SecurityContext",
sc: &runtimeapi.LinuxContainerSecurityContext{},
expected: setNetworkHC,
},
{
name: "container.SecurityContext.Privileged",
sc: setPrivSC,