485 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
1c756849d6 Merge pull request #130591 from fmuyassarov/devel/logging
Refine logging levels in job, IPAM, and replicaSet
2025-03-12 07:13:47 -07:00
Feruzjon Muyassarov
4c6971007b Refine logging levels in Job, IPAM, and ReplicaSet controllers.
Adjust logging levels in Job, IPAM, and ReplicaSet controllers from
V(0) to V(2), V(4), V(4) respectively to reduce noise. These logs
provide minimal value at the debug level (V(0)), so they have been
adjusted for better log clarity

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
2025-03-11 10:25:16 +02:00
Yuki Iwai
8202b791e9 Job: Use jobSuspended util for suspended detection
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2025-03-05 18:12:59 +09:00
Michal Wozniak
a91ed902fe Graduate Backoff Limit Per Index as stable
Reenable the JobBackoffLimitPerIndex_Reenabling integration test
2025-02-26 17:06:37 +01:00
Gunju Kim
0bee0bcaa7 Promote SidecarContainers feature to GA 2025-02-02 17:45:36 +09:00
Patrick Ohly
8a908e0c0b remove import doc comments
The "// import <path>" comment has been superseded by Go modules.
We don't have to remove them, but doing so has some advantages:

- They are used inconsistently, which is confusing.
- We can then also remove the (currently broken) hack/update-vanity-imports.sh.
- Last but not least, it would be a first step towards avoiding the k8s.io domain.

This commit was generated with
   sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/')

Everything was included, except for
   package labels // import k8s.io/kubernetes/pkg/util/labels
because that package is marked as "read-only".
2024-12-02 16:59:34 +01:00
Yuki Iwai
5dda60ee4e Job: Add evaluation step comments in the syncJob
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-11-07 23:36:44 +09:00
Alay Patel
3e3276e9fe Promote PodIndexLabel for Statefulset and IndexedJob stable (#128387)
* lock feature gate for PodIndexLabel and mark it GA

Signed-off-by: Alay Patel <alayp@nvidia.com>

* add emulated version if testing disabling of PodIndexLabel FG

Signed-off-by: Alay Patel <alayp@nvidia.com>

---------

Signed-off-by: Alay Patel <alayp@nvidia.com>
2024-11-04 19:11:28 +00:00
Kubernetes Prow Robot
d001d5684e Merge pull request #128417 from tenzen-y/self-nominate-job-controller-reviewer
Self nominate tenzen-y as a reviewer for the Job controller
2024-10-30 11:21:39 +00:00
Kubernetes Prow Robot
a18b50e7e4 Merge pull request #128373 from mimowo/job-cover-negative-codes
Job Pod Failure policy - cover testing of negative exit codes
2024-10-30 11:21:31 +00:00
Yuki Iwai
eca7ee877a Self nominate tenzen-y as a reviewer for the Job controller
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-10-30 01:14:47 +09:00
Kubernetes Prow Robot
5f594f4215 Merge pull request #128401 from tenzen-y/use-same-receiver-name
Job: Consistentely use the same reveiver name in the controller
2024-10-29 08:16:55 +00:00
Yuki Iwai
d4959d8d29 Job: Consistentely use the same reveiver name in the controller
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-10-29 14:11:10 +09:00
Yuki Iwai
a23e7a42d3 Job: Refactor uncountedTerminatedPods to avoid casting everywhere
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-10-29 13:12:35 +09:00
Michal Wozniak
cad648035a Job Pod Failure policy - cover testing of negative exit codes 2024-10-28 07:24:26 +01:00
Aldo Culquicondor
5fab6175b7 Remove alculquicondor from job approvers
Change-Id: I2b1514ff70108602a589522cbb63dcdc88849313
2024-10-23 17:58:55 +00:00
Michal Wozniak
70a8ceb6f0 Graduate JobManagedBy to Beta in 1.32
# Conflicts:
#	pkg/features/kube_features.go
2024-10-17 09:01:54 +02:00
Harish Kuna
0615ded5f7 keep delete handler and update handler consistent for finished jobs and offload mainqueue 2024-09-20 13:28:27 +00:00
Harish Kuna
77a3de3cfb Improve performance of Job controller delete event handler 2024-09-18 15:59:53 +00:00
Kubernetes Prow Robot
ed92309dfa Merge pull request #127253 from alculquicondor/mimowo_job
Nominate mimowo to approvers of job controller
2024-09-12 17:09:13 +01:00
Kubernetes Prow Robot
7bd36b50b4 Merge pull request #127258 from KPostOffice/testing-logger4job
Use logger context in job controller tests
2024-09-11 23:21:31 +01:00
Kevin
234c055205 Use logger context in job controller tests
Signed-off-by: Kevin <kpostlet@redhat.com>
2024-09-11 15:47:12 -04:00
Harish K
d66c9ef286 Update pkg/controller/job/job_controller.go
Co-authored-by: Aldo Culquicondor <1299064+alculquicondor@users.noreply.github.com>
2024-09-10 10:18:53 -07:00
Harish Kuna
e45eef1d51 Increase Job Controller Performance 2024-09-09 21:12:31 +00:00
Aldo Culquicondor
637be82479 Add mimowo to approvers of job controller and its integration tests
Change-Id: Ie834aff7070685757c55b7fbcea3bcdef223f6b8
2024-09-09 20:12:02 +00:00
Joe Betz
2595aa1309 generate 2024-09-03 14:26:26 -04:00
古九
a1f0fc8f72 support the job controller handles the orphan pod using multi workers 2024-08-19 14:03:27 +08:00
Yuki Iwai
551931c6a8 Graduate the JobSuccessPolicy to beta
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-23 09:29:06 +09:00
Yuki Iwai
6e8dc2c250 Job: Extend the jobs_finished_total metric reason label with SuccessPolicy and CompletionsReached
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-23 09:29:02 +09:00
Yuki Iwai
594490fd77 Job: Add the CompletionsReached reason to the SuccessCriteriaMet condition
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-22 21:24:52 +09:00
googs1025
6626b9ce28 chore(Job): remove deprecated fake.NewSimpleClientset method 2024-07-19 23:46:29 +08:00
googs1025
75a4cfbd58 chore(Job): use ctx.Done() instead of stopCh 2024-07-19 23:43:36 +08:00
googs1025
af5b8bed70 chore(Job): use WaitForCacheSync method after sharedInformerFactory Start 2024-07-19 23:41:20 +08:00
Michal Wozniak
1be4df6e02 Cleanup Job controller isPodFailed function 2024-07-18 09:08:23 +02:00
carlory
dae05f3b88 cleanup after JobPodFailurePolicy is promoted to GA 2024-07-18 10:00:56 +08:00
Kubernetes Prow Robot
5d40866fae Merge pull request #125994 from carlory/fix-job-api
clean up codes after PodDisruptionConditions was promoted to GA
2024-07-17 14:37:09 -07:00
Michal Wozniak
370631eb30 Update the set of reasons in comment for JobFinishedNum metric 2024-07-16 12:34:29 +02:00
Michal Wozniak
f1233ac5e0 JobPodFailurePolicy to GA
# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-12 17:21:32 +02:00
Michal Wozniak
fb7704ba03 Delay setting terminal Job conditions until all pods are terminal
Fix the integration test typecheck

Fix after rebase

# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-11 20:54:09 +02:00
Tomas Tormo
5a046a4fd9 job_controller: Add test for SuccessCriteriaMet=False 2024-07-11 12:08:43 +00:00
carlory
850bc09e9b clean up codes after PodDisruptionConditions was promoted to GA and locked to default 2024-07-11 10:40:21 +08:00
Kubernetes Prow Robot
135f2e0372 Merge pull request #125997 from mimowo/job-comment-cleanup
Cleanup TODO comment in the Job controller
2024-07-10 12:15:39 -07:00
Michal Wozniak
8a8717c3a9 Cleanup TODO comment in the Job controller 2024-07-10 12:27:56 +02:00
Tomas Tormo
2aed11ec78 job_controller: Ignore FailureTarget!=True 2024-07-10 08:02:14 +00:00
Kubernetes Prow Robot
4a214f6ad9 Merge pull request #125461 from mimowo/pod-disruption-conditions-ga
Graduate PodDisruptionConditions to stable
2024-07-09 11:08:13 -07:00
Michal Wozniak
4250d444f8 Cleanup Job controller tests 2024-07-05 14:59:03 +02:00
Stephen Kitt
f55b59fc02 pkg/controller: drop pointer wrapper functions
The new k8s.io/utils/ptr package provides generic wrapper functions,
which can be used instead of type-specific pointer wrapper functions.
This replaces the latter with the former, and migrates other uses of
the deprecated pointer package to ptr in affected files.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2024-07-02 16:19:12 +02:00
Michal Wozniak
780191bea6 review remarks for graduating PodDisruptionConditions 2024-06-28 17:32:27 +02:00
Michal Wozniak
bf0c9885a4 Graduate PodDisruptionConditions to stable 2024-06-28 16:36:51 +02:00
Michal Wozniak
7b5d3f5bc1 Assert on all conditions in the Pod Failure policy tests 2024-06-21 15:42:14 +02:00