Commit Graph

3428 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
4033355d29 Merge pull request #107909 from sebastiansterk/master
🤓 simple grammar fix
2022-02-15 12:15:18 -08:00
Kubernetes Prow Robot
1659924a97 Merge pull request #108070 from jsafrane/remove-selinux
Remove util/selinux package
2022-02-11 18:19:47 -08:00
Kubernetes Prow Robot
1f041ccd54 Merge pull request #107887 from bertinatto/fix-panic-kubelet
Fix panic in Kubelet
2022-02-11 12:58:07 -08:00
Jan Safranek
77aa06d0c8 Remove util/selinux package
The package says:

> the libcontainer SELinux package is only built for Linux, so it is
> necessary to have a NOP wrapper which is built for non-Linux platforms

This is not true, Kubernetes now imports
github.com/opencontainers/selinux/go-selinux and it has proper
multiplatform support (i.e. NOOP on non-Linux platforms).

Removing the whole package and calling go-selinux directly.
2022-02-11 15:20:35 +01:00
Cheng Xing
b152fa9b6c Remove verult from OWNERS files 2022-02-10 18:25:38 -08:00
Kubernetes Prow Robot
6a5b3da1d8 Merge pull request #107236 from cyclinder/fix_bug_WaitForAttach
GCEPD: fix incorrect return value in WaitForAttach
2022-02-08 09:59:02 -08:00
Hemant Kumar
4b589dfd7a fix flake in detach tests 2022-02-02 17:28:13 -05:00
Sebastian Sterk
8e9ea7b481 simple grammar fix 2022-02-02 00:04:35 +01:00
Fabio Bertinatto
eb2adaa32f Fix panic in Kubelet
Currently, the Kubelet panics when it's started with the
`enable-controller-attach-detach=false` option set and a
volume is attached to a node.

This patch adds a check that prevents the Kubelet from trying to attach
or detach CSI volumes and report a proper error warning the user that this
use case is not supported.
2022-01-31 17:29:25 -03:00
Hemant Kumar
ff765210d5 Mark device as uncertain if unmount device succeeds
If unmount device succeeds but somehow unmount operation
fails because device was in-use elsewhere, we should mark the
device mount as uncertain because we can't use the global
mount point at this point.
2022-01-26 07:49:49 -05:00
Monokaix
96702a89b2 replace filepath.Walk with filepath.WalkDir in doCleanSubPaths 2022-01-25 09:56:32 +08:00
Kubernetes Prow Robot
c175418281 Merge pull request #107065 from saikat-royc/fix-node-stage-path
change node staging path for csi driver to PV agnostic
2022-01-21 01:31:58 -08:00
Saikat Roychowdhury
80e0501e89 change staging path for csi driver to pv agnostic 2022-01-20 22:59:29 +00:00
Kubernetes Prow Robot
874ce66d19 Merge pull request #107279 from NikhilSharmaWe/pathCheck
added devicePath check for fcDisk
2022-01-18 03:05:08 -08:00
Kubernetes Prow Robot
3bd422dc76 Merge pull request #107293 from dims/jan-1-owners-cleanup
Cleanup OWNERS files - Jan 2021 Week 1
2022-01-13 10:30:30 -08:00
Kubernetes Prow Robot
42436c877e Merge pull request #107462 from dims/next-step-in-csi-migration-for-openstack-take-2
Next step in CSI migration for openstack
2022-01-12 19:57:07 -08:00
Kubernetes Prow Robot
e22ec17057 Merge pull request #99441 from CKchen0726/csi-client
migrate volume/csi/csi-client.go logs to structured logging
2022-01-12 11:52:13 -08:00
Patrick Ohly
9eaa2dc554 avoid klog Info calls without verbosity
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
Davanum Srinivas
7fd97433f0 Next step in CSI migration for openstack
delete/modify tests that use intree cinder as well.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 22:07:44 -05:00
Davanum Srinivas
9682b7248f OWNERS cleanup - Jan 2021 Week 1
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 08:14:29 -05:00
Kubernetes Prow Robot
475644ccd8 Merge pull request #106073 from ping035627/k8s-21110202
Cleanup FindPluginByName() in VolumePluginMgr
2022-01-07 07:52:29 -08:00
Nikhil Sharma
4eaa533777 added devicePath check for fcDisk 2022-01-07 20:10:03 +05:30
Kubernetes Prow Robot
d1a5513cb0 Merge pull request #107006 from gnufied/add-total-mount-time-metrics
Add metric for reporting total end-to-end mount time
2022-01-07 06:19:31 -08:00
Hemant Kumar
c9177f3083 rename volume_mount to overall_volume_mount for total metric time 2022-01-06 12:51:05 -05:00
Kubernetes Prow Robot
31898fc504 Merge pull request #101856 from prateekpandey14/fix-staticcheck
fix static check of importing the same package multiple times
2022-01-05 14:55:47 -08:00
Kubernetes Prow Robot
4f35d80f4e Merge pull request #107302 from pacoxu/fix/empty-dir-quota-monitoring
assignQuota checks if the underlying medium supports quotas and if so setting it
2022-01-05 09:23:18 -08:00
Kubernetes Prow Robot
0f5e3d14bd Merge pull request #106421 from houjun41544/20211115-volume
Fix the wrong log
2022-01-04 23:03:05 -08:00
PingWang
075adb308d Cleanup FindPluginByName() in VolumePluginMgr
Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update typo

Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update import

Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2022-01-05 11:42:26 +08:00
Paco Xu
3946e6c8c2 assignQuota checks if the underlying medium supports quotas and if so, sets 2022-01-05 09:33:07 +08:00
cyclinder
3ff8a86f20 GCEPD: fix incorrect return value in WaitForAttach
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
2021-12-28 09:48:35 +08:00
Kubernetes Prow Robot
f0dbc32ed9 Merge pull request #106853 from gnufied/disable-exp-backoff-volume-not-inuse
When volume is not marked in-use, do not backoff
2021-12-22 19:46:37 -08:00
Hemant Kumar
7989f27044 use node informer to check volumes attachment status before backoff
fix unit tests
2021-12-20 11:57:05 -05:00
Kubernetes Prow Robot
489fb9bee3 Merge pull request #107025 from jsafrane/remove-attach-match
Remove AttachID matching from Detach
2021-12-17 18:41:24 -08:00
Kubernetes Prow Robot
1426587e08 Merge pull request #106436 from dims/cleanup-owners-files-no-activity-in-a-year
Cleanup OWNERS files (No Activity in the last year)
2021-12-15 12:07:51 -08:00
Kubernetes Prow Robot
66931c9b8f Merge pull request #106703 from scottnice/patch-1
Fixed skipping valid volume plugins when another plugin has an error
2021-12-15 09:53:50 -08:00
Davanum Srinivas
497e9c1971 Cleanup OWNERS files (No Activity in the last year)
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-15 10:34:02 -05:00
Scott Nice
d9cbe5d314 Added unit test for flex volume probe and updated DynamicPluginProber Probe() interface description 2021-12-14 10:48:51 -05:00
Jan Safranek
516633d67f Remove AttachID matching from Detach
Detach() always gets CSI volume unique ID and never attachment ID. Related
code has been removed from Kubernetes in
129f15328b.
2021-12-14 15:37:17 +01:00
prateekpandey14
f9cf14f3f6 fix static check of importing the same package multiple times
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
2021-12-14 11:06:44 +05:30
Hemant Kumar
55b5e6dc33 Add metric for reporting total end-to-end mount time
This metric includes time spent in waiting for devices to be attached,
any RPC calls and performing recursive chown etc.
2021-12-13 16:23:01 -05:00
Davanum Srinivas
9405e9b55e Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Scott Nice
5183513661 Fix gofmt verify 2021-12-09 09:18:22 -05:00
Kubernetes Prow Robot
8174b0923c Merge pull request #105127 from astraw99/fix-dup-kubeClient
Fix duplicate CSI kube client
2021-12-07 17:25:30 -08:00
Hemant Kumar
5b7b2e2f6c When volume is not marked in-use, do not backoff 2021-12-07 11:50:15 -05:00
Scott Nice
1070eb7428 Fixed issue in plugin.go for bug #106696
Fixed issue in plugin.go where valid plugin events would be skipped if any plugin had an error. This meant that valid plugins would never be installed if another was in an error state as the events fired only once.
2021-11-27 15:07:19 -05:00
Hanna Lee
07a883d8e6 Remove //lint:ignore pragmas that aren't being used anymore 2021-11-17 08:56:54 +01:00
Hanna Lee
c8fde197f5 Add more //nolint:staticcheck for failures caught in PR tests 2021-11-17 08:56:02 +01:00
Kubernetes Prow Robot
8d9e424f73 Merge pull request #103447 from trierra/csi-translation-portworx
Csi translation portworx
2021-11-16 17:43:53 -08:00
houjun
7458399f77 Fix the wrong log 2021-11-17 09:07:07 +08:00
Oksana Naumov
3af11fc12d Add support for Portworx to csi-translation lib
Signed-off-by: Oksana Naumov <trierra.dev@gmail.com>
2021-11-16 13:26:09 -08:00