Charlie Drage
13cecd6e4a
Warn when missing cloud-provider on kube controller
...
This commit warns the user / gives better information that when using
--cloud-provider="" on kube-controller, that services such as
LoadBalancer will not work.
However, despite the error, kube-controller will still run as normal.
Fixes https://github.com/kubernetes/kubernetes/issues/12716
Fixes https://github.com/kubernetes/kubernetes/issues/11172
Fixes https://github.com/kubernetes/kubernetes/issues/27085
2016-07-14 11:54:35 -04:00
gmarek
f6b1c316e9
Allow switching rate limiter inside RateLimitedQueue
2016-07-14 15:38:14 +02:00
k8s-merge-robot
ae990defcf
Merge pull request #26956 from joe2far/fix-typos
...
Automatic merge from submit-queue
Fixed several typos
2016-07-14 04:13:15 -07:00
Maciej Szulik
fd76f71fd5
Fix issue with closing channels in job controller tests
2016-07-14 12:09:12 +02:00
k8s-merge-robot
6b6141f812
Merge pull request #28820 from caesarxuchao/patch-subresource
...
Automatic merge from submit-queue
[client-gen] Allow passing subresources in Patch method
Expand the Patch() method from:
```
Patch(name string, pt api.PatchType, data []byte)
```
to
```
Patch(name string, pt api.PatchType, data []byte, subresources ...string)
```
Continue on #27293 . Fixes #26580 .
cc @Random-Liu @lavalamp
2016-07-13 16:09:01 -07:00
joe2far
5ead89b5bb
Fixed several typos
2016-07-13 15:06:24 +01:00
Łukasz Oleś
528bf7af3a
Make Daemonset use GeneralPredicates
...
fixes #21454 , fixes #22205
2016-07-13 14:50:29 +02:00
gmarek
5677a9845e
Split NodeController rate limiters between zones
2016-07-13 14:09:19 +02:00
k8s-merge-robot
23f0edb8b0
Merge pull request #27713 from kargakis/wait-for-synced-rs-in-recreate
...
Automatic merge from submit-queue
controller: wait for synced old replica sets on Recreate
Partially fixes https://github.com/kubernetes/kubernetes/issues/27362
Any other work on it should be handled in the replica set level (and/or kubelet if it's required)
@kubernetes/deployment PTAL
2016-07-12 20:30:12 -07:00
k8s-merge-robot
f2303edc36
Merge pull request #28751 from Random-Liu/use-patch-to-set-node-condition
...
Automatic merge from submit-queue
Change route controller to use patch to set node condition.
Change the route controller to use `PatchStatus` function in `NodeExpansion` to update node condition.
@caesarxuchao
/cc @wojtek-t
[]()
2016-07-12 16:03:35 -07:00
k8s-merge-robot
d90cc907c4
Merge pull request #27438 from gmarek/controllerDeletion
...
Automatic merge from submit-queue
Controllers doesn't take any actions when being deleted.
I started doing it for other controllers but it's not always clear to me how it should work. I'll be adding other ones as separate commits to this PR.
cc @caesarxuchao @lavalamp
2016-07-12 12:37:09 -07:00
Chao Xu
dc2e12d2f8
manual changes to patch subresource
2016-07-12 11:09:27 -07:00
Random-Liu
59ea5c088b
Change route controller to use patch to set node condition.
2016-07-12 10:30:33 -07:00
k8s-merge-robot
5894dc4615
Merge pull request #28829 from gmarek/hooks
...
Automatic merge from submit-queue
Add hooks for cluster health detection
Separate a function that decides if zone is healthy. First real commit for preventing massive pod eviction.
Ref. #28832
cc @davidopp
2016-07-12 08:12:04 -07:00
k8s-merge-robot
98030ded05
Merge pull request #28781 from wojtek-t/optimize_priorities_2
...
Automatic merge from submit-queue
Change storeToNodeConditionLister to return []*api.Node instead of api.NodeList for performance
Currently copies that are made while copying/creating api.NodeList are significant part of scheduler profile, and a bunch of them are made in places, that are not-parallelizable.
Ref #28590
2016-07-12 06:18:15 -07:00
gmarek
fd600ab65c
Add hooks for cluster health detection
2016-07-12 15:10:58 +02:00
k8s-merge-robot
ea70eca37b
Merge pull request #28770 from gmarek/coupling
...
Automatic merge from submit-queue
Reduce tightness of coupling in NodeController
Depends on #28604
2016-07-12 05:42:59 -07:00
k8s-merge-robot
2125c0eb62
Merge pull request #28811 from xiang90/pv
...
Automatic merge from submit-queue
controller/volume: simplify sync logic in syncUnboundClaim
Remove all unnecessary branching logic. No actual logic changes. Code is more readable now.
2016-07-12 02:28:05 -07:00
gmarek
7524da877e
Reduce tightness of coupling in NodeController
2016-07-12 11:00:41 +02:00
gmarek
95de5a38ea
JobController doesn't take any actions when being deleted.
2016-07-12 09:43:08 +02:00
gmarek
7815a3e7bc
DeploymentController doesn't take any actions when being deleted
2016-07-12 09:43:08 +02:00
gmarek
d8958257c4
DaemonController doesn't take any actions when being deleted.
2016-07-12 09:43:08 +02:00
gmarek
7f5f9d3a6f
Move CIDR allocation logic away from nodecontroller.go
2016-07-12 09:40:43 +02:00
Xiang Li
67787caeeb
controller/volume: simplify sync logic in syncBoundClaim
2016-07-11 19:36:36 -07:00
Xiang Li
9eb2831954
controller/volume: simplify sync logic in syncUnboundClaim
2016-07-11 19:22:14 -07:00
k8s-merge-robot
7b067c859f
Merge pull request #26387 from MHBauer/cleanupjitter
...
Automatic merge from submit-queue
close channel to prevent buildup of wait.JitterUntil()
<!--
Checklist for submitting a Pull Request
Please remove this comment block before submitting.
1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md ).
2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md ).
3. If you want this PR to automatically close an issue when it is merged,
add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>`
to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests ).
4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes ) in the block below.
-->
Trying to look at flake in #26377 by running the test with large counts of runs. It was timing out because a `wait.JitterUntil` goroutine builds up for each of the four tests. So if you ran it a thousand times, you would end up with 4k goroutines spinning in the background. Now I create a channel and close it at the end of each test to prevent a memory leak.
2016-07-11 18:53:39 -07:00
Wojciech Tyczynski
d14fe0f269
Change storeToNodeConditionLister to return []*api.Node instead of api.NodeList for performance
2016-07-11 21:02:33 +02:00
Jan Safranek
71b75d593e
Stabilize volume unit tests by waiting for exact state
...
Wait for specific final state instead of waiting for specific number of
operations in volume unit tests. The tests are more readable and will survive
random goroutine ordering (PV and PVC controller have both their own
goroutine).
2016-07-11 15:35:01 +02:00
k8s-merge-robot
39bfa168cd
Merge pull request #28684 from kargakis/deployment-controller-updates
...
Automatic merge from submit-queue
Deployment controller updates
@kubernetes/deployment @deads2k PTAL
2016-07-11 02:56:47 -07:00
Xiang Li
63f88b4800
controller/podautoscaler: minor cleanup
2016-07-10 23:42:51 -07:00
Xiang Li
67f670df2e
controller/service: minor cleanup
2016-07-10 23:13:25 -07:00
k8s-merge-robot
c12de567cd
Merge pull request #26931 from xiang90/fix_daemon
...
Automatic merge from submit-queue
daemon/controller.go: fix bugs in updateDaemonSetStatus
[]()
1. return when there is any error
2. fix StatusUpdateRetries loop
3. a few minor cleanup
2016-07-09 15:31:48 -07:00
k8s-merge-robot
9a4cc9979a
Merge pull request #28504 from deads2k/allow-quota-injection
...
Automatic merge from submit-queue
allow lock acquisition injection for quota admission
Allows for custom lock acquisition when composing the quota admission controller.
@derekwaynecarr I'm still experimenting to make sure this satisfies the need downstream, but looking for agreement in principle
2016-07-08 17:15:39 -07:00
Chao Xu
7a5b3c43a0
plumb --enable_garbage_collector from environment variable;
...
adding a simple e2e test
2016-07-08 10:27:16 -07:00
Michail Kargakis
1fb8dd838b
controller: various fixes for the deployment controller
...
Changes:
* moved waiting for synced caches before starting any work
* refactored worker() to really quit on quit
* changed queue to a ratelimiting queue and added retries on errors
* deep-copy deployments before mutating - we still need to deep-copy
replica sets and pods
2016-07-08 17:30:40 +02:00
k8s-merge-robot
913d785b39
Merge pull request #28597 from soltysh/pending_pods
...
Automatic merge from submit-queue
Added test case covering pending pods in syncJob
@randalloveson suggested in #27997 we might not take pending pods into considerations, while checking that I wrote additional test case for `syncJob`.
@randalloveson @erictune ptal
[]()
2016-07-08 04:12:21 -07:00
Angus Salkeld
6a0577cfcc
Increase coverage in pkg/util/deployment
2016-07-08 12:35:23 +02:00
k8s-merge-robot
e7b92b9d0a
Merge pull request #28161 from asalkeld/util_deployment
...
Automatic merge from submit-queue
Move deployment functions to deployment/util.go not widely used
If the function is not used in multiple areas, move it to deployment/util.go
fixes #26750
2016-07-08 03:06:51 -07:00
k8s-merge-robot
383d45f185
Merge pull request #28596 from wojtek-t/scheduler_optimizations
...
Automatic merge from submit-queue
Some scheduler optimizations
Ref #28590
This PR doesn't do anything fancy - it is just reducing amount of memory allocations in scheduler, which in turn significantly speeds up scheduler.
2016-07-08 02:34:06 -07:00
Angus Salkeld
eec08872c7
Move deployment utilities to there own package
2016-07-08 09:46:56 +02:00
deads2k
a094a33560
add union registry for quota
2016-07-07 15:04:41 -04:00
k8s-merge-robot
a1501fde66
Merge pull request #28550 from janetkuo/e2e-deployment-rollover-log
...
Automatic merge from submit-queue
Log available pods of deployments when scaling down old RS
Ref #26834
[]()
2016-07-07 07:33:30 -07:00
Maciej Szulik
79028c4e3b
Added test case covering pending pods in syncJob
2016-07-07 14:45:34 +02:00
Wojciech Tyczynski
7219802ac7
Pass pointer to node in NodCondition
2016-07-07 14:10:17 +02:00
k8s-merge-robot
0c696dc95b
Merge pull request #27848 from liubin/fix-typos
...
Automatic merge from submit-queue
fix some typos
Just a minor typos fix.
Signed-off-by: bin liu <liubin0329@gmail.com >
2016-07-06 23:36:49 -07:00
k8s-merge-robot
8135154f7f
Merge pull request #26868 from xiang90/rm_all
...
Automatic merge from submit-queue
daemon/controller.go: remove unused func enqueueAllDaemonSets
2016-07-06 23:36:45 -07:00
Janet Kuo
08305f12a2
Log available pods of deployments when scaling down old RS
2016-07-06 13:31:28 -07:00
Morgan Bauer
69719167a3
close channel to prevent memory leak
...
- wait.JitterUntil goroutine is never cleaned up when used with wait.NeverStop
- fixup comment
2016-07-06 09:34:20 -07:00
deads2k
ada37c2163
allow lock acquisition injection for quota admission
2016-07-06 09:39:42 -04:00
Xiang Li
8e4966da82
daemon/controller.go: fix bugs in updateDaemonSetStatus
...
1. return when there is any error
2. fix StatusUpdateRetries loop
3. a few minor cleanup
2016-07-05 12:34:15 -07:00
