Filip Křepinský
05bc270870
add tests for getReplicaSetFraction in the deployment controller ( #128535 )
...
* better name variables in deployment_util
* add tests for getReplicaSetFraction in the deployment controller
- make validation more robust and make sure we do not divide by 0
2024-11-04 19:11:43 +00:00
Kubernetes Prow Robot
cc319bf654
Merge pull request #128527 from atiratree/annotations-validation
...
improve validation for ReplicaSet annotations in the deployment controller
2024-11-04 13:07:28 +00:00
Filip Křepinský
3ac0ac7a81
improve validation for ReplicaSet annotations in the deployment controller
2024-11-04 10:43:16 +01:00
Filip Křepinský
a460e2c413
simplify ScalingReplicaSet event building in the deployment controller
2024-11-04 08:42:22 +01:00
Kubernetes Prow Robot
a1df68a31f
Merge pull request #125118 from jsoref/from-to
...
Order ScalingReplicaSet message from->to
2024-10-09 08:36:22 +01:00
Josh Soref
502c05ed01
chore: Order ScalingReplicaSet message from->to
...
* change format of event
* include `from 0` for new replicas
* update describe tests to reflect current output
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com >
2024-10-08 09:59:29 -04:00
Joe Betz
2595aa1309
generate
2024-09-03 14:26:26 -04:00
Alvaro Aleman
6d0ac8c561
Use the generic/typed workqueue throughout
...
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
2024-05-04 14:33:12 -04:00
Mengjiao Liu
b584b87a94
kube-controller-manager: readjust log verbosity
...
- Increase the global level for broadcaster's logging to 3 so that users can ignore event messages by lowering the logging level. It reduces information noise.
- Making sure the context is properly injected into the broadcaster, this will allow the -v flag value to be used also in that broadcaster, rather than the above global value.
- test: use cancellation from ktesting
- golangci-hints: checked error return value
2024-02-26 14:51:56 +08:00
weilaaa
eb8f3f194f
use build-in max and min func to instead of k8s.io/utils/integer funcs
2023-12-15 15:09:11 +08:00
Stephen Kitt
aa89e6dc97
Use ptr.To to retrieve intstr addresses
...
This uses the generic ptr.To in k8s.io/utils to replace functions and
code constructs which only serve to return pointers to intstr
values. Other uses of the deprecated pointer package are updated in
modified files.
Signed-off-by: Stephen Kitt <skitt@redhat.com >
2023-09-08 11:10:50 +02:00
DrAuYueng
a4ce32769f
fix pod delete log in deployment controller
...
Signed-off-by: DrAuYueng <ouyang1204@gmail.com >
2023-08-25 22:20:51 +08:00
git-jxj
a5b3a4b738
cleanup: Update deprecated FromInt to FromInt32 ( #119858 )
...
* redo commit
* apply suggestions from liggitt
* update Parse function based on suggestions
2023-08-16 09:33:01 -07:00
Ziqi Zhao
dfc1838379
Migrated pkg/controller/volume|util|replicaset|nodeipam to contextual logging
...
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com >
2023-07-06 07:39:52 +08:00
Stephen Kitt
5bfe738af2
apps: replace intstr.FromInt with intstr.FromInt32
...
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.
Signed-off-by: Stephen Kitt <skitt@redhat.com >
2023-05-01 09:17:05 +02:00
ZhangKe10140699
66bda6c092
deployment controller: use contextual logging
2023-03-13 19:00:44 +08:00
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc
2022-12-17 23:27:38 -05:00
ZhangYu
d61849e800
pkg/controller/deployment/util/deployment_util.go:Improving test coverage
2022-11-22 10:12:58 +08:00
Kubernetes Prow Robot
28ced69b76
Merge pull request #113054 from logicalhan/proxy-metric
...
remove rate limiter metric as it is not in use
2022-10-17 11:09:18 -07:00
Kubernetes Prow Robot
5c36a3c372
Merge pull request #110902 from 0xff-dev/master
...
convert int32 to pointer using library function
2022-10-14 08:48:46 -07:00
Han Kang
2bbd445f50
remove rate limiter metric as it is not in use
...
Change-Id: I91157653e3860eeecc3f572aee88da6ffc65faed
2022-10-13 13:07:11 -07:00
Davanum Srinivas
a9593d634c
Generate and format files
...
- Run hack/update-codegen.sh
- Run hack/update-generated-device-plugin.sh
- Run hack/update-generated-protobuf.sh
- Run hack/update-generated-runtime.sh
- Run hack/update-generated-swagger-docs.sh
- Run hack/update-openapi-spec.sh
- Run hack/update-gofmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com >
2022-07-26 13:14:05 -04:00
0xff-dev
0a77a9122f
convert int32 to pointer using library function
2022-07-01 14:58:26 +08:00
Wojciech Tyczyński
11b679c66a
Fix event broadcaster shutdown in multiple controllers
2022-05-17 22:14:19 +02:00
Tom Kerkhove
77efbc411a
feat: Provide previous replica count for deployment/replica set scale up/down event ( #101142 )
...
* feat: Provide previous replica count for deployment/replica set scale up/down event
Signed-off-by: GitHub <noreply@github.com >
* change format of event
Co-authored-by: Maciej Szulik <soltysh@gmail.com >
Co-authored-by: Maciej Szulik <soltysh@gmail.com >
2022-05-03 17:16:59 -07:00
SataQiu
9ac1b4b68f
remove unused option deployment-controller-sync-period for deployment controller
2022-03-30 20:00:53 +08:00
Jordan Liggitt
c0af728f43
Handle invalid selectors properly
2022-01-14 12:11:02 -05:00
Davanum Srinivas
9682b7248f
OWNERS cleanup - Jan 2021 Week 1
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com >
2022-01-10 08:14:29 -05:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com >
2021-12-09 21:31:26 -05:00
Kubernetes Prow Robot
f27e4714ba
Merge pull request #105377 from damemi/wire-contexts-apps
...
Wire contexts to Apps controllers
2021-10-14 06:59:19 -07:00
Mike Dame
41fcb95f2f
Wire contexts to Apps controllers
2021-10-13 16:32:13 -04:00
Maciej Szulik
8322121434
Move test-related utils to test/utils
2021-10-12 14:52:19 +02:00
Stephen Augustus
481cf6fbe7
generated: Run hack/update-gofmt.sh
...
Signed-off-by: Stephen Augustus <foo@auggie.dev >
2021-08-24 15:47:49 -04:00
Sergey Kanzhelev
4b05fe6644
podUnknown is marked as Obsolete
2021-04-06 22:43:08 +00:00
Kubernetes Prow Robot
3ce93161fe
Merge pull request #97507 from aldudko/controller-logging
...
Migrate deployment controller log messages to structured logging
2021-03-03 22:49:59 -08:00
Benjamin Elder
56e092e382
hack/update-bazel.sh
2021-02-28 15:17:29 -08:00
Alex Dudko
dcdde707ab
Migrate deployment controller log messages to structured logging
2021-02-14 11:09:52 -08:00
Kubernetes Prow Robot
73fbd3da09
Merge pull request #97407 from waynepeking348/clean_rs_by_revision_instead_of_creat_timestamp
...
clean rs by revision instead of creation timestamp in deployment controller
2021-01-21 20:15:27 -08:00
waynepeking348
b2de3507d0
add dependency in bazel BUILD file
2021-01-16 22:25:37 +08:00
waynepeking348
c8f9858920
add unit test cases
2020-12-20 17:05:48 +08:00
waynepeking348
ab1be93809
clean rs by revision instead of creat timestamp
2020-12-20 17:05:42 +08:00
waynepeking348
6c36a48550
fix bugs when copying deployment annotations to replicaSet if value is empty
2020-12-20 13:46:26 +08:00
Kubernetes Prow Robot
1a66eb7b8a
Merge pull request #89482 from renatoviana12/master
...
fixed percentage behaviour in instr
2020-10-05 20:00:19 -07:00
Renato Viana
316eff8dee
Fixed percentage behavior in instr
...
fixed syntax, wrote a test
fixed a test
.
1
Update staging/src/k8s.io/apimachinery/pkg/util/intstr/intstr_test.go
Co-Authored-By: Joel Speed <Joel.speed@hotmail.co.uk >
added test
.
fix
fix test
fixed a test
gofmt
lint
fix
function name
validation fix
.
godocs added
.
2020-09-30 21:23:05 +01:00
Kubernetes Prow Robot
983265aeaa
Merge pull request #94739 from knight42/fix/TestExpectationsOnRecreate
...
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
2020-09-15 11:18:07 -07:00
knight42
e89e72b637
test: ensure WaitForCacheSync is called after starting sharedInformerFacotry
...
Signed-off-by: knight42 <anonymousknight96@gmail.com >
2020-09-15 16:02:35 +08:00
David Eads
c0c033b12f
generated
2020-09-14 09:24:41 -04:00
David Eads
c7911a384c
remove pod presets
2020-09-14 09:24:40 -04:00
wawa0210
7d8aae51df
fix pkg/controller/deployment staticcheck
2020-06-23 19:32:20 +08:00
Kobayashi Daisuke
4ae11dac2e
Replace StartLogging(klog.Infof) with StartStructuredLogging(0)
2020-06-15 17:48:35 +09:00