Jan Safranek
8791efc732
Update property name in metrics
...
selinux_volume_conflict should not have space in its label value - it's
harder to query for that value. Use SELinuxLabel as both human friendly (in
an event) and label value.
2024-11-06 11:16:06 +01:00
Jan Safranek
cf7a2c7d35
Add a comment why PVC indexer is used
2024-11-06 11:16:06 +01:00
Jan Safranek
3ff3ed4b6d
Add comment how GetPodsForCSIDriver is useful
2024-11-06 11:16:06 +01:00
Jan Safranek
6eab8a8691
Use RWLock for the controller cache
...
It could help a tiny bit with parallel operations.
2024-11-06 11:16:06 +01:00
Jan Safranek
e6807a8e4f
Use _ for unused parameters
...
Sometimes the logger is not used. This fixes some linter warnings.
2024-11-06 11:16:06 +01:00
Jan Safranek
dfb88095b0
Rename label to seLinuxLabel
...
In various parameters, variables and fields. To make the name more
obvious.
2024-11-06 11:16:06 +01:00
Jan Safranek
e438bc0561
Rework event recorder startup
...
* Remove Controller.recorder field, there already is eventRecorder.
* Start the event broadcaster in Run(), to save a bit of CPU and memory
when something initializes the controller, but does not Run() it.
* Log events with log level 3, as the other contollers usually do.
* Use StartStructuredLogging(), which looks fancier than StartLogging
2024-11-06 11:16:06 +01:00
Jan Safranek
da2d9fa16e
Fix golint errors
...
Revealed by the new SELinux warning controller, but not related to it.
2024-11-06 11:16:05 +01:00
Jan Safranek
aa8872d7a3
Add SELinux warning controller
2024-11-06 11:16:02 +01:00
Jan Safranek
0d71dc677e
Refactor CreateVolumeSpec
...
Rename old CreateVolumeSpec to CreateVolumeSpecWithNodeMigration that
extracts volume.Spec with node specific CSI migration.
Add CreateVolumeSpec that does the same, only without evaluating node CSI
migration.
2024-11-06 11:15:31 +01:00
Kubernetes Prow Robot
08391b3d27
Merge pull request #123549 from carlory/kep-3751-finalizer
...
A new controller adds/removes finalizer to VAC for protection
2024-11-05 21:45:30 +00:00
Kubernetes Prow Robot
3e66160f30
Merge pull request #107362 from shawnhanx/controller_redundant
...
remove redundant return statement in attachdetach/util/util.go
2024-10-23 01:16:53 +01:00
carlory
4c10212d7b
Fix data race in kubelet/volumemanager
2024-10-08 16:39:02 +08:00
Eric Blake
fe5b74b1f8
docs: typo fix in VolumeAttachments
...
Fix typo and grammar in comments that get reflected through to the
generated documentation, regarding VolumeAttachments' use of
PersistentVolumes and PersistentVolumeClaims.
Signed-off-by: Eric Blake <eblake@redhat.com >
2024-09-30 08:37:10 -05:00
Abhishek Kr Srivastav
95860cff1c
Fix Go vet errors for master golang
...
Co-authored-by: Rajalakshmi-Girish <rajalakshmi.girish1@ibm.com >
Co-authored-by: Abhishek Kr Srivastav <Abhishek.kr.srivastav@ibm.com >
2024-09-20 12:36:38 +05:30
Joe Betz
2595aa1309
generate
2024-09-03 14:26:26 -04:00
carlory
a9de9a3d07
controller-manager adds a new controller named volumeattributesclass-protection-controller which adds/removes finalizer to VAC for protection
2024-08-30 15:00:46 +08:00
Kubernetes Prow Robot
fd7642cfe4
Merge pull request #126745 from hungnguyen243/pvcScalabilityFix
...
Improve PVC protection controller's scalability by batch-processing PVCs by namespace & caching live pod list results [fixed dead loop issue with idle work queue]
2024-08-27 19:16:57 +01:00
Hung Nguyen
152ab36a33
update error comment
2024-08-26 16:47:39 +00:00
Hung Nguyen
39b6bd1278
address pwschuurman's comments
2024-08-23 18:53:26 +00:00
Kubernetes Prow Robot
113b12c6fb
Merge pull request #124439 from bells17/csi-translation-lib-structured-and-contextual-logging
...
Migrate k8s.io/csi-translation-lib/.* to structured logging
2024-08-19 18:13:54 -07:00
Hung Nguyen
f9f8b789ca
fix spin loop issue with idle work queue
2024-08-16 18:17:47 +00:00
pwschuurman
dbcbdbf5fb
Revert "Improve PVC protection controller's scalability by batch-processing PVCs by namespace & caching live pod list results"
2024-08-15 16:33:11 -07:00
Kubernetes Prow Robot
9d140b136c
Merge pull request #125372 from hungnguyen243/pvcScalabilityFix
...
Improve PVC protection controller's scalability by batch-processing PVCs by namespace & caching live pod list results
2024-08-13 18:52:42 -07:00
Hung Nguyen
eb16aa1d4a
improve PVC Protection Controller's processing mechanism with sample performance test
2024-08-08 16:57:55 +00:00
Dr. Stefan Schimanski
c7a1fa432a
Call non-blocking informerFactory.Start synchronously to avoid races
...
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com >
2024-07-27 18:13:09 +02:00
carlory
c4851c64a0
remove volumeoptions from VolumePlugin and BlockVolumePlugin
2024-07-24 14:07:02 +08:00
Kubernetes Prow Robot
107f621462
Merge pull request #126108 from gnufied/changes-volume-recovery
...
Reduce state changes when expansion fails and mark certain failures as infeasible
2024-07-23 13:30:56 -07:00
Drew Sirenko
16c2ad5b84
Add labels to PVCollector bound/unbound PVC metrics for VolumeAttributesClass Feature ( #126166 )
...
* Add labels to PVCollector bound/unbound PVC metrics
* fixup! Add labels to PVCollector bound/unbound PVC metrics
* wip: Fix 'Unknown
Decorator'
* fixup! Add labels to PVCollector bound/unbound PVC metrics
2024-07-23 12:21:29 -07:00
Kubernetes Prow Robot
a00181d4d4
Merge pull request #121902 from carlory/kep-3751-pv-controller
...
[kep-3751] pvc bind pv with vac
2024-07-23 11:02:13 -07:00
carlory
3a6a4830df
pvc bind pv with vac
2024-07-23 15:04:11 +08:00
Kubernetes Prow Robot
1f436e0fba
Merge pull request #124108 from carlory/update-test-InTreePluginXXXUnregister
...
update unit test for adc to test volume migration
2024-07-22 06:49:49 -07:00
bells17
1298c8a5fe
csi-translation-lib: Support structured and contextual logging
2024-07-18 14:01:27 +09:00
Hemant Kumar
7a51999ddf
Deprecate intree Volume Expansion controller
2024-07-12 14:42:04 -04:00
carlory
cd2c8cb5fd
Fix pv reclaim failed due to its phase is wrongly updated to the Failed state by kcm
2024-06-28 01:25:45 +08:00
Kubernetes Prow Robot
aeed1d0e1a
Merge pull request #124842 from carlory/honor-pv-reclaim-policy-e2e
...
Promote HonorPVReclaimPolicy to beta and enable it by default
2024-06-19 13:26:41 -07:00
carlory
4058178b8c
Promote HonorPVReclaimPolicy to beta and enable it by default
2024-06-19 13:51:37 +08:00
carlory
214287b370
kube-controller-manager removed deprecated command flags: --volume-host-cidr-denylist and --volume-host-allow-local-loopback
2024-05-27 10:59:09 +08:00
carlory
9c92b37d4e
remove clusterName from VolumeOptions
2024-05-10 16:42:31 +08:00
carlory
4c1df69b34
update unit test for adc controller to test volume migration
2024-05-09 16:16:03 +08:00
Alvaro Aleman
6d0ac8c561
Use the generic/typed workqueue throughout
...
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
2024-05-04 14:33:12 -04:00
Kubernetes Prow Robot
dbb7004385
Merge pull request #121256 from liyuerich/workqueue
...
drop deprecated workqueue NewNamed package
2024-04-29 09:33:05 -07:00
Kubernetes Prow Robot
38c2a963b4
Merge pull request #123984 from carlory/volume-remove-cloud-provider
...
Remove cloud provider dependency from volume host and volume controllers
2024-04-28 02:54:14 -07:00
liyuerich
98dfaed4be
drop deprecated workqueue NewNamed package
...
Signed-off-by: liyuerich <yue.li@daocloud.io >
2024-04-28 14:04:51 +08:00
Marek Siarkowicz
3ee8178768
Cleanup defer from SetFeatureGateDuringTest function call
2024-04-24 20:25:29 +02:00
carlory
9ec6ee539a
Remove cloud provider dependency from volume host and volume controllers
2024-04-18 19:00:37 +08:00
Kubernetes Prow Robot
854af6aba6
Merge pull request #122411 from huww98/lift-mountedByNode
...
ad controller: lift nodeAttachedTo.mountedByNode
2024-04-18 00:00:14 -07:00
Kubernetes Prow Robot
ef2c682635
Merge pull request #122082 from carlory/remove-keep-terminated-pod-volumes
...
keep-terminated-pod-volumes flag on kubelet is removed
2024-04-17 23:59:54 -07:00
huweiwen
3a71fe57f7
ad controller: lift nodeAttachedTo.mountedByNode
...
optimize adc.nodeUpdate(). Time complexity reduced from O(n) to O(1), where n is the number of nodes.
Data stored in nodeAttachedTo.mountedByNode is now at actualStateOfWorld.inUseVolumes.
This refactor also ensures that we can record the state update even if the volume is not present in ASW yet.
The added BenchmarkNodeUpdate result is reduced from 28076923 to 16030 ns/op.
The previous BenchmarkPopulateActualStateOfWorld result is also reduced from 13s to 8s.
2024-04-11 15:35:17 +08:00
Kubernetes Prow Robot
611dbaa055
Merge pull request #122790 from carlory/fix-121696
...
Fix flaky test: Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce
2024-03-10 19:23:40 -07:00