Mark Rossetti
5eb37b073c
Fixing k8s.io/kubernetes/pkg/util/filesystem unit tests for Windows
...
Signed-off-by: Mark Rossetti <marosset@microsoft.com >
2025-02-27 13:50:24 -08:00
Mark Rossetti
b377dfba0c
Add funcs in pkg/filesystem/util that can actually set file permissiosn
...
on Windows and update container log dir perms to 660 on Windows
2024-07-15 14:22:59 -07:00
Kubernetes Prow Robot
7f67cb5960
Merge pull request #123969 from liangyuanpeng/cleanup_rand
...
cleanup: delete rand.Seed(time.Now().UnixNano()) and using global number generator.
2024-04-18 02:10:26 -07:00
Maksym Pavlenko
be4b7176dc
Fix Abs path validation on Windows ( #124084 )
...
* Windows: Consider slash-prefixed paths as absolute
filepath.IsAbs does not consider "/" or "\" as absolute paths, even
though files can be addressed as such. [1][2]
Currently, there are some unit tests that are failing on Windows due to
this reason.
[1] https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats#traditional-dos-paths
[2] https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths
* Add test to verify IsAbs for windows
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
* Fix abs path validation on windows
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
* Skipp path clean check for podLogDir on windows
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
* Implement IsPathClean to validate path
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
* Add warn comment for IsAbs
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
---------
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
Co-authored-by: Claudiu Belu <cbelu@cloudbasesolutions.com >
2024-04-10 10:13:59 -07:00
Lan Liang
dc992adad3
cleanup: delete rand.Seed(time.Now().UnixNano()) and using global number generator.
...
see https://tip.golang.org/doc/go1.20
Signed-off-by: Lan Liang <gcslyp@gmail.com >
2024-03-18 08:10:12 +00:00
Tim Hockin
6dbc754ed6
Retool typecheck to be simpler
...
Instead of walking paths ourselves, just let Go's packages library do
it. This is a slight CLI change - it wants "./foo" rather than "foo".
This also flagged a few things which seem to be legit failures.
2024-02-29 22:07:00 -08:00
Claudiu Belu
b4d1440063
unittests: Fixes hostutil.GetFileType for Windows
...
GetFileType is meant to return the type of the given file by using os.Stat.
However, os.Stat doesn't work on Windows for Unix Sockets, causing an error to occur:
[2-Socket Test] unexpected error :
CreateFile C:\Users\Administrator\AppData\Local\Temp\test-get-filetype-2776877299\mt.sock:
The file cannot be accessed by the system.
This is a known issue and we're already using a workaround for this in
pkg/kubelet/util/util_windows.go.
This commit fixes this issue for GetFileType on Windows.
2023-06-01 16:02:07 +00:00
