Commit Graph

425 Commits

Author SHA1 Message Date
Michal Wozniak
523ed5498e Fix comment for FailIndex as JobBackoffLimitPerIndex is beta 2025-02-10 09:17:18 +01:00
Patrick Ohly
8a908e0c0b remove import doc comments
The "// import <path>" comment has been superseded by Go modules.
We don't have to remove them, but doing so has some advantages:

- They are used inconsistently, which is confusing.
- We can then also remove the (currently broken) hack/update-vanity-imports.sh.
- Last but not least, it would be a first step towards avoiding the k8s.io domain.

This commit was generated with
   sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/')

Everything was included, except for
   package labels // import k8s.io/kubernetes/pkg/util/labels
because that package is marked as "read-only".
2024-12-02 16:59:34 +01:00
ndixita
85488b5f10 Generated files and compatability data from API changes 2024-11-08 03:00:50 +00:00
Tim Hockin
c8eeb486f4 Call-site comments: the "" arg to TooLong is unused 2024-11-05 15:10:24 -08:00
Tim Hockin
8a7af90300 Clarify that value arg to field.TooLong is unused 2024-11-05 15:10:23 -08:00
Tim Hockin
4d0e1c8fd4 Kill TooLongMaxLength() in favor of TooLong() 2024-11-05 15:10:22 -08:00
Michal Wozniak
cad648035a Job Pod Failure policy - cover testing of negative exit codes 2024-10-28 07:24:26 +01:00
Kubernetes Prow Robot
c9525d3865 Merge pull request #120629 from Rei1010/pointerClean
Use ptr.Equal to compare the value
2024-10-23 01:17:07 +01:00
Michal Wozniak
70a8ceb6f0 Graduate JobManagedBy to Beta in 1.32
# Conflicts:
#	pkg/features/kube_features.go
2024-10-17 09:01:54 +02:00
Stephen Kitt
ff3e9ea79f pkg/api(s): drop pointer wrapper functions
The new k8s.io/utils/ptr package provides generic wrapper functions,
which can be used instead of type-specific pointer wrapper functions.
This replaces the latter with the former, and migrates other uses of
the deprecated pointer package to ptr in affacted files.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
2024-09-23 23:00:34 +02:00
Joe Betz
2595aa1309 generate 2024-09-03 14:26:26 -04:00
Yuki Iwai
551931c6a8 Graduate the JobSuccessPolicy to beta
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-23 09:29:06 +09:00
Michal Wozniak
f1233ac5e0 JobPodFailurePolicy to GA
# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-12 17:21:32 +02:00
Michal Wozniak
70c4965270 Add more test cases for SuccessCriteriaMet
Cleanup error messages in the new code

Add validation for the Job controller fields
2024-07-12 11:22:26 +02:00
Michal Wozniak
fb7704ba03 Delay setting terminal Job conditions until all pods are terminal
Fix the integration test typecheck

Fix after rebase

# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-11 20:54:09 +02:00
Kubernetes Prow Robot
cdcaea687c Merge pull request #125751 from ahg-g/elastic-job
Graduate ElasticIndexedJob to GA
2024-07-11 11:08:24 -07:00
Michael Fraenkel
cd949bafa4 use MakePodSpec consistently (#125805)
cleaning up some tests after MakePod/MakePodSpec were introduced
2024-06-30 10:28:36 -07:00
Michael Fraenkel
a7264f95ff pod terminationGracePeriodSeconds is always valid (#124461)
* Pod terminationGracePeriodSeconds is always valid

Validation of a pod spec will always use the pod's
TerminationGracePeriodSeconds value.

A set of pod test-helpers have been created to help construct Pods.

* remove unused func

* reduction

* reduce 2

* simplify test

* report invalid grace period

* update SupplementalGroupPolicy tests
2024-06-29 18:09:29 -07:00
ahg-g
be410c0dae Graduate ElasticIndexedJob to GA 2024-06-28 17:00:29 +00:00
Tim Hockin
a074dd6f2e Use +default for now deprecated ScaleIO volume 2024-06-19 12:18:33 -07:00
Tim Hockin
0f5ab4beec Use +default for now deprecated AzureDisk volume 2024-06-19 11:59:52 -07:00
Tim Hockin
333c02cf28 Use +default for now deprecated ISCSI volume 2024-06-19 11:59:20 -07:00
Tim Hockin
03f0110b95 Use +default for now deprecated RBD volume
THis leaves us less hand-written code and a better schema.
2024-06-19 11:58:26 -07:00
Michal Wozniak
551464fe53 Improve the Job API comment for ready field 2024-05-29 14:01:28 +02:00
Michal Wozniak
a517b4dcdf Fix the comment for the Job managedBy field 2024-05-13 13:31:58 +02:00
wen.rui
af2a43f0ab Use ptr.Equal to compare the value 2024-05-08 09:21:22 +08:00
Marek Siarkowicz
3ee8178768 Cleanup defer from SetFeatureGateDuringTest function call 2024-04-24 20:25:29 +02:00
Michal Wozniak
79fe37537c Adjust the validation to the current state 2024-03-08 17:43:24 +01:00
Michal Wozniak
1163c7ed9c Adjust the API comments to the current state 2024-03-08 17:29:49 +01:00
Yuki Iwai
e216742672 Job: Support for the JobSuccessPolicy (alpha)
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-03-08 05:49:09 +09:00
Michał Woźniak
e568a77a93 Support for the Job managedBy field (alpha) (#123273)
* support for the managed-by label in Job

* Use managedBy field instead of managed-by label

* Additional review remarks

* Review remarks 2

* review remarks 3

* Skip cleanup of finalizers for job with custom managedBy

* Drop the performance optimization

* imrpove logs
2024-03-05 09:25:15 -08:00
Kubernetes Prow Robot
1fceb815ac Merge pull request #123437 from tenzen-y/fix-job-validatioin-test-name
Job: Fix test case names for the validations
2024-03-02 13:33:18 -08:00
Kubernetes Prow Robot
9fa043e769 Merge pull request #123181 from tenzen-y/job-avoid-casts-due-to-old-sets
Job: Use generic sets to avoid unnecessary string casts in valiations
2024-02-22 13:03:10 -08:00
Kubernetes Prow Robot
88c581833b Merge pull request #123081 from tenzen-y/job-stop-no-need-type-casting
Job: Stop unnecessary string casts in validations
2024-02-22 13:03:01 -08:00
Yuki Iwai
cc515bd8f1 Job: Fix test case names for the validations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-22 15:13:38 +09:00
Michal Wozniak
fe8e896df8 Improve the doc comment for the Job status.active field 2024-02-19 14:27:30 +01:00
Yuki Iwai
1ef469343f Job: Use generic sets to avoid unnecessary string casts in valiations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-08 08:02:00 +09:00
Yuki Iwai
71bf563034 Job: Stop unnecessary sting casts in validations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-02 06:46:30 +09:00
Kevin Hannon
4e5321c92e add beta comment for pod replacement policy 2023-12-05 13:17:24 -05:00
Kubernetes Prow Robot
e4b74dd12f Merge pull request #121765 from mimowo/ready-pods-stable-api
Fix API comment for the Job ready field
2023-11-07 23:52:12 +01:00
Michal Wozniak
9d5b2a4476 Fix API comment for the Job ready field 2023-11-07 07:38:51 +01:00
Michal Wozniak
1395e2e02c Fix API comment for the FailIndex Job pod failure policy action 2023-11-06 17:47:13 +01:00
Kubernetes Prow Robot
8149ab3f3f Merge pull request #121356 from mimowo/backoff-limit-per-index-beta
Graduate BackoffLimitPerIndex to Beta
2023-10-23 18:39:58 +02:00
Maciej Szulik
9a58f6c4fb Forbid creating CronJob with TZ or CRON_TZ, but allow updates 2023-10-20 17:14:03 +02:00
Michal Wozniak
6dd0ad5c0f Graduate BackoffLimitPerIndex to Beta 2023-10-19 12:18:36 +02:00
Dejan Zele Pejchev
921c0d0180 cleanup: add defaulting for job manual selector (#120206)
* cleanup: add defaulting for job manual selector

* cleanup: add assert in job defaults test for manual selector

* cleanup: fix failing job storage test

* cleanup: fix batch fuzzer to handle manual selector default

* cleanup: fix lint issue on checking bool condition in job strategy

* cleanup: remove TODO in generateSelectors in job strategy Validate; inline job manual selector assignment in fuzzer
2023-10-11 22:51:40 +02:00
Michal Wozniak
cc784cfe85 Mark Job onPodConditions as optional in pod failure policy 2023-08-28 11:42:56 +02:00
kannon92
f73c253acc fix typos for pod replacement policy 2023-08-09 20:34:48 +00:00
kannon92
ce92952037 add podReplacementPolicy and terminating field to job api 2023-07-19 16:34:38 +00:00
Michal Wozniak
cf0b74774f Extend the API for the Job job-index-failure-count annotation 2023-07-18 16:41:11 +02:00