Kubernetes Prow Robot
fbdf8905ea
Merge pull request #130058 from gjkim42/add-disableLegacySidecarContainers
...
Add LegacySidecarContainers feature gate
2025-02-12 13:16:27 -08:00
Kubernetes Prow Robot
cd2959b798
Merge pull request #127525 from scott-grimes/patch-1
...
fix: pods meeting qualifications for static placement when cpu-manager-policy=static should not have cfs quota enforcement
2025-02-12 12:02:21 -08:00
Gunju Kim
f2f4634bd3
Add LegacySidecarContainers feature gate
...
This adds LegacySidecarContainers feature gate that enables the legacy
code path that predates the SidecarContainers feature to safely remove
the code.
This temporary feature gate is disabled by default, only available in
v1.33, and will be removed in v1.34.
2025-02-12 20:15:49 +09:00
Scott Grimes
1c5170ff52
disable cfs quota when exclusive cpus allocated per static cpu policy requirements
2025-02-11 13:42:30 -05:00
Kubernetes Prow Robot
0634e21fb5
Merge pull request #128367 from vivzbansal/sidecar-2
...
[FG:InPlacePodVerticalScaling] Implement resize for sidecar containers
2025-02-05 14:38:15 -08:00
Gunju Kim
8d27bf2108
Leave TODOs in pkg/kubelet/kuberuntime for later removal
...
This leaves TODOs in pkg/kubelet/kuberuntime to remove these redundant
code paths later, since they are supposed to be a subset of the new code
paths.
2025-02-02 17:45:50 +09:00
Gunju Kim
0bee0bcaa7
Promote SidecarContainers feature to GA
2025-02-02 17:45:36 +09:00
vivzbansal
242dec3e34
Updated some unit tests and resolved some review comments
2025-01-27 19:46:54 +00:00
vivzbansal
2ba61325f6
Fix e2e test error due to ContainersToUpdate map not created
2025-01-27 19:46:54 +00:00
vivzbansal
6c5cf68722
Resolved latest review comments
2025-01-27 19:46:33 +00:00
vivzbansal
1cf4587277
Fix build error
2025-01-27 19:42:14 +00:00
vivzbansal
d1fac494f4
resolve merge conflicts
2025-01-27 19:42:13 +00:00
Tim Allclair
da4dc0aec7
Stop defaulting container ResizePolicy
2024-11-21 09:51:31 -08:00
Tim Allclair
8342d39956
Equate CPU limits below the minimum effective limit (10m)
2024-11-12 17:23:17 -08:00
Tim Allclair
25cf2a2aac
Allow adding limits
2024-11-11 12:04:36 -08:00
Tim Allclair
caedccf0e4
Allow resize when pod limits aren't set
2024-11-11 12:04:36 -08:00
Tim Allclair
1d822f1dc8
Fix linter errors
2024-11-08 06:48:50 -08:00
Tim Allclair
bf8354d460
Revert "[FG:InPlacePodVerticalScaling] kubelet: Propagate error in doPodResizeAction() to the caller"
2024-11-07 22:43:59 -08:00
Kubernetes Prow Robot
0fff5bbe7d
Merge pull request #128680 from tallclair/min-cpu
...
[FG:InPlacePodVerticalScaling] Handle edge cases around CPU MinShares
2024-11-08 05:24:51 +00:00
Kubernetes Prow Robot
210f129bb0
Merge pull request #128676 from vivzbansal/sidecar-3
...
Refactor: Move IsRestartableInitContainer to common utility package
2024-11-08 02:21:50 +00:00
Kubernetes Prow Robot
30052523d7
Merge pull request #127300 from hshiina/error-propagation
...
[FG:InPlacePodVerticalScaling] kubelet: Propagate error in doPodResizeAction() to the caller
2024-11-08 02:20:57 +00:00
Tim Allclair
5a3a40cd19
Handle resize edge cases around min CPU shares
2024-11-07 17:02:25 -08:00
Kubernetes Prow Robot
8504758a2e
Merge pull request #125757 from Nordix/esotsal/125205
...
[FG:InPlacePodVerticalScaling] Fix backoff problem when quickly reverting resize patch
2024-11-07 23:32:42 +00:00
vivzbansal
763e810fb5
refactor code to add sidecar container support in IPPR
2024-11-07 21:20:48 +00:00
Kubernetes Prow Robot
25101d33bc
Merge pull request #128518 from tallclair/pleg-watch-conditions
...
[FG:InPlacePodVerticalScaling] PLEG watch conditions: rapid polling for expected changes
2024-11-07 19:45:01 +00:00
Sotiris Salloumis
68fcc9cf8a
Fix slow reconcile when quickly reverting resize patch
2024-11-07 19:51:47 +01:00
Kubernetes Prow Robot
c462d4c8e5
Merge pull request #126096 from utam0k/support-disabling-oom-group-kill
...
kubelet: new kubelet config option for disabling group oom kill
2024-11-07 06:29:36 +00:00
utam0k
4f909c14a0
kubelet: new kubelet config option for disabling group oom kill
...
Signed-off-by: utam0k <k0ma@utam0k.jp >
2024-11-07 12:03:04 +09:00
Tim Allclair
7fce6f2317
More comments around PLEG WatchConditions
2024-11-06 11:05:24 -08:00
Tim Allclair
da9c2c553b
Set pod watch conditions for resize
2024-11-06 11:05:24 -08:00
Hironori Shiina
5562cb165b
kubelet: Propagate error in doPodResizeAction() to the caller
...
This fix makes doPodResizeAction() return the result instead of setting
an error to the `result` argument, which should have been passed as a
pointer, so that the error is propagated to the caller. This fix also
makes the usage of PodSyncResult more consistent with other operations
like starting and killing a container.
2024-11-05 16:37:29 +01:00
Itamar Holder
f21473b924
Set pod-level CPUPeriod only if CPUQuota is changed
...
Signed-off-by: Itamar Holder <iholder@redhat.com >
2024-10-30 14:21:35 +02:00
Itamar Holder
c792c30b6a
Refactor: remove no longer needed resourceName parameter
...
Signed-off-by: Itamar Holder <iholder@redhat.com >
2024-10-30 13:58:38 +02:00
Kubernetes Prow Robot
6737352b03
Merge pull request #125708 from hshiina/dopodresizeaction-error
...
[FG:InPlacePodVerticalScaling] Fix order of resizing pod cgroups in doPodResizeAction()
2024-10-30 01:21:25 +00:00
Tim Allclair
d1f1bf200c
Add more comments
2024-10-24 15:51:19 -07:00
Tim Allclair
321eff34f7
Rework allocated resources handling
2024-10-24 09:27:40 -07:00
Kubernetes Prow Robot
141951cd6b
Merge pull request #126420 from hoskeri/fix-container-succeeded-check-status
...
kuberuntime_manager: fix container success check.
2024-10-17 20:31:04 +01:00
Kubernetes Prow Robot
d1e03f3a77
Merge pull request #127195 from yaojunyu/fix-pod-alway-restart-open-envetedpleg
...
EventedPLEG: Set Timestamp in PodStatus for Generic PLEG more accurate
2024-10-14 23:36:20 +01:00
Davanum Srinivas
02c6df0436
Treat Timestamp as nanoseconds which response by PodSandboxStatus(e.g. CRI-O) and fix zero Timestamp without setting (e.g. containerd) change to now.
2024-09-22 15:59:43 +08:00
Hironori Shiina
1ec1ef3d06
kubelet: Fix order of resizing pod cgroups in doPodResizeAction()
2024-09-16 14:52:49 +02:00
Gunju Kim
be89a6120b
Avoid SidecarContainers code path for non-sidecar pods
...
This fixes a regression in the SidecarContainers feature by minimizing
the impact of the new code path. Use the old code path for pods without
restartable init containers, and apply the new code path only to pods
with restartable init containers.
2024-09-06 22:36:43 +09:00
Ed Bartosh
e1bc8defac
kubelet: Migrate DRA Manager to contextual logging
...
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com >
2024-08-22 11:12:41 +03:00
Abhijit Hoskeri
ae5268431a
kuberuntime_manager: fix container success check.
...
When evaluating whether a container ran to completion,
we only check whether the CRI container status `ExitCode` is 0.
But, the ExitCode is only meaningful if the container has actually
run and exited.
There are other states, eg: `Created` where the container runtime never
set an ExitCode - we shouldn't read it in that case.
2024-07-28 17:18:41 -07:00
Sascha Grunert
979863d15c
Add ImageVolumeSource implementation
...
This patch adds the kubelet implementation of the image volume source
feature.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com >
2024-07-22 18:46:46 +02:00
Shingo Omura
f46ecf5648
KEP-3619: Wiring up from RuntimeFeatures.SupplementalGroupsPolicy(CRI) to NodeFeatures.SupplementalGroupsPolicy(API)
...
KEP-3619: fix typos in pkg/kubelet/container/runtime.go
2024-07-16 12:36:00 +09:00
HirazawaUi
3ec13c5e37
remove HashWithoutResources field
2024-05-22 10:01:31 +08:00
HirazawaUi
f6b650430a
fixed container restart due to field changes
2024-05-22 09:55:46 +08:00
Kubernetes Prow Robot
dc3f5ec6cc
Merge pull request #112957 from mxpv/log-dir
...
Allow changing pod log directory
2024-03-04 21:07:06 -08:00
Giuseppe Scrivano
024146f705
KEP-127: the kubelet stores runtime helpers
...
as they are received from the ResponseStatus request to the runtime.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com >
2024-02-27 11:07:35 +01:00
Maksym Pavlenko
d9e2487d0c
Add PodLogsPath to kubelet config
...
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com >
2024-02-16 09:55:59 -08:00
