Kubernetes Prow Robot
fbdf8905ea
Merge pull request #130058 from gjkim42/add-disableLegacySidecarContainers
...
Add LegacySidecarContainers feature gate
2025-02-12 13:16:27 -08:00
Kubernetes Prow Robot
cd2959b798
Merge pull request #127525 from scott-grimes/patch-1
...
fix: pods meeting qualifications for static placement when cpu-manager-policy=static should not have cfs quota enforcement
2025-02-12 12:02:21 -08:00
Gunju Kim
f2f4634bd3
Add LegacySidecarContainers feature gate
...
This adds LegacySidecarContainers feature gate that enables the legacy
code path that predates the SidecarContainers feature to safely remove
the code.
This temporary feature gate is disabled by default, only available in
v1.33, and will be removed in v1.34.
2025-02-12 20:15:49 +09:00
Scott Grimes
1c5170ff52
disable cfs quota when exclusive cpus allocated per static cpu policy requirements
2025-02-11 13:42:30 -05:00
Kubernetes Prow Robot
0634e21fb5
Merge pull request #128367 from vivzbansal/sidecar-2
...
[FG:InPlacePodVerticalScaling] Implement resize for sidecar containers
2025-02-05 14:38:15 -08:00
Gunju Kim
0bee0bcaa7
Promote SidecarContainers feature to GA
2025-02-02 17:45:36 +09:00
vivzbansal
242dec3e34
Updated some unit tests and resolved some review comments
2025-01-27 19:46:54 +00:00
vivzbansal
6c5cf68722
Resolved latest review comments
2025-01-27 19:46:33 +00:00
vivzbansal
1cf4587277
Fix build error
2025-01-27 19:42:14 +00:00
vivzbansal
d1fac494f4
resolve merge conflicts
2025-01-27 19:42:13 +00:00
Paco Xu
03a15fa65d
Revert "[FG:InPlacePodVerticalScaling] Graduate to Beta"
2024-11-20 14:55:29 +08:00
Tim Allclair
8342d39956
Equate CPU limits below the minimum effective limit (10m)
2024-11-12 17:23:17 -08:00
Kubernetes Prow Robot
79e5584257
Merge pull request #128682 from tallclair/ippr-beta
...
[FG:InPlacePodVerticalScaling] Graduate to Beta
2024-11-12 19:00:46 +00:00
Tim Allclair
caedccf0e4
Allow resize when pod limits aren't set
2024-11-11 12:04:36 -08:00
Tim Allclair
479b300227
Fix unit tests
2024-11-09 14:29:02 -08:00
Tim Allclair
1d822f1dc8
Fix linter errors
2024-11-08 06:48:50 -08:00
Tim Allclair
bf8354d460
Revert "[FG:InPlacePodVerticalScaling] kubelet: Propagate error in doPodResizeAction() to the caller"
2024-11-07 22:43:59 -08:00
Kubernetes Prow Robot
0fff5bbe7d
Merge pull request #128680 from tallclair/min-cpu
...
[FG:InPlacePodVerticalScaling] Handle edge cases around CPU MinShares
2024-11-08 05:24:51 +00:00
Kubernetes Prow Robot
30052523d7
Merge pull request #127300 from hshiina/error-propagation
...
[FG:InPlacePodVerticalScaling] kubelet: Propagate error in doPodResizeAction() to the caller
2024-11-08 02:20:57 +00:00
Tim Allclair
5a3a40cd19
Handle resize edge cases around min CPU shares
2024-11-07 17:02:25 -08:00
Kubernetes Prow Robot
98b4ee6bfa
Merge pull request #126525 from dshebib/addSidecarE2EImgTest
...
Restart sidecar container when the image has changed
2024-11-06 00:35:35 +00:00
Hironori Shiina
5562cb165b
kubelet: Propagate error in doPodResizeAction() to the caller
...
This fix makes doPodResizeAction() return the result instead of setting
an error to the `result` argument, which should have been passed as a
pointer, so that the error is propagated to the caller. This fix also
makes the usage of PodSyncResult more consistent with other operations
like starting and killing a container.
2024-11-05 16:37:29 +01:00
Tim Allclair
321eff34f7
Rework allocated resources handling
2024-10-24 09:27:40 -07:00
Kubernetes Prow Robot
141951cd6b
Merge pull request #126420 from hoskeri/fix-container-succeeded-check-status
...
kuberuntime_manager: fix container success check.
2024-10-17 20:31:04 +01:00
Daniel Shebib
51883d5821
sidecar containers restart on definition change
2024-10-13 01:21:57 -05:00
Kubernetes Prow Robot
b73f84c934
Merge pull request #126543 from gjkim42/restart-failed-to-start-container
...
Restart the init container to not be stuck in created state
2024-09-06 20:07:58 +01:00
Gunju Kim
be89a6120b
Avoid SidecarContainers code path for non-sidecar pods
...
This fixes a regression in the SidecarContainers feature by minimizing
the impact of the new code path. Use the old code path for pods without
restartable init containers, and apply the new code path only to pods
with restartable init containers.
2024-09-06 22:36:43 +09:00
Gunju Kim
4363a8453c
Restart the init container to not be stuck in created state
...
The main sync loop should have created and started the container in one
step. If the init container is in the 'created' state, it's likely that
the container runtime failed to start it. To prevent the container from
getting stuck in the 'created' state, restart it.
2024-09-05 22:37:45 +09:00
Abhijit Hoskeri
ae5268431a
kuberuntime_manager: fix container success check.
...
When evaluating whether a container ran to completion,
we only check whether the CRI container status `ExitCode` is 0.
But, the ExitCode is only meaningful if the container has actually
run and exited.
There are other states, eg: `Created` where the container runtime never
set an ExitCode - we shouldn't read it in that case.
2024-07-28 17:18:41 -07:00
Sascha Grunert
979863d15c
Add ImageVolumeSource implementation
...
This patch adds the kubelet implementation of the image volume source
feature.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com >
2024-07-22 18:46:46 +02:00
Matthieu MOREL
f014b754fb
fix: enable empty and len rules from testifylint on pkg package
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com >
Co-authored-by: Patrick Ohly <patrick.ohly@intel.com >
2024-07-06 23:15:43 +00:00
Kubernetes Prow Robot
e6616033cb
Merge pull request #120844 from bzsuni/cleanup/sets/kubelet
...
[kubelet] Use a generic Set instead of a specified Set
2024-06-14 09:09:17 -07:00
Kubernetes Prow Robot
f057f2de1c
Merge pull request #124956 from TommyStarK/remove-deprecated-otel-noop-tracer
...
cmd/kubelet: remove deprecated otel NewNoopTracerProvider
2024-06-06 17:05:34 -07:00
Kubernetes Prow Robot
a8d51f4f05
Use a generic Set instead of a specified Set in kubelet
...
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io >
2024-06-04 14:25:43 +08:00
Kubernetes Prow Robot
dad8fe71f2
Merge pull request #124220 from HirazawaUi/fix-pod-restarted
...
[kubelet]: fixed container restart due to pod spec field changes
2024-05-22 15:43:36 -07:00
TommyStarK
c0ed4972ac
kubelet: remove deprecated otel NewNoopTracerProvider
...
Signed-off-by: TommyStarK <thomasmilox@gmail.com >
2024-05-22 17:38:20 +02:00
HirazawaUi
3ec13c5e37
remove HashWithoutResources field
2024-05-22 10:01:31 +08:00
HirazawaUi
f6b650430a
fixed container restart due to field changes
2024-05-22 09:55:46 +08:00
Marek Siarkowicz
3ee8178768
Cleanup defer from SetFeatureGateDuringTest function call
2024-04-24 20:25:29 +02:00
Sascha Grunert
2076429e43
Enable pod container resources tests on Windows
...
PR https://github.com/kubernetes/kubernetes/pull/112599 merged so it
seems that we can now enable the tests on Windows.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com >
2023-11-16 14:13:06 +01:00
Gunju Kim
696f84aeb0
Feature-gate SidecarContainers code in pkg/kubelet/kuberuntime
2023-09-01 00:13:47 +09:00
Gunju Kim
7ef2d674e2
Allow restartable init containers to have livenessProbe
2023-07-18 07:54:33 +09:00
Gunju Kim
b94fa250c2
Sidecar: Implement lifecycle of the restartable init container
...
- Implement `computeInitContainerActions` to sets the actions for the
init containers, including those with `RestartPolicyAlways`.
- Allow StartupProbe on the restartable init containers.
- Update PodPhase considering the restartable init containers.
- Update PodInitialized status and status manager considering the
restartable init containers.
Co-authored-by: Matthias Bertschy <matthias.bertschy@gmail.com >
2023-07-08 07:26:12 +09:00
Kubernetes Prow Robot
d86b74b017
Merge pull request #116575 from claudiubelu/fixes-kuberuntime-unittests
...
unit tests: Fixes kuberuntime unittests for Windows
2023-05-03 13:48:42 -07:00
Claudiu Belu
561548e86c
unit tests: Fixes kuberuntime unittests for Windows
...
InPlace Pod Vertical Scaling has been introduced as a feature recently,
and with it new unit tests. The feature does not have Windows support
yet, thus, the unit tests fail on Windows.
Fixes unit test which checks Linux-specific fields on Windows.
2023-05-02 20:25:42 +00:00
Kubernetes Prow Robot
9053b5dc2c
Merge pull request #116119 from vinaykul/restart-free-pod-vertical-scaling-fixes
...
Restructure resize policy naming and set default resize policy values
2023-03-14 19:26:42 -07:00
vinay kulkarni
9a805db010
Set default resize policy only for specified resource types, rename RestartNotRequired -> NotRequired
2023-03-12 23:46:40 +00:00
vinay kulkarni
8b23497ae7
Restructure naming of resource resize restart policy
2023-03-12 23:11:32 +00:00
Vadim Rutkovsky
556d774945
kubelet: create top-level traces for pod sync and GC
...
This starts new top level OpenTelemetry spans every time syncPod or image / container GC is invoked
2023-03-11 10:42:14 +01:00
Kubernetes Prow Robot
10802e9be1
Merge pull request #114498 from runzhliu/patch-2
...
Update kuberuntime_manager_test.go
2023-03-09 21:33:52 -08:00