scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-12-03 14:53:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
128,234 Commits 1 Branch 0 Tags
b51cbb1d17ca680139d306b43a88c723e72a6103
Commit Graph

219 Commits

Author SHA1 Message Date
Itamar Holder
54500bfe69 cadvisor_provider, unit tests: ensure container-level metrics are collected 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2025-01-27 13:13:17 +02:00
Itamar Holder
ceeba21d3d cadvisor_provider, unit test: Add swap stats to cadvisor CPU and Memory stats 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2025-01-27 13:13:17 +02:00
Itamar Holder
c111266609 cadvisor_provider, bugfix: Add swap stats to CPU and Memory stats 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2025-01-27 13:13:17 +02:00
Itamar Holder
e6c19f315f cri_provider, unit tests: ensure container-level metrics are collected 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2025-01-27 13:13:17 +02:00
Itamar Holder
748b52a130 cri_provider, bugfix: Add cadvisor container stats 
Without this fix, when CRI stats provided collects cadvisor
stats, pod swap stats are being collected but corresponding
container swap stats are not. This commit fixes this.

Signed-off-by: Itamar Holder <iholder@redhat.com>
 2025-01-27 13:13:17 +02:00
Ed Bartosh
e5cb071c2e kubelet: Migrate CAdvisor to contextual logging 2024-11-06 01:49:20 +02:00
Kevin Hannon
c25563b9ab Fix a bug where container fs is considered split if imagefs and 
containerfs are on the same drive but different path
 2024-10-25 18:51:22 -04:00
Anish Shah
ac82e8a005 Revert "Fix issue in split filesystem where layers are stored on same disk but different paths" 
This reverts commit aea0b90652.
 2024-10-25 02:09:55 -07:00
Kubernetes Prow Robot
c4a14d7ef5 Merge pull request #126562 from kannon92/split-filesystem-on-same-disk 
[KEP-4191]: Fix issue in split filesystem
 2024-10-22 19:48:53 +01:00
Prince Pereira
3448455083 Replacing hcsshim library with new hnslib library. 2024-10-14 10:44:30 -07:00
Kirtana Ashok
4a5513c19c Add local reference to hcs structs in windows cri stats test 
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
 2024-09-25 18:56:03 -07:00
Kevin Hannon
aea0b90652 Fix issue in split filesystem where layers are stored on same disk but different paths 2024-08-07 10:43:19 -04:00
Sascha Grunert
50e430b3e9 Fix kubelet cadvisor stats runtime panic 
Fixing a kubelet runtime panic when the runtime returns incomplete data:

```
E0729 08:17:47.260393    5218 panic.go:115] "Observed a panic" panic="runtime error: index out of range [0] with length 0" panicGoValue="runtime.boundsError{x:0, y:0, signed:true, code:0x0}" stacktrace=<
        goroutine 174 [running]:
        k8s.io/apimachinery/pkg/util/runtime.logPanic({0x33631e8, 0x4ddf5c0}, {0x2c9bfe0, 0xc000a563f0})
                k8s.io/apimachinery/pkg/util/runtime/runtime.go:107 +0xbc
        k8s.io/apimachinery/pkg/util/runtime.handleCrash({0x33631e8, 0x4ddf5c0}, {0x2c9bfe0, 0xc000a563f0}, {0x4ddf5c0, 0x0, 0x10000000043c9e5?})
                k8s.io/apimachinery/pkg/util/runtime/runtime.go:82 +0x5e
        k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc000ae08c0?})
                k8s.io/apimachinery/pkg/util/runtime/runtime.go:59 +0x108
        panic({0x2c9bfe0?, 0xc000a563f0?})
                runtime/panic.go:785 +0x132
        k8s.io/kubernetes/pkg/kubelet/stats.(*cadvisorStatsProvider).ImageFsStats(0xc000535d10, {0x3363348, 0xc000afa330})
                k8s.io/kubernetes/pkg/kubelet/stats/cadvisor_stats_provider.go:277 +0xaba
        k8s.io/kubernetes/pkg/kubelet/images.(*realImageGCManager).GarbageCollect(0xc000a3c820, {0x33631e8?, 0x4ddf5c0?}, {0x0?, 0x0?, 0x4dbca20?})
                k8s.io/kubernetes/pkg/kubelet/images/image_gc_manager.go:354 +0x1d3
        k8s.io/kubernetes/pkg/kubelet.(*Kubelet).StartGarbageCollection.func2()
                k8s.io/kubernetes/pkg/kubelet/kubelet.go:1472 +0x58
        k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0x30?)
                k8s.io/apimachinery/pkg/util/wait/backoff.go:226 +0x33
        k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0xc000add110, {0x3330380, 0xc000afa300}, 0x1, 0xc0000ac150)
                k8s.io/apimachinery/pkg/util/wait/backoff.go:227 +0xaf
        k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc000add110, 0x45d964b800, 0x0, 0x1, 0xc0000ac150)
                k8s.io/apimachinery/pkg/util/wait/backoff.go:204 +0x7f
        k8s.io/apimachinery/pkg/util/wait.Until(...)
                k8s.io/apimachinery/pkg/util/wait/backoff.go:161
        created by k8s.io/kubernetes/pkg/kubelet.(*Kubelet).StartGarbageCollection in goroutine 1
                k8s.io/kubernetes/pkg/kubelet/kubelet.go:1470 +0x247
```

This commit fixes panics if:

- `len(imageStats.ImageFilesystems) == 0`
- `len(imageStats.ContainerFilesystems) == 0`
- `imageStats.ImageFilesystems[0].FsId == nil`
- `imageStats.ContainerFilesystems[0].FsId == nil`
- `imageStats.ImageFilesystems[0].UsedBytes == nil`
- `imageStats.ContainerFilesystems[0].UsedBytes == nil`

It also fixes the wrapped `nil` error for the check: `err != nil ||
imageStats == nil` in case that `imageStats == nil`.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
 2024-07-29 14:13:47 +02:00
Kubernetes Prow Robot
e9d9a82839 Merge pull request #124101 from haircommander/process_stats-with-pid-fix 
kubelet: fix PID based eviction
 2024-07-25 11:59:57 -07:00
Kevin Hannon
3e642aee3f move container fs check so that we only check if system is split 2024-07-24 11:22:23 -04:00
Peter Hunt
5fd7219cf4 kubelet/stats: fix pid stats for cadvisor stats provider 
the process stats aren't correct coming from only the pod stats.
They need to be summed for all of the containers, as cadvisor
is only reading per pid (per container process)

Signed-off-by: Peter Hunt <pehunt@redhat.com>
 2024-07-22 10:54:42 -04:00
David Porter
6e6b2b76a3 test: Update summary test to check for process count 
The process count is expected to always be >= 1 for pods in the test.

Let's check it's >= 1, so we can catch issues if the proecss count is
not reported.

Signed-off-by: David Porter <david@porter.me>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
 2024-07-22 10:54:42 -04:00
David Porter
f58b46cb97 fix process stats 
Signed-off-by: David Porter <david@porter.me>
 2024-07-22 10:54:42 -04:00
Kubernetes Prow Robot
27fa59a8af Merge pull request #125656 from gyuho/recent-stats-check-error-for-error-level-logging 
feat(kubelet/stats): match cadvisor error to lower not found stats log level
 2024-07-18 19:24:01 -07:00
Matthieu MOREL
f014b754fb fix: enable empty and len rules from testifylint on pkg package 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>
 2024-07-06 23:15:43 +00:00
Gyuho Lee
ac992f9a92 remove unncessary errors.Unwrap calls 
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2024-07-03 21:31:57 +08:00
Gyuho Lee
d29bdab951 feat(kubelet/stats): match cadvisor error to lower not found stats log level 
This "RecentStats: unable to find data in memory cache" error is not actionable,
in terms of kubelt, if the entry is not found in the memory cache.

Thus, proposing it to lower the log level to info.

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
 2024-06-24 12:25:03 +08:00
Stephen Kitt
3f36c83c68 Switch to stretchr/testify / mockery for mocks 
testify is used throughout the codebase; this switches mocks from
gomock to testify with the help of mockery for code generation.

Handlers and mocks in test/utils/oidc are moved to a new package:
mockery operates package by package, and requires packages to build
correctly; test/utils/oidc/testserver.go relies on the mocks and fails
to build when they are removed. Moving the interface and mocks to a
different package allows mockery to process that package without
having to build testserver.go.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
 2024-06-20 19:42:53 +02:00
Claudiu Belu
2be8baeaef unittests: Skip failing Windows tests 
Some of the unit tests are currently failing on Windows.

Skip them for now, and remove the skips later, once the underlying issues
have been resolved.
 2024-04-25 14:24:16 +00:00
Marek Siarkowicz
3ee8178768 Cleanup defer from SetFeatureGateDuringTest function call 2024-04-24 20:25:29 +02:00
Stephen Kitt
6bf667af06 Switch from golang/mock to uber-go/mock 
See https://github.com/golang/mock#gomock: golang/mock is no longer
maintained, and should be replaced by go.uber.org/mock.

This allows golang/mock to be dropped from the status and vendored
fields in unwanted-dependencies.json.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
 2024-03-07 09:12:16 +01:00
Kubernetes Prow Robot
dc3f5ec6cc Merge pull request #112957 from mxpv/log-dir 
Allow changing pod log directory
 2024-03-04 21:07:06 -08:00
Paco Xu
0f49a1e36e fix panic in CRI stats of windows 2024-02-18 15:03:11 +08:00
Maksym Pavlenko
ae0a813be1 Fix tests after rebase 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-16 16:02:10 -08:00
Maksym Pavlenko
ff4f2907c5 Use non-default directory for pod logs and limit path to ASCII characters 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-16 09:57:17 -08:00
Maksym Pavlenko
d9e2487d0c Add PodLogsPath to kubelet config 
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
 2024-02-16 09:55:59 -08:00
Mark Rossetti
5ba3883be0 Adding unit test for makeWinContainerStats 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
 2024-02-12 09:56:58 -08:00
Mark Rossetti
5691a7899e Fixing bug with windows criStatsProvider sometimes not reporting AvailableBytes correctly 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
 2024-01-18 10:13:49 -08:00
Kubernetes Prow Robot
e1576c8e43 Merge pull request #121924 from saschagrunert/leaky 
Remove `leaky` package and move `PodInfraContainerName` to staging
 2024-01-04 17:59:30 +01:00
Davanum Srinivas
d621e09a52 remove unused GetRawContainerInfo 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-15 05:56:22 -08:00
Davanum Srinivas
e2cf9692fc Remove unused code in kubelet - take 1 
spotted `DockerContainer` in types.go and pulling on whether we
really needed it found that a bunch of code is not really
required.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-14 13:31:38 -08:00
Sascha Grunert
140abfc010 Remove leaky package and move PodInfraContainerName to staging 
The variable can be reused in other projects like cadvisor or container
runtimes later on to identify the pod infra container. The `leaky`
package itself is actually not needed any more.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
 2023-11-16 14:34:22 +01:00
Kevin Hannon
26923b91e8 implementation of split disk kep 2023-11-01 14:46:33 -04:00
Kubernetes Prow Robot
92c4b3254f Merge pull request #118432 from testwill/stats 
chore: loop optimization
 2023-10-26 06:25:25 +02:00
Kevin Hannon
8ae0d390d7 add container filesystem to CRI api 
Co-authored-by: Mike Brown <brownwm@us.ibm.com>
 2023-10-23 15:04:30 -04:00
Sascha Grunert
39dcad8a19 Populate CRI filesystem info error 
Usually we just log the error but since it's used by the GC we now
populate it up the call stack.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
 2023-10-16 13:09:04 +02:00
Kubernetes Prow Robot
95bd8b95a7 Merge pull request #100448 from saschagrunert/cri-stats-log 
Do not error log CRI stats for not cached partitions
 2023-10-14 23:49:12 +02:00
Christoph Mewes
79a7833ade fix typo Mininum => Minimum 2023-09-17 11:24:29 +02:00
Kubernetes Prow Robot
b27670dfbd Merge pull request #118740 from saschagrunert/kubelet-label-types 
Make kubelet label types public
 2023-09-06 23:46:57 -07:00
Kubernetes Prow Robot
6b0e66abad Merge pull request #116968 from mansikulkarni96/windowsStatsFromCRI 
kubelet: Implement support for Windows podAndContainerStatsFromCRI
 2023-07-18 11:07:10 -07:00
Itamar Holder
7d187f967b Unit tests: CRI swap stats 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2023-07-18 02:55:56 +03:00
Itamar Holder
59e3e3897e Add SwapStats to summary API through CRI 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2023-07-18 02:55:56 +03:00
Itamar Holder
87ff9c4525 Add swap statistics to CRI-API 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2023-07-18 02:55:53 +03:00
Itamar Holder
053d7ac61f Unit tests: cadvisor swap stats 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2023-07-18 02:40:02 +03:00
Itamar Holder
c74ee8045d Add SwapStats to summary API through cadvisor 
Signed-off-by: Itamar Holder <iholder@redhat.com>
 2023-07-18 02:40:02 +03:00