scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-12-15 20:37:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
120,741 Commits 1 Branch 0 Tags
cae710d9e9615447dd609d40a47651890540ccdf
Commit Graph

11099 Commits

Author SHA1 Message Date
Rodrigo Campos
cae710d9e9 kublet/userns: Test error messages on init failures 
This adds a test for the just added wrapping error message, as well as
for the other already present error messages that initialization can
fail with.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2024-02-05 19:03:50 +01:00
Rodrigo Campos
a56d483df0 kubelet/userns: Use t.TempDir() 
These tests will create the userns record mapping file, so let's use a
temporal directory for that.

Without specifying one, by mistake we were using the
"/tmp/non-existant-dir.This-is-not-used-in-tests/" directory.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2024-02-01 12:02:29 +01:00
Rodrigo Campos
0f7b9cc4f5 pkg/kubelet/userns: Simplify error messages 
The error we are wrapping is already verbose, let's just use minimal
wrapping as it is usually the case in go code.

Note that the error on parseUserNsFileAndRecord() can be returned to the
user, so we added some context about user namespace. Otherwise, an error
to parse the json would not be clear to which of all the json the kubelet
parses it refers to.

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2024-02-01 12:02:29 +01:00
Rodrigo Campos
fdc20de500 kubelet/userns: Wrap error message 
Most error messages are properly wrapped already, but this was missing.

The kubelet logs will show something like this now:

	E0201 12:00:03.505680 3007049 run.go:74] "command failed" err="failed to run Kubelet: failed to create kubelet: record pod mappings: create user namespace store: mkdir XXX: permission denied"

Before this commit, the message was not so clear:

	E0120 16:02:40.484404  474711 run.go:74] "command failed" err="failed to run Kubelet: failed to create kubelet: mkdir XXX: permission denied"

Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com>
 2024-02-01 12:02:06 +01:00
Kubernetes Prow Robot
7abf6770fd Merge pull request #122147 from pohly/kubelet-context-support 
kubelet: enhance context support
 2024-01-27 05:16:17 -08:00
Kubernetes Prow Robot
3da22db11c Merge pull request #121499 from matte21/add-comments-to-cpu-accumulator 
Improve understandability of kubelet's cpu accumulator code
 2024-01-26 00:56:21 +01:00
KubeKyrie
9860e12d6e expected and actual field position adjustment 
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
 2024-01-13 12:16:14 +08:00
Kubernetes Prow Robot
ccb1d08162 Merge pull request #121834 from vaibhav2107/eviction-update 
Added Imagefs inodes in default Eviction Hard
 2024-01-09 21:18:16 +01:00
Akihiro Suda
2e999fff02 Fix compiling e2e.test on macOS 
Fix issue 122650 (regression in PR 122552)

```
$ make WHAT=test/e2e/e2e.test
+++ [0109 10:06:53] Building go targets for darwin/amd64
    k8s.io/kubernetes/test/e2e/e2e.test (test)
package k8s.io/kubernetes/test/e2e
        imports k8s.io/kubernetes/test/e2e/common
        imports k8s.io/kubernetes/test/e2e/common/node
        imports k8s.io/kubernetes/pkg/kubelet
        imports github.com/opencontainers/runc/libcontainer/userns: C source files not allowed when not using cgo or SWIG: userns_maps.c
!!! [0109 10:06:54] Call tree:
!!! [0109 10:06:54]  1: /Users/suda/gopath/src/k8s.io/kubernetes/hack/lib/golang.sh:948 kube::golang::build_binaries_for_platform(...)
!!! [0109 10:06:54]  2: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0109 10:06:54] Call tree:
!!! [0109 10:06:54]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0109 10:06:54] Call tree:
!!! [0109 10:06:54]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make: *** [all] Error 1
```

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 2024-01-09 10:42:20 +09:00
Kubernetes Prow Robot
6427e2c9c8 Merge pull request #122578 from carlory/lock-default-ConsistentHTTPGetHandlers 
lock GA feature-gate ConsistentHTTPGetHandlers to default
 2024-01-04 18:00:52 +01:00
Kubernetes Prow Robot
0babde6bac Merge pull request #122475 from pacoxu/patch-9 
fix nil pointer dereference when EventedPLEG is enabled
 2024-01-04 18:00:43 +01:00
Kubernetes Prow Robot
2b1ccec47e Merge pull request #122087 from fatsheep9146/fix-kubelet-trace-broke 
fix kubelet trace broke in 1.28
 2024-01-04 17:59:39 +01:00
Kubernetes Prow Robot
e1576c8e43 Merge pull request #121924 from saschagrunert/leaky 
Remove `leaky` package and move `PodInfraContainerName` to staging
 2024-01-04 17:59:30 +01:00
Kubernetes Prow Robot
c96d7a5b5a Merge pull request #121774 from charles-chenzz/increase_timeout_in_dra_shouldTimeOut 
increase timeout in fakeDraDriverGrpcServer to fix flake
 2024-01-04 17:59:12 +01:00
Kubernetes Prow Robot
014149d66e Merge pull request #121565 from srivastav-abhishek/logs_test_datarace 
[FLAKE] Fixed UT pkg/kubelet/kuberuntime/logs/TestReadRotatedLog caused due to data race
 2024-01-04 16:49:23 +01:00
carlory
55c5db172e lock GA feature-gate ConsistentHTTPGetHandlers to default 2024-01-04 15:12:08 +08:00
Paco Xu
feb833f129 fix nil pointer dereference when EventedPLEG is enabled 2023-12-25 16:09:30 +08:00
Kubernetes Prow Robot
2b5c0c281d Merge pull request #122310 from weilaaa/use_buildin_max_min_instead 
use build-in max and min func to instead of k8s.io/utils/integer funcs
 2023-12-18 19:25:34 +01:00
Kubernetes Prow Robot
e6acd1caf5 Merge pull request #122330 from dims/remove-unused-code-in-kubelet 
Remove unused code in kubelet - DockerContainer / ContainerInfo / SubcontainerInfo / WatchEvents
 2023-12-16 23:46:02 +01:00
Davanum Srinivas
642574e964 WatchEvents seems useless 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-15 17:07:20 -05:00
Davanum Srinivas
aee1d54a0d Drop SubcontainerInfo 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-15 16:58:00 -05:00
Davanum Srinivas
c865ad532a fixing based on feedback in PR 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-15 16:51:15 -05:00
Kubernetes Prow Robot
c633ea71ed Merge pull request #122211 from gnufied/fix-uncertain-raw-block-devices 
Fix device uncertain errors on reboot
 2023-12-15 15:42:40 +01:00
Davanum Srinivas
d621e09a52 remove unused GetRawContainerInfo 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-15 05:56:22 -08:00
weilaaa
eb8f3f194f use build-in max and min func to instead of k8s.io/utils/integer funcs 2023-12-15 15:09:11 +08:00
Davanum Srinivas
e2cf9692fc Remove unused code in kubelet - take 1 
spotted `DockerContainer` in types.go and pulling on whether we
really needed it found that a bunch of code is not really
required.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2023-12-14 13:31:38 -08:00
Hemant Kumar
e706b6ba14 Use a separate function for checking if device was reconstructed 2023-12-14 11:37:47 -05:00
Kubernetes Prow Robot
30bb24b1c3 Merge pull request #121913 from liggitt/testing-dep 
Drop testing dependency from shipped binaries
 2023-12-13 23:55:56 +01:00
Kubernetes Prow Robot
8cc47b64b2 Merge pull request #121795 from carlory/cleanup-after-blockvolume-featuregate-removed 
cleanup todo after feature.BlockVolume gate was removed
 2023-12-13 23:54:43 +01:00
Kubernetes Prow Robot
26e2cc5299 Merge pull request #119923 from cvvz/fix-119921 
fix: Mount point may become local without calling `NodePublishVolume` after node rebooting
 2023-12-13 21:25:51 +01:00
Kubernetes Prow Robot
3c1356bc9b Merge pull request #119764 from linxiulei/reservedTypo 
Fix error message for invalid resource reservation
 2023-12-13 21:25:42 +01:00
Hemant Kumar
56dd5ab10f Add tests for checking of uncertain device paths 2023-12-11 17:15:16 -05:00
Hemant Kumar
ed0facacfa Fix device uncertain errors on reboot 2023-12-06 22:19:14 -05:00
Ziqi Zhao
e92501b8fc optimize the comment 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-12-05 22:46:27 +08:00
Ziqi Zhao
51495bb4c5 optimize the unit test 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-12-05 08:02:03 +08:00
Ziqi Zhao
69c40a3396 fix lints 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-12-02 19:37:49 +08:00
Ziqi Zhao
24c4d6f7c9 add unit test for kubelet trace 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-12-02 17:09:01 +08:00
Patrick Ohly
d11511b1e8 kubelet: enhance context support 
27a68aee3a introduced context support for events. Creating an event
broadcaster with context makes tests more resilient against leaking goroutines
when that context gets canceled at the end of a test and enables per-test
output via ktesting.

To use this in kubelet, a more thorough code update is needed. For now,
context.TODO serves as a reminder that this is necessary.
 2023-12-01 10:15:01 +01:00
Ziqi Zhao
f035fea63a remove unnecessary code 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-11-29 09:59:53 +08:00
Ziqi Zhao
6d92b330e3 use ctx withoutcancel 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-11-28 23:43:33 +08:00
Ziqi Zhao
90fc108f6d fix kubelet trace broke in 1.28 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-11-28 20:02:23 +08:00
Sascha Grunert
140abfc010 Remove leaky package and move PodInfraContainerName to staging 
The variable can be reused in other projects like cadvisor or container
runtimes later on to identify the pod infra container. The `leaky`
package itself is actually not needed any more.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
 2023-11-16 14:34:22 +01:00
Jordan Liggitt
5164db066c Drop testing dependency from shipped binaries 2023-11-15 15:05:18 -05:00
vaibhav2107
1dadf576f2 Updated Added Imagefs inodes in default Eviction Hard 2023-11-15 22:18:53 +05:30
Kubernetes Prow Robot
c3114b2789 Merge pull request #119652 from lixd/kubelet_image_gc 
fix kubelet image gc
 2023-11-13 17:36:15 +01:00
vaibhav2107
30dc2f0773 Added Imagefs inodes in default Eviction Hard 2023-11-10 09:49:56 +05:30
carlory
1c0044594d cleanup todo after feature.BlockVolume gate was removed 2023-11-09 10:01:24 +08:00
charles-chenzz
abaf7a800d increase timeout in fakeDraDriverGrpcServer to fix flake in dra/manger_test 2023-11-07 19:38:27 +08:00
weizhichen
b91f07008c add ut 2023-11-06 08:20:42 +00:00
Kubernetes Prow Robot
9f319c3206 Merge pull request #113374 from ahmedtd/kep-3257-projected-types 
Implement ClusterTrustBundlePEM projected volume
 2023-11-04 01:44:56 +01:00