Commit Graph

118 Commits

Author SHA1 Message Date
Michal Wozniak
cad648035a Job Pod Failure policy - cover testing of negative exit codes 2024-10-28 07:24:26 +01:00
Alay Patel
0aa065ab7e update e2e and integration test for PodIndexLabel
Signed-off-by: Alay Patel <alayp@nvidia.com>
2024-10-25 12:17:19 -04:00
Kevin
234c055205 Use logger context in job controller tests
Signed-off-by: Kevin <kpostlet@redhat.com>
2024-09-11 15:47:12 -04:00
Kubernetes Prow Robot
ebe3404b5a Merge pull request #126439 from kaisoz/improve-job-test-runtime
Improve Job integration tests runtime by reusing apiserver within each test
2024-09-11 19:03:13 +01:00
Tomas Tormo
99eea8054b Improve Job integration tests runtime 2024-09-11 10:45:29 +00:00
Yuki Iwai
61c9d67652 JobIntegrationTest: Increase the restConfig QPS and Burst parameters
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-09-06 05:46:11 +09:00
Yuki Iwai
34dcec91f8 JobIntegrationTest: Retry polling even if the client fails to obtain Jobs at once
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-09-03 06:22:44 +09:00
Yuki Iwai
25c2731399 Job: Use type parameters instead of type casting for the ptr libraries
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-24 03:38:18 +09:00
Yuki Iwai
551931c6a8 Graduate the JobSuccessPolicy to beta
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-23 09:29:06 +09:00
Yuki Iwai
6e8dc2c250 Job: Extend the jobs_finished_total metric reason label with SuccessPolicy and CompletionsReached
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-23 09:29:02 +09:00
Yuki Iwai
594490fd77 Job: Add the CompletionsReached reason to the SuccessCriteriaMet condition
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-07-22 21:24:52 +09:00
Michal Wozniak
f1233ac5e0 JobPodFailurePolicy to GA
# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-12 17:21:32 +02:00
Michal Wozniak
70c4965270 Add more test cases for SuccessCriteriaMet
Cleanup error messages in the new code

Add validation for the Job controller fields
2024-07-12 11:22:26 +02:00
Michal Wozniak
fb7704ba03 Delay setting terminal Job conditions until all pods are terminal
Fix the integration test typecheck

Fix after rebase

# Conflicts:
#	pkg/controller/job/job_controller_test.go
2024-07-11 20:54:09 +02:00
Kubernetes Prow Robot
cdcaea687c Merge pull request #125751 from ahg-g/elastic-job
Graduate ElasticIndexedJob to GA
2024-07-11 11:08:24 -07:00
Michal Wozniak
4250d444f8 Cleanup Job controller tests 2024-07-05 14:59:03 +02:00
ahg-g
be410c0dae Graduate ElasticIndexedJob to GA 2024-06-28 17:00:29 +00:00
Kubernetes Prow Robot
c49b140c45 Merge pull request #125175 from dejanzele/feat/count-terminating-for-failed-jobs
Count terminating pods when deleting active pods for failed jobs
2024-06-10 16:56:37 -07:00
Antonio Ojea
6552f2710f use default flags for apiserver on integration tests 2024-06-04 22:09:35 +00:00
Dejan Pejchev
7dd2948620 count terminating pods when deleting active pods for failed jobs 2024-06-04 11:31:00 +02:00
Marek Siarkowicz
3ee8178768 Cleanup defer from SetFeatureGateDuringTest function call 2024-04-24 20:25:29 +02:00
Kubernetes Prow Robot
5639f8f848 Merge pull request #123723 from mimowo/job-managed-by-impl-test
Integration test for change in syncOrphanPod for managedBy jobs
2024-03-08 06:35:36 -08:00
Yuki Iwai
e216742672 Job: Support for the JobSuccessPolicy (alpha)
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-03-08 05:49:09 +09:00
Michal Wozniak
194009fac9 Add integration test for managedBy and cleanup of finalizers 2024-03-07 17:54:16 +01:00
Michał Woźniak
e568a77a93 Support for the Job managedBy field (alpha) (#123273)
* support for the managed-by label in Job

* Use managedBy field instead of managed-by label

* Additional review remarks

* Review remarks 2

* review remarks 3

* Skip cleanup of finalizers for job with custom managedBy

* Drop the performance optimization

* imrpove logs
2024-03-05 09:25:15 -08:00
Kubernetes Prow Robot
50b4cfc414 Merge pull request #123321 from mimowo/job-reset-metrics
Reset metrics in the Job integration test before testing
2024-02-15 10:57:58 -08:00
Michal Wozniak
ab8cdae3b1 Reset metrics in the Job integration test before testing 2024-02-15 14:50:24 +01:00
Michal Wozniak
115dc90633 Increase accuracy of the pods_creation_total metric and improve test exec time 2024-02-15 10:59:01 +01:00
Michal Wozniak
168e016947 Benchmark job with backoff limit per index 2023-10-31 17:35:39 +01:00
Dejan Pejchev
e98c33bfaf switch feature flag to beta for pod replacement policy and add e2e test
update pod replacement policy feature flag comment and refactor the e2e test for pod replacement policy

minor fixes for pod replacement policy and e2e test

fix wrong assertions for pod replacement policy e2e test

more fixes to pod replacement policy e2e test

refactor PodReplacementPolicy e2e test to use finalizers

fix unit tests when pod replacement policy feature flag is promoted to beta

fix podgc controller unit tests when pod replacement feature is enabled

fix lint issue in pod replacement policy e2e test

assert no error in defer function for removing finalizer in pod replacement policy e2e test

implement test using a sh trap for pod replacement policy

reduce sleep after SIGTERM in pod replacement policy e2e test to 5s
2023-10-26 21:50:37 +02:00
Kubernetes Prow Robot
6fed03ea91 Merge pull request #121408 from alculquicondor/merge-job-metric-tests
Remove independent tests for job metrics
2023-10-25 19:02:50 +02:00
Kubernetes Prow Robot
6817e6a7cc Merge pull request #119912 from kannon92/pod-replacement-policy-integration-tests
Add a missing integration test for PodReplacementPolicy
2023-10-25 02:09:49 +02:00
kannon92
aeceec72bb add integration tests 2023-10-24 17:09:40 -04:00
Aldo Culquicondor
97e72d792c Remove independent tests for metrics
Change-Id: Ibefebf95df47c68e6752e85c61fface9f06cbd38
2023-10-24 16:29:08 -04:00
Dejan Pejchev
9e2821d585 revert changes to TestMetricsOnSuccesses for job pods creation total metric 2023-10-24 19:41:14 +02:00
Dejan Pejchev
88c0a8be1b feat: add job_pods_creation_total metric 2023-10-24 17:49:04 +02:00
Dejan Zele Pejchev
f8a4e343a1 Fix tracking of terminating Pods when nothing else changes (#121342)
* cleanup: refactor pod replacement policy integration test into staged assertion

* cleanup: remove typo in job_test.go

* refactor PodReplacementPolicy test and remove test for defaulting the policy

* fix issue with missing update in job controller for terminating status and refactor pod replacement policy integration test

* use t.Cleanup instead of defer in PodReplacementPolicy integration tests

* revert t.Cleanup to defer for reseting feature flag in PodReplacementPolicy integration tests
2023-10-24 15:04:46 +02:00
Kubernetes Prow Robot
1fc3d10f7e Merge pull request #121292 from mimowo/backoff-limit-per-index-metrics
Introduce the job_finished_indexes_total metric
2023-10-20 23:50:57 +02:00
Anton Stuchinskii
34294cd67f locking feature-gate for ready pods job status 2023-10-20 16:08:54 +02:00
Michal Wozniak
b0d04d933b Introduce the job_finished_indexes_total metric 2023-10-20 15:19:04 +02:00
Kevin Hannon
1a41ed394d convert pointer to ptr for sig-apps integration tests 2023-10-19 10:35:38 -04:00
Yuki Iwai
d7556769e7 Job: Replace deprecated wait functions with supported one
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-10-19 00:14:35 +09:00
Kubernetes Prow Robot
613f75926e Merge pull request #121274 from dejanzele/fix/pod-replacement-policy-int-tests
cleanup: improve assertions for Failed PodReplacementPolicy integration test cases
2023-10-17 23:28:48 +02:00
Yuki Iwai
201c30fba8 Job: Handle error returned from AddEventHandler function (#119917)
* Job: Handle error returned from AddEventHandler function

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Use the error message the similar to CronJob

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Clean up error messages

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Put the tesing.T on the second place in the args for the newControllerFromClient function

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Put the testing.T on the second place in the args for the newControllerFromClientWithClock function

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Call t.Helper()

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Put the testing.TB on the second place in the args for the createJobControllerWithSharedInformers function and call tb.Helper() there

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Put the testing.TB on the second place in the args for the startJobControllerAndWaitForCaches function and call tb.Helper() there

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

* Adapt TestFinializerCleanup to the eventhandler error

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

---------

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-10-17 21:28:34 +02:00
Dejan Pejchev
fad4430f9e cleanup: remove redundant logic in PodReplacementPolicy integration tests 2023-10-17 20:30:54 +02:00
Dejan Pejchev
2ccf7e8e49 fix: minor lint issues and redundant check 2023-10-17 20:07:20 +02:00
Dejan Pejchev
056b25dfca fix: improve PodReplacementPolicy integration test case names and update deprecated methods 2023-10-17 19:18:58 +02:00
Dejan Pejchev
e73edf7764 fix: typo in indexed & non-indexed completion policies for failed pod replacement policy integration tests 2023-10-17 18:15:55 +02:00
Dejan Pejchev
bcf1c113f4 cleanup: add new test cases for failed pod replacement policy instead of editing existing ones 2023-10-17 18:04:25 +02:00
Dejan Pejchev
f2b723a130 fix: improve assertion for Failed PodReplacementPolicy integration test cases 2023-10-16 21:16:17 +02:00