Commit Graph

4351 Commits

Author SHA1 Message Date
Natasha Sarkar
eab9197d1a Add observedGeneration and validation to pod status and conditions 2025-03-06 20:08:06 +00:00
Kubernetes Prow Robot
4696667025 Merge pull request #130543 from thockin/error_matcher_and_origin
Fix up ErrorMatcher from feedback
2025-03-06 00:57:52 -08:00
Kubernetes Prow Robot
cd451c6a36 Merge pull request #130282 from natasha41575/podresizevalidation
Clean up preparation for pod subresource updates
2025-03-05 14:41:45 -08:00
Tim Hockin
0a9f492eed Fix up ErrorMatcher from feedback
a) Rename the type and drop the constructor
b) Make MatchErrors() into a Test() method

For followup:

c) Consider making ByType() assumed
d) Consider making ByField() assumed and handle nil as "don't care"
e) Consider making ByValue() assumed and handle nil as "don't care"
2025-03-05 09:52:44 -08:00
Jefftree
05a90bf642 Revert "Add LeaseCandidate v1beta1"
This reverts commit fad4594fd9.
2025-03-01 14:14:25 +00:00
Jefftree
71622aee49 Revert "generated"
This reverts commit 2d10dec3a2.
2025-03-01 14:10:35 +00:00
Kubernetes Prow Robot
0556b20d3d Merge pull request #129435 from googs1025/dra/validation
chore: add more error info for validateResourceSliceSpec
2025-03-01 02:16:55 -08:00
Kubernetes Prow Robot
aad87f2ee9 Merge pull request #130388 from thockin/error_matcher_and_origin
Add an error matcher, convert 2 tests
2025-02-28 17:14:55 -08:00
Kubernetes Prow Robot
d04883c90c Merge pull request #130061 from mimowo/make-backoffperindex-stable
Graduate Backoff Limit Per Index as stable
2025-02-28 13:37:02 -08:00
Natasha Sarkar
f91105a77e fix prep and validation for pod subresource updates 2025-02-28 16:51:10 +00:00
Tim Hockin
c8111709e5 Add an error matcher, convert 2 tests
I fixed up the TestValidateEndpointsCreate path to show the matcher
instead of manual origin checking.

I picked TestValidateTopologySpreadConstraints because it was the last
failing test on my screen when I changed on of the commonly hard-coded
error strings. I fixed exactly those validation errors that were needed
to make this test pass.  Some of the Origin values can be debated.

The `field/testing.Matcher` interface allows tests to configure the
criteria by which they want to match expected and actual errors.  The
hope is that everyone will use Origin for Invalid errors.

There's some collateral impact for tests which use exact-comparisons and
don't expect origins.  These are all candidates for using the matcher.
2025-02-28 08:36:26 -08:00
Kubernetes Prow Robot
ef1c659569 Merge pull request #130291 from Jefftree/cle-beta
LeaseCandidate v1beta1 API
2025-02-28 08:26:56 -08:00
Tim Hockin
6b7e38f018 Fix nits from PR 130355 2025-02-28 00:06:11 -08:00
Kubernetes Prow Robot
803e9d6495 Merge pull request #130355 from yongruilin/validation_origin
validation: Add Origin field to field.Error for more precise error tracking
2025-02-28 00:04:23 -08:00
yongruilin
c7cf852086 test: Add Origin field support to ReplicationController spec.Replicas validation test 2025-02-28 06:56:02 +00:00
yongruilin
07477c656e test: convert ValidateEndpointsCreate to use error Origin field in test
Update ValidateEndpointsCreate validation tests to use the new Origin field for more precise error comparisons. It leverage the Origin field instead of detailed error messages, improving test robustness and readability.

Co-authored-by: Tim Hockin <thockin@google.com>
2025-02-28 06:55:58 +00:00
Jefftree
2d10dec3a2 generated 2025-02-27 17:50:36 +00:00
Jefftree
fad4594fd9 Add LeaseCandidate v1beta1 2025-02-27 15:41:26 +00:00
yongruilin
a488509197 test: Improve error comparison in resource validation tests
Replace manual error logging with cmp.Diff for more precise error comparisons, using cmpopts to ignore Origin field and support UniqueString comparison.
2025-02-27 05:20:54 +00:00
Kubernetes Prow Robot
a18b4a8d97 Merge pull request #129158 from LionelJouin/fix-128831
Fix ResourceClaim status API inconsistency
2025-02-26 20:32:30 -08:00
Michal Wozniak
a91ed902fe Graduate Backoff Limit Per Index as stable
Reenable the JobBackoffLimitPerIndex_Reenabling integration test
2025-02-26 17:06:37 +01:00
Kubernetes Prow Robot
b14fad5adc Merge pull request #130181 from natasha41575/apiserver-generation
start setting pod metadata.generation
2025-02-24 10:48:29 -08:00
Natasha Sarkar
d02401dea9 start setting pod metadata.generation 2025-02-24 16:22:14 +00:00
Kubernetes Prow Robot
0a08529144 Merge pull request #129770 from sunnylovestiramisu/promoteGA
Promote Beta AnyVolumeDataSource to GA
2025-02-21 16:50:26 -08:00
googs1025
f540197768 chore: add more error info for validateResourceSliceSpec 2025-02-22 08:47:58 +08:00
Kubernetes Prow Robot
9bf60d06e0 Merge pull request #129219 from danwinship/networkdevicedata-validation
Require canonicalization of NetworkDeviceData IPs
2025-02-20 16:14:26 -08:00
Kubernetes Prow Robot
f90682bf42 Merge pull request #130183 from tallclair/forbid-memory-limit-decrease
[FG:InPlacePodVerticalScaling] Forbid memory limit decrease
2025-02-20 13:46:33 -08:00
Sunny Song
e986217c21 Update Generated API Code 2025-02-20 21:14:03 +00:00
Dan Winship
2636aa35e3 Require canonicalization of NetworkDeviceData IPs
There's no reason to allow non-standard or non-canonical IP values in
new APIs.
2025-02-20 12:49:03 -05:00
Jefftree
9e27ae2725 Remove gate for leasecandidate strategy 2025-02-19 23:17:29 +00:00
Tim Allclair
e52274a9e2 Don't allow resize policy mutation 2025-02-14 13:15:13 -08:00
Tim Allclair
a1595d9dca Don't allow memory limit decrease unless resize policy is RestartContainer 2025-02-14 12:38:52 -08:00
Adrian Moisey
6d58125111 Bump KEP-4427 : AllowRelaxedDNSSearchValidation to Beta 2025-02-14 19:39:18 +02:00
Michal Wozniak
523ed5498e Fix comment for FailIndex as JobBackoffLimitPerIndex is beta 2025-02-10 09:17:18 +01:00
Kubernetes Prow Robot
0634e21fb5 Merge pull request #128367 from vivzbansal/sidecar-2
[FG:InPlacePodVerticalScaling] Implement resize for sidecar containers
2025-02-05 14:38:15 -08:00
Kubernetes Prow Robot
481cc1a392 Merge pull request #129560 from bart0sh/PR168-DRA-fix-All-allocation-mode
DRA: fix allocation mode `All`
2025-02-05 00:38:16 -08:00
Gunju Kim
0bee0bcaa7 Promote SidecarContainers feature to GA 2025-02-02 17:45:36 +09:00
Ed Bartosh
829fa63b5b DRA: fix allocation mode All
`All` allocation mode should mean 'at least one' for DRA.
Allocation should fail if `All` devices requested and none found.
2025-01-30 16:34:25 +02:00
Kubernetes Prow Robot
814e2c89a8 Merge pull request #128792 from vivzbansal/sidecar-3
Added unit test for resize policy validation check of sidecar containers
2025-01-29 18:23:22 -08:00
vivzbansal
cfa0349159 Update validation code 2025-01-28 00:55:55 +00:00
vivzbansal
c31b1b3332 Resolved some review comments 2025-01-27 19:46:55 +00:00
vivzbansal
5889da1bbc Resolved latest review comments 2025-01-27 19:46:54 +00:00
vivzbansal
242dec3e34 Updated some unit tests and resolved some review comments 2025-01-27 19:46:54 +00:00
vivzbansal
8fa8277908 Added some unit tests 2025-01-27 19:46:54 +00:00
vivzbansal
6c5cf68722 Resolved latest review comments 2025-01-27 19:46:33 +00:00
vivzbansal
6cf5b80c64 Fix some unit test error 2025-01-27 19:42:14 +00:00
vivzbansal
1cf4587277 Fix build error 2025-01-27 19:42:14 +00:00
vivzbansal
1eb966cb45 Added unit test for sidecar containers in TestValidatePodResize 2025-01-27 19:42:13 +00:00
vivzbansal
a0d3cb0a2c Added proper validation msg when non-sidecar containers are resized 2025-01-27 19:42:13 +00:00
vivzbansal
591b0f547a Fix issue of pod spec mismatch if there is any non-restarble init container present 2025-01-27 19:42:13 +00:00