Tim Allclair
e52274a9e2
Don't allow resize policy mutation
2025-02-14 13:15:13 -08:00
Tim Allclair
a1595d9dca
Don't allow memory limit decrease unless resize policy is RestartContainer
2025-02-14 12:38:52 -08:00
vivzbansal
cfa0349159
Update validation code
2025-01-28 00:55:55 +00:00
vivzbansal
c31b1b3332
Resolved some review comments
2025-01-27 19:46:55 +00:00
vivzbansal
5889da1bbc
Resolved latest review comments
2025-01-27 19:46:54 +00:00
vivzbansal
8fa8277908
Added some unit tests
2025-01-27 19:46:54 +00:00
vivzbansal
1cf4587277
Fix build error
2025-01-27 19:42:14 +00:00
vivzbansal
a0d3cb0a2c
Added proper validation msg when non-sidecar containers are resized
2025-01-27 19:42:13 +00:00
vivzbansal
591b0f547a
Fix issue of pod spec mismatch if there is any non-restarble init container present
2025-01-27 19:42:13 +00:00
vivzbansal
3885d2f8ab
Added sidecar support in ValidatePodResize and dropNonResizeUpdates
2025-01-27 19:42:13 +00:00
vivzbansal
cdddaed841
Added sidecar support in and
2025-01-27 19:42:13 +00:00
vivzbansal
d1fac494f4
resolve merge conflicts
2025-01-27 19:42:13 +00:00
Davanum Srinivas
4e05bc20db
Linter to ensure go-cmp/cmp is used ONLY in tests
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com >
2025-01-24 20:49:14 -05:00
Kubernetes Prow Robot
7a504aa97b
Merge pull request #129174 from RyanAoh/fix-115896
...
Remove the limitation on exposing port 10250 externally
2024-12-13 01:48:32 +01:00
Aohan Yang
e8087b3f6a
Remove the limitation on exposing port 10250 externally
2024-12-12 19:45:19 +08:00
AxeZhan
ae11c7deb1
DisallowInvalidLabelValueInNodeSelector
2024-12-12 15:06:14 +08:00
AxeZhan
3075a9ae96
DRA API: validate node selector labels
...
Previously, ValidateNodeSelector did not check that labels are valid. Now it
does for resource.k8s.io, regardless whether an object already was created with
invalid labels in an earlier Kubernetes release. Theoretically this is a
breaking change and could cause problems during an upgrade, but that is highly
unlikely in practice.
In contrast to node affinity, DRA does not ignore parse errors
(= uses NewNodeSelector, not NewLazyErrorNodeSelector), so invalid labels would
have been found instead of being silently ignored.
Even if some object has invalid labels, this only affects an alpha -> beta
upgrade which isn't guaranteed to work seamlessly.
2024-11-22 09:10:02 +01:00
vivzbansal
95591abd02
Add AllowSidecarResizePolicy to relax resize policy validation check of sidecar containers
2024-11-12 05:08:51 +00:00
Kubernetes Prow Robot
2691a29eac
Merge pull request #128683 from AnishShah/validation
...
[FG:InPlacePodVerticalScaling] Disallow removing requests & limits for Burstable pods.
2024-11-08 09:08:43 +00:00
Kubernetes Prow Robot
c25f5eefe4
Merge pull request #128407 from ndixita/pod-level-resources
...
[PodLevelResources] Pod Level Resources Feature Alpha
2024-11-08 07:10:50 +00:00
Anish Shah
7680f0f293
api: reject removing requsets & limits for Burstable pods.
2024-11-07 21:06:54 -08:00
ndixita
8a8dc27b4e
Adding the logic to validate pod-level resources as following:
...
1. The effective container requests cannot be greater than pod-level requests
2. Inidividual container limits cannot be greater than pod-level limits
3. Only CPU & Memory are supported at pod-level
4. Inplace container resources updates are not supported if pod-level resources are set
Note: effective container requests cannot be greater than pod-level limits is supported by transitivity. Effective container requests <= pod-level requests && pod-level requests <= pod-level limits; Therefore effective container requests <= pod-level limits
Signed-off-by: ndixita <ndixita@google.com >
2024-11-08 03:00:54 +00:00
Kubernetes Prow Robot
46b3d9b320
Merge pull request #128186 from sreeram-venkitesh/117767-in-place-pod-vertical-scaling-version-skew
...
Updated version skew strategy for InPlacePodVerticalScaling
2024-11-08 02:21:14 +00:00
Kubernetes Prow Robot
9660e5c4cd
Merge pull request #127360 from knight42/feat/split-stdout-stderr-server-side
...
API: add a new `Stream` field to `PodLogOptions`
2024-11-07 19:44:45 +00:00
Sreeram Venkitesh
8f1e69bbb0
Fix verify-gofmt.sh
2024-11-07 13:28:40 +05:30
Lan Liang
6e5a3cde50
Remove PodHostIPs feature gates.
...
Signed-off-by: Lan Liang <gcslyp@gmail.com >
2024-11-06 23:10:36 -08:00
Sreeram Venkitesh
385d2b198c
Fixes from review, updated tests cases
2024-11-07 11:34:58 +05:30
Sreeram Venkitesh
7d1d7182f3
Update function name and remove feature gate check
2024-11-07 11:29:11 +05:30
Sreeram Venkitesh
4dae42a796
Updated version skew strategy for InPlacePodVerticalScaling
2024-11-07 11:29:07 +05:30
Anish Shah
207842d3e0
drop InPlacePodVerticalScaling support in windows
2024-11-06 12:57:55 -08:00
Kubernetes Prow Robot
96250d4411
Merge pull request #124918 from SergeyKanzhelev/commentIgnoringBadStatuses
...
added a comment that statuses lists are not being validated
2024-11-06 20:09:29 +00:00
Jian Zeng
b9228836e1
feat: update validation helpers
...
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com >
2024-11-06 21:27:12 +08:00
Kubernetes Prow Robot
648717cc74
Merge pull request #128266 from AnishShah/resize-subresource
...
[FG:InPlacePodVerticalScaling] Introduce /resize subresource to request pod resource resizing
2024-11-06 06:59:29 +00:00
Kubernetes Prow Robot
a50b4e52a9
Merge pull request #128553 from thockin/master
...
Validation: merge TooLong and TooLongMaxLen
2024-11-06 04:19:43 +00:00
Anish Shah
332d794559
remove redundant validation check for pod resize
2024-11-06 01:33:15 +00:00
Anish Shah
832d7f7dc2
apply feedback
2024-11-06 01:33:15 +00:00
Anish Shah
0a80c5ecb7
better variable names
2024-11-06 01:33:15 +00:00
Anish Shah
7ac302b47a
test: cleanup validation tests
2024-11-06 01:33:15 +00:00
Anish Shah
ce0f4597d3
fix error message for pod resize validation failure
2024-11-06 01:33:14 +00:00
Anish Shah
2bf1f2349c
validate resize request
...
We validate resize request by ensuring that pod QoS is unchanged and
only cpu and memory resources and resize policies are mutated.
2024-11-06 01:33:14 +00:00
Tim Hockin
c8eeb486f4
Call-site comments: the "" arg to TooLong is unused
2024-11-05 15:10:24 -08:00
Tim Hockin
8a7af90300
Clarify that value arg to field.TooLong is unused
2024-11-05 15:10:23 -08:00
Tim Hockin
4d0e1c8fd4
Kill TooLongMaxLength() in favor of TooLong()
2024-11-05 15:10:22 -08:00
Kubernetes Prow Robot
97c79df18f
Merge pull request #127981 from jsafrane/selinux-changepolicy
...
1710: Implement SELinuxChangePolicy
2024-11-04 22:09:29 +00:00
Sergey Kanzhelev
01851b89f4
added a comment that statuses lists are not being validated
2024-11-03 06:28:42 +00:00
Kubernetes Prow Robot
6bc0768c62
Merge pull request #127744 from carlory/fix-126662
...
Tighten validation on the qosClass field of pod status
2024-11-01 22:33:27 +00:00
Jan Safranek
6ca7b959e4
Add SELinuxChangePolicy validation
2024-11-01 12:46:34 +01:00
carlory
9cb7d58b3c
Tighten validation on the qosClass field of pod status
2024-11-01 10:36:03 +08:00
Kubernetes Prow Robot
b337f048db
Merge pull request #127094 from sreeram-venkitesh/4818-allow-zero-for-prestop-hook
...
KEP-4818: Relaxed validation for allowing zero in PreStop hook sleep action
2024-10-31 20:25:26 +00:00
Kubernetes Prow Robot
86b99869cb
Merge pull request #128299 from SergeyKanzhelev/updateDHS
...
Update Device Health fields description for KEP-4680
2024-10-28 22:19:01 +00:00
