/* Copyright 2020 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "bytes" "context" "fmt" "reflect" "sync" "testing" "time" "golang.org/x/sync/singleflight" authenticationv1 "k8s.io/api/authentication/v1" v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/rand" "k8s.io/client-go/tools/cache" credentialproviderapi "k8s.io/kubelet/pkg/apis/credentialprovider" credentialproviderv1 "k8s.io/kubelet/pkg/apis/credentialprovider/v1" credentialproviderv1alpha1 "k8s.io/kubelet/pkg/apis/credentialprovider/v1alpha1" credentialproviderv1beta1 "k8s.io/kubelet/pkg/apis/credentialprovider/v1beta1" "k8s.io/kubernetes/pkg/credentialprovider" kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config" "k8s.io/utils/clock" testingclock "k8s.io/utils/clock/testing" ) type fakeExecPlugin struct { cacheKeyType credentialproviderapi.PluginCacheKeyType cacheDuration time.Duration auth map[string]credentialproviderapi.AuthConfig } // countingFakeExecPlugin is a fakeExecPlugin that counts the number of times ExecPlugin is called // and sleeps for a second to simulate a slow plugin so that concurrent calls exercise the singleflight. // This is used to test the singleflight behavior in the perPodPluginProvider. type countingFakeExecPlugin struct { fakeExecPlugin mu sync.Mutex count int } func (f *fakeExecPlugin) ExecPlugin(ctx context.Context, image, serviceAccountToken string, serviceAccountAnnotations map[string]string) (*credentialproviderapi.CredentialProviderResponse, error) { return &credentialproviderapi.CredentialProviderResponse{ CacheKeyType: f.cacheKeyType, CacheDuration: &metav1.Duration{ Duration: f.cacheDuration, }, Auth: f.auth, }, nil } func (f *countingFakeExecPlugin) ExecPlugin(ctx context.Context, image, serviceAccountToken string, serviceAccountAnnotations map[string]string) (*credentialproviderapi.CredentialProviderResponse, error) { f.mu.Lock() defer f.mu.Unlock() f.count++ // make the exec plugin slow so concurrent calls exercise the singleflight time.Sleep(time.Second) return f.fakeExecPlugin.ExecPlugin(ctx, image, serviceAccountToken, serviceAccountAnnotations) } func TestSingleflightProvide(t *testing.T) { tclock := clock.RealClock{} // Set up the counting fakeExecPlugin execPlugin := &countingFakeExecPlugin{ fakeExecPlugin: fakeExecPlugin{ cacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "test.registry.io": {Username: "user", Password: "password"}, }, }, } // Set up perPodPluginProvider pluginProvider := &pluginProvider{ plugin: execPlugin, group: singleflight.Group{}, clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"test.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), } dynamicProvider := &perPodPluginProvider{ provider: pluginProvider, podName: "pod-name", podNamespace: "pod-namespace", podUID: "pod-uid", serviceAccountName: "service-account-name", } image := "test.registry.io" var wg sync.WaitGroup const concurrentCalls = 5 results := make([]credentialprovider.DockerConfig, concurrentCalls) // Test with serviceAccountProvider as nil for i := 0; i < concurrentCalls; i++ { wg.Add(1) go func(i int) { defer wg.Done() result := dynamicProvider.Provide(image) results[i] = result }(i) } wg.Wait() // Check that ExecPlugin was called only once if execPlugin.count != 1 { t.Errorf("expected ExecPlugin to be called once, but was called %d times", execPlugin.count) } // Repeat the test with a non-nil serviceAccountProvider if applicable pluginProvider.serviceAccountProvider = &serviceAccountProvider{ audience: "audience", getServiceAccountFunc: func(namespace, name string) (*v1.ServiceAccount, error) { return &v1.ServiceAccount{ ObjectMeta: metav1.ObjectMeta{ Name: name, Namespace: namespace, UID: "service-account-uid", }, }, nil }, getServiceAccountTokenFunc: func(namespace, name string, tr *authenticationv1.TokenRequest) (*authenticationv1.TokenRequest, error) { return &authenticationv1.TokenRequest{}, nil }, } execPlugin.count = 0 // Reset count for the next test for i := 0; i < concurrentCalls; i++ { wg.Add(1) go func(i int) { defer wg.Done() result := dynamicProvider.Provide(image) results[i] = result }(i) } wg.Wait() // Verify single ExecPlugin call again if execPlugin.count != 1 { t.Errorf("expected ExecPlugin to be called once with serviceAccountProvider, but was called %d times", execPlugin.count) } // Repeat the test with different serviceaccount token (same serviceaccount but different pod) pluginProvider.serviceAccountProvider.getServiceAccountTokenFunc = func(namespace, name string, tr *authenticationv1.TokenRequest) (*authenticationv1.TokenRequest, error) { return &authenticationv1.TokenRequest{Status: authenticationv1.TokenRequestStatus{Token: rand.String(10)}}, nil } execPlugin.count = 0 // Reset count for the next test for i := 0; i < concurrentCalls; i++ { wg.Add(1) go func(i int) { defer wg.Done() result := dynamicProvider.Provide(image) results[i] = result }(i) } wg.Wait() // Check that ExecPlugin was called 5 times with different serviceaccount tokens if execPlugin.count != concurrentCalls { t.Errorf("expected ExecPlugin to be called %d times with different serviceaccount tokens, but was called %d times", concurrentCalls, execPlugin.count) } } func Test_Provide(t *testing.T) { tclock := clock.RealClock{} testcases := []struct { name string pluginProvider *perPodPluginProvider image string dockerconfig credentialprovider.DockerConfig }{ { name: "exact image match, with Registry cache key", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"test.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "test.registry.io": { Username: "user", Password: "password", }, }, }, }, }, image: "test.registry.io/foo/bar", dockerconfig: credentialprovider.DockerConfig{ "test.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, }, }, { name: "exact image match, with Image cache key", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"test.registry.io/foo/bar"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.ImagePluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "test.registry.io/foo/bar": { Username: "user", Password: "password", }, }, }, }, }, image: "test.registry.io/foo/bar", dockerconfig: credentialprovider.DockerConfig{ "test.registry.io/foo/bar": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, }, }, { name: "exact image match, with Global cache key", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"test.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.GlobalPluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "test.registry.io": { Username: "user", Password: "password", }, }, }, }, }, image: "test.registry.io", dockerconfig: credentialprovider.DockerConfig{ "test.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, }, }, { name: "wild card image match, with Registry cache key", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io:8080"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io:8080": { Username: "user", Password: "password", }, }, }, }, }, image: "test.registry.io:8080/foo", dockerconfig: credentialprovider.DockerConfig{ "*.registry.io:8080": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, }, }, { name: "wild card image match, with Image cache key", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.ImagePluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "*.*.registry.io": { Username: "user", Password: "password", }, }, }, }, }, image: "foo.bar.registry.io/foo/bar", dockerconfig: credentialprovider.DockerConfig{ "*.*.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, }, }, { name: "wild card image match, with Global cache key", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.GlobalPluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, }, }, image: "test.registry.io", dockerconfig: credentialprovider.DockerConfig{ "*.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, }, }, } for _, testcase := range testcases { testcase := testcase t.Run(testcase.name, func(t *testing.T) { t.Parallel() dockerconfig := testcase.pluginProvider.Provide(testcase.image) if !reflect.DeepEqual(dockerconfig, testcase.dockerconfig) { t.Logf("actual docker config: %v", dockerconfig) t.Logf("expected docker config: %v", testcase.dockerconfig) t.Error("unexpected docker config") } }) } } // This test calls Provide in parallel for different registries and images // The purpose of this is to detect any race conditions while cache rw. func Test_ProvideParallel(t *testing.T) { tclock := clock.RealClock{} testcases := []struct { name string registry string }{ { name: "provide for registry 1", registry: "test1.registry.io", }, { name: "provide for registry 2", registry: "test2.registry.io", }, { name: "provide for registry 3", registry: "test3.registry.io", }, { name: "provide for registry 4", registry: "test4.registry.io", }, } pluginProvider := &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"test1.registry.io", "test2.registry.io", "test3.registry.io", "test4.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheDuration: time.Minute * 1, cacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, auth: map[string]credentialproviderapi.AuthConfig{ "test.registry.io": { Username: "user", Password: "password", }, }, }, }, } dockerconfig := credentialprovider.DockerConfig{ "test.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, } for _, testcase := range testcases { testcase := testcase t.Run(testcase.name, func(t *testing.T) { t.Parallel() var wg sync.WaitGroup wg.Add(5) for i := 0; i < 5; i++ { go func(w *sync.WaitGroup) { image := fmt.Sprintf(testcase.registry+"/%s", rand.String(5)) dockerconfigResponse := pluginProvider.Provide(image) if !reflect.DeepEqual(dockerconfigResponse, dockerconfig) { t.Logf("actual docker config: %v", dockerconfigResponse) t.Logf("expected docker config: %v", dockerconfig) t.Error("unexpected docker config") } w.Done() }(&wg) } wg.Wait() }) } } func Test_getCachedCredentials(t *testing.T) { fakeClock := testingclock.NewFakeClock(time.Now()) p := &pluginProvider{ clock: fakeClock, lastCachePurge: fakeClock.Now(), cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: fakeClock}), plugin: &fakeExecPlugin{}, } testcases := []struct { name string step time.Duration cacheEntry cacheEntry expectedResponse credentialprovider.DockerConfig keyLength int getKey string }{ { name: "It should return not expired credential", step: 1 * time.Second, keyLength: 1, getKey: "image1", expectedResponse: map[string]credentialprovider.DockerConfigEntry{ "image1": { Username: "user1", Password: "pass1", }, }, cacheEntry: cacheEntry{ key: "\x00\x06image1\x00\x00", expiresAt: fakeClock.Now().Add(1 * time.Minute), credentials: map[string]credentialprovider.DockerConfigEntry{ "image1": { Username: "user1", Password: "pass1", }, }, }, }, { name: "It should not return expired credential", step: 2 * time.Minute, getKey: "image2", keyLength: 1, cacheEntry: cacheEntry{ key: "\x00\x06image2\x00\x00", expiresAt: fakeClock.Now(), credentials: map[string]credentialprovider.DockerConfigEntry{ "image2": { Username: "user2", Password: "pass2", }, }, }, }, { name: "It should delete expired credential during purge", step: 18 * time.Minute, keyLength: 0, // while get call for random, cache purge will be called and it will delete expired // image3 credentials. We cannot use image3 as getKey here, as it will get deleted during // get only, we will not be able verify the purge call. getKey: "random", cacheEntry: cacheEntry{ key: "\x00\x06image3\x00\x00", expiresAt: fakeClock.Now().Add(2 * time.Minute), credentials: map[string]credentialprovider.DockerConfigEntry{ "image3": { Username: "user3", Password: "pass3", }, }, }, }, } for _, tc := range testcases { t.Run(tc.name, func(t *testing.T) { p.cache.Add(&tc.cacheEntry) fakeClock.Step(tc.step) // getCachedCredentials returns unexpired credentials. res, _, err := p.getCachedCredentials(tc.getKey, "") if err != nil { t.Errorf("Unexpected error %v", err) } if !reflect.DeepEqual(res, tc.expectedResponse) { t.Logf("response %v", res) t.Logf("expected response %v", tc.expectedResponse) t.Errorf("Unexpected response") } // Listkeys returns all the keys present in cache including expired keys. if len(p.cache.ListKeys()) != tc.keyLength { t.Errorf("Unexpected cache key length") } }) } } func Test_getCachedCredentials_pluginUsingServiceAccount(t *testing.T) { fakeClock := testingclock.NewFakeClock(time.Now()) p := &pluginProvider{ clock: fakeClock, lastCachePurge: fakeClock.Now(), cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: fakeClock}), plugin: &fakeExecPlugin{}, serviceAccountProvider: &serviceAccountProvider{ audience: "audience", getServiceAccountFunc: func(namespace, name string) (*v1.ServiceAccount, error) { return &v1.ServiceAccount{ ObjectMeta: metav1.ObjectMeta{ Name: name, Namespace: namespace, UID: "service-account-uid", }, }, nil }, getServiceAccountTokenFunc: func(namespace, name string, tr *authenticationv1.TokenRequest) (*authenticationv1.TokenRequest, error) { return &authenticationv1.TokenRequest{}, nil }, }, } serviceAccountCacheKey, err := generateServiceAccountCacheKey("namespace", "serviceAccountName", "service-account-uid", map[string]string{"prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2"}) if err != nil { t.Fatalf("Unexpected error %v", err) } cacheKey1, err := generateCacheKey("image1", serviceAccountCacheKey) if err != nil { t.Fatalf("Unexpected error %v", err) } cacheKey2, err := generateCacheKey("image2", serviceAccountCacheKey) if err != nil { t.Fatalf("Unexpected error %v", err) } testcases := []struct { name string step time.Duration cacheEntry cacheEntry expectedResponse credentialprovider.DockerConfig keyLength int getKey string }{ { name: "It should return not expired credential", step: 1 * time.Second, keyLength: 1, getKey: "image1", expectedResponse: map[string]credentialprovider.DockerConfigEntry{ "image1": { Username: "user1", Password: "pass1", }, }, cacheEntry: cacheEntry{ key: cacheKey1, expiresAt: fakeClock.Now().Add(1 * time.Minute), credentials: map[string]credentialprovider.DockerConfigEntry{ "image1": { Username: "user1", Password: "pass1", }, }, }, }, { name: "It should not return expired credential", step: 2 * time.Minute, getKey: "image2", keyLength: 1, cacheEntry: cacheEntry{ key: cacheKey2, expiresAt: fakeClock.Now(), credentials: map[string]credentialprovider.DockerConfigEntry{ "image2": { Username: "user2", Password: "pass2", }, }, }, }, { name: "It should delete expired credential during purge", step: 18 * time.Minute, keyLength: 0, // while get call for random, cache purge will be called, and it will delete expired // image3 credentials. We cannot use image3 as getKey here, as it will get deleted during // get only, we will not be able to verify the purge call. getKey: "random", cacheEntry: cacheEntry{ key: "image3", expiresAt: fakeClock.Now().Add(2 * time.Minute), credentials: map[string]credentialprovider.DockerConfigEntry{ "image3": { Username: "user3", Password: "pass3", }, }, }, }, } for _, tc := range testcases { t.Run(tc.name, func(t *testing.T) { if err := p.cache.Add(&tc.cacheEntry); err != nil { t.Fatalf("Unexpected error %v", err) } fakeClock.Step(tc.step) // getCachedCredentials returns unexpired credentials. res, _, err := p.getCachedCredentials(tc.getKey, serviceAccountCacheKey) if err != nil { t.Errorf("Unexpected error %v", err) } if !reflect.DeepEqual(res, tc.expectedResponse) { t.Logf("response %v", res) t.Logf("expected response %v", tc.expectedResponse) t.Errorf("Unexpected response") } // Listkeys returns all the keys present in cache including expired keys. if len(p.cache.ListKeys()) != tc.keyLength { t.Errorf("Unexpected cache key length") } }) } } func Test_encodeRequest(t *testing.T) { testcases := []struct { name string apiVersion schema.GroupVersion request *credentialproviderapi.CredentialProviderRequest expectedData []byte expectedErr bool }{ { name: "successful with v1alpha1", apiVersion: credentialproviderv1alpha1.SchemeGroupVersion, request: &credentialproviderapi.CredentialProviderRequest{ Image: "test.registry.io/foobar", }, expectedData: []byte(`{"kind":"CredentialProviderRequest","apiVersion":"credentialprovider.kubelet.k8s.io/v1alpha1","image":"test.registry.io/foobar"} `), expectedErr: false, }, { name: "successful with v1beta1", apiVersion: credentialproviderv1beta1.SchemeGroupVersion, request: &credentialproviderapi.CredentialProviderRequest{ Image: "test.registry.io/foobar", }, expectedData: []byte(`{"kind":"CredentialProviderRequest","apiVersion":"credentialprovider.kubelet.k8s.io/v1beta1","image":"test.registry.io/foobar"} `), expectedErr: false, }, { name: "successful with v1", apiVersion: credentialproviderv1.SchemeGroupVersion, request: &credentialproviderapi.CredentialProviderRequest{ Image: "test.registry.io/foobar", }, expectedData: []byte(`{"kind":"CredentialProviderRequest","apiVersion":"credentialprovider.kubelet.k8s.io/v1","image":"test.registry.io/foobar"} `), expectedErr: false, }, { name: "successful with v1, with service account token and annotations", apiVersion: credentialproviderv1.SchemeGroupVersion, request: &credentialproviderapi.CredentialProviderRequest{ Image: "test.registry.io/foobar", ServiceAccountToken: "service-account-token", ServiceAccountAnnotations: map[string]string{ "domain.io/annotation1": "value1", }, }, expectedData: []byte(`{"kind":"CredentialProviderRequest","apiVersion":"credentialprovider.kubelet.k8s.io/v1","image":"test.registry.io/foobar","serviceAccountToken":"service-account-token","serviceAccountAnnotations":{"domain.io/annotation1":"value1"}} `), expectedErr: false, }, } for _, testcase := range testcases { t.Run(testcase.name, func(t *testing.T) { mediaType := "application/json" info, ok := runtime.SerializerInfoForMediaType(codecs.SupportedMediaTypes(), mediaType) if !ok { t.Fatalf("unsupported media type: %s", mediaType) } e := &execPlugin{ encoder: codecs.EncoderForVersion(info.Serializer, testcase.apiVersion), } data, err := e.encodeRequest(testcase.request) if err != nil && !testcase.expectedErr { t.Fatalf("unexpected error: %v", err) } if err == nil && testcase.expectedErr { t.Fatalf("expected error %v but got nil", testcase.expectedErr) } if !reflect.DeepEqual(data, testcase.expectedData) { t.Errorf("actual encoded data: %v", string(data)) t.Errorf("expected encoded data: %v", string(testcase.expectedData)) t.Errorf("unexpected encoded response") } }) } } func Test_decodeResponse(t *testing.T) { testcases := []struct { name string data []byte expectedResponse *credentialproviderapi.CredentialProviderResponse expectedErr bool }{ { name: "success with v1", data: []byte(`{"kind":"CredentialProviderResponse","apiVersion":"credentialprovider.kubelet.k8s.io/v1","cacheKeyType":"Registry","cacheDuration":"1m","auth":{"*.registry.io":{"username":"user","password":"password"}}}`), expectedResponse: &credentialproviderapi.CredentialProviderResponse{ CacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, CacheDuration: &metav1.Duration{ Duration: time.Minute, }, Auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, expectedErr: false, }, { name: "success with v1beta1", data: []byte(`{"kind":"CredentialProviderResponse","apiVersion":"credentialprovider.kubelet.k8s.io/v1beta1","cacheKeyType":"Registry","cacheDuration":"1m","auth":{"*.registry.io":{"username":"user","password":"password"}}}`), expectedResponse: &credentialproviderapi.CredentialProviderResponse{ CacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, CacheDuration: &metav1.Duration{ Duration: time.Minute, }, Auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, expectedErr: false, }, { name: "success with v1alpha1", data: []byte(`{"kind":"CredentialProviderResponse","apiVersion":"credentialprovider.kubelet.k8s.io/v1alpha1","cacheKeyType":"Registry","cacheDuration":"1m","auth":{"*.registry.io":{"username":"user","password":"password"}}}`), expectedResponse: &credentialproviderapi.CredentialProviderResponse{ CacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, CacheDuration: &metav1.Duration{ Duration: time.Minute, }, Auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, expectedErr: false, }, { name: "wrong Kind", data: []byte(`{"kind":"WrongKind","apiVersion":"credentialprovider.kubelet.k8s.io/v1beta1","cacheKeyType":"Registry","cacheDuration":"1m","auth":{"*.registry.io":{"username":"user","password":"password"}}}`), expectedResponse: nil, expectedErr: true, }, { name: "wrong Group", data: []byte(`{"kind":"CredentialProviderResponse","apiVersion":"foobar.kubelet.k8s.io/v1beta1","cacheKeyType":"Registry","cacheDuration":"1m","auth":{"*.registry.io":{"username":"user","password":"password"}}}`), expectedResponse: nil, expectedErr: true, }, } for _, testcase := range testcases { t.Run(testcase.name, func(t *testing.T) { e := &execPlugin{} decodedResponse, err := e.decodeResponse(testcase.data) if err != nil && !testcase.expectedErr { t.Fatalf("unexpected error: %v", err) } if err == nil && testcase.expectedErr { t.Fatalf("expected error %v but not nil", testcase.expectedErr) } if !reflect.DeepEqual(decodedResponse, testcase.expectedResponse) { t.Logf("actual decoded response: %#v", decodedResponse) t.Logf("expected decoded response: %#v", testcase.expectedResponse) t.Errorf("unexpected decoded response") } }) } } func Test_RegistryCacheKeyType(t *testing.T) { tclock := clock.RealClock{} tests := []struct { name string pluginProvider *perPodPluginProvider expectedCacheKeys func(p *pluginProvider) []string }{ { name: "plugin not using service account token", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, cacheDuration: time.Hour, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, }, podName: "pod-name", podNamespace: "namespace", podUID: types.UID("pod-uid"), serviceAccountName: "service-account-name", }, expectedCacheKeys: func(p *pluginProvider) []string { return []string{"\x00\x10test.registry.io\x00\x00"} }, }, { name: "plugin using service account token", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), serviceAccountProvider: &serviceAccountProvider{ audience: "audience", requiredServiceAccountAnnotationKeys: []string{"prefix.io/annotation-1", "prefix.io/annotation-2"}, getServiceAccountFunc: func(namespace, name string) (*v1.ServiceAccount, error) { return &v1.ServiceAccount{ ObjectMeta: metav1.ObjectMeta{ Namespace: namespace, Name: name, UID: "service-account-uid", Annotations: map[string]string{ "prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2", }, }, }, nil }, getServiceAccountTokenFunc: func(namespace, name string, tr *authenticationv1.TokenRequest) (*authenticationv1.TokenRequest, error) { return &authenticationv1.TokenRequest{}, nil }, }, plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.RegistryPluginCacheKeyType, cacheDuration: time.Hour, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, }, podName: "pod-name", podNamespace: "namespace", podUID: types.UID("pod-uid"), serviceAccountName: "service-account-name", }, expectedCacheKeys: func(p *pluginProvider) []string { serviceAccountCacheKey, err := generateServiceAccountCacheKey("namespace", "service-account-name", "service-account-uid", map[string]string{"prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2"}) if err != nil { t.Fatalf("Unexpected error %v", err) } cacheKey, err := generateCacheKey("test.registry.io", serviceAccountCacheKey) if err != nil { t.Fatalf("unexpected error: %v", err) } return []string{cacheKey} }, }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { expectedDockerConfig := credentialprovider.DockerConfig{ "*.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, } dockerConfig := test.pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } cacheKeys := test.pluginProvider.provider.cache.ListKeys() expectedCacheKeys := test.expectedCacheKeys(test.pluginProvider.provider) if !reflect.DeepEqual(cacheKeys, expectedCacheKeys) { t.Logf("actual cache keys: %#v", cacheKeys) t.Logf("expected cache keys: %v", expectedCacheKeys) t.Error("unexpected cache keys") } // nil out the exec plugin, this will test whether credentialproviderapi are fetched // from cache, otherwise Provider should panic test.pluginProvider.provider.plugin = nil dockerConfig = test.pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } }) } } func Test_ImageCacheKeyType(t *testing.T) { tclock := clock.RealClock{} tests := []struct { name string pluginProvider *perPodPluginProvider expectedCacheKeys func(p *pluginProvider) []string }{ { name: "plugin not using service account token", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.ImagePluginCacheKeyType, cacheDuration: time.Hour, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, }, podName: "pod-name", podNamespace: "namespace", podUID: types.UID("pod-uid"), serviceAccountName: "service-account-name", }, expectedCacheKeys: func(p *pluginProvider) []string { return []string{"\x00\x18test.registry.io/foo/bar\x00\x00"} }, }, { name: "plugin using service account token", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.ImagePluginCacheKeyType, cacheDuration: time.Hour, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, serviceAccountProvider: &serviceAccountProvider{ audience: "audience", requiredServiceAccountAnnotationKeys: []string{"prefix.io/annotation-1", "prefix.io/annotation-2"}, getServiceAccountFunc: func(namespace, name string) (*v1.ServiceAccount, error) { return &v1.ServiceAccount{ ObjectMeta: metav1.ObjectMeta{ Namespace: namespace, Name: name, UID: "service-account-uid", Annotations: map[string]string{ "prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2", }, }, }, nil }, getServiceAccountTokenFunc: func(namespace, name string, tr *authenticationv1.TokenRequest) (*authenticationv1.TokenRequest, error) { return &authenticationv1.TokenRequest{}, nil }, }, }, podName: "pod-name", podNamespace: "namespace", podUID: types.UID("pod-uid"), serviceAccountName: "service-account-name", }, expectedCacheKeys: func(p *pluginProvider) []string { serviceAccountCacheKey, err := generateServiceAccountCacheKey("namespace", "service-account-name", "service-account-uid", map[string]string{"prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2"}) if err != nil { t.Fatalf("Unexpected error %v", err) } cacheKey, err := generateCacheKey("test.registry.io/foo/bar", serviceAccountCacheKey) if err != nil { t.Fatalf("unexpected error: %v", err) } return []string{cacheKey} }, }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { expectedDockerConfig := credentialprovider.DockerConfig{ "*.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, } dockerConfig := test.pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } cacheKeys := test.pluginProvider.provider.cache.ListKeys() expectedCacheKeys := test.expectedCacheKeys(test.pluginProvider.provider) if !reflect.DeepEqual(cacheKeys, expectedCacheKeys) { t.Logf("actual cache keys: %#v", cacheKeys) t.Logf("expected cache keys: %v", expectedCacheKeys) t.Error("unexpected cache keys") } // nil out the exec plugin, this will test whether credentialproviderapi are fetched // from cache, otherwise Provider should panic test.pluginProvider.provider.plugin = nil dockerConfig = test.pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } }) } } func Test_GlobalCacheKeyType(t *testing.T) { tclock := clock.RealClock{} tests := []struct { name string pluginProvider *perPodPluginProvider expectedCacheKeys func(p *pluginProvider) []string }{ { name: "plugin not using service account token", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.GlobalPluginCacheKeyType, cacheDuration: time.Hour, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, }, podName: "pod-name", podNamespace: "namespace", podUID: types.UID("pod-uid"), serviceAccountName: "service-account-name", }, expectedCacheKeys: func(p *pluginProvider) []string { return []string{"\x00\x06global\x00\x00"} }, }, { name: "plugin using service account token", pluginProvider: &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.GlobalPluginCacheKeyType, cacheDuration: time.Hour, auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, serviceAccountProvider: &serviceAccountProvider{ audience: "audience", requiredServiceAccountAnnotationKeys: []string{"prefix.io/annotation-1", "prefix.io/annotation-2"}, getServiceAccountFunc: func(namespace, name string) (*v1.ServiceAccount, error) { return &v1.ServiceAccount{ ObjectMeta: metav1.ObjectMeta{ Namespace: namespace, Name: name, UID: "service-account-uid", Annotations: map[string]string{ "prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2", }, }, }, nil }, getServiceAccountTokenFunc: func(namespace, name string, tr *authenticationv1.TokenRequest) (*authenticationv1.TokenRequest, error) { return &authenticationv1.TokenRequest{}, nil }, }, }, podName: "pod-name", podNamespace: "namespace", podUID: types.UID("pod-uid"), serviceAccountName: "service-account-name", }, expectedCacheKeys: func(p *pluginProvider) []string { serviceAccountCacheKey, err := generateServiceAccountCacheKey("namespace", "service-account-name", "service-account-uid", map[string]string{"prefix.io/annotation-1": "value1", "prefix.io/annotation-2": "value2"}) if err != nil { t.Fatalf("Unexpected error %v", err) } cacheKey, err := generateCacheKey(globalCacheKey, serviceAccountCacheKey) if err != nil { t.Fatalf("unexpected error: %v", err) } return []string{cacheKey} }, }, } for _, test := range tests { t.Run(test.name, func(t *testing.T) { expectedDockerConfig := credentialprovider.DockerConfig{ "*.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, } dockerConfig := test.pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } cacheKeys := test.pluginProvider.provider.cache.ListKeys() expectedCacheKeys := test.expectedCacheKeys(test.pluginProvider.provider) if !reflect.DeepEqual(cacheKeys, expectedCacheKeys) { t.Logf("actual cache keys: %#v", cacheKeys) t.Logf("expected cache keys: %v", expectedCacheKeys) t.Error("unexpected cache keys") } // nil out the exec plugin, this will test whether credentialproviderapi are fetched // from cache, otherwise Provider should panic test.pluginProvider.provider.plugin = nil dockerConfig = test.pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } }) } } func Test_NoCacheResponse(t *testing.T) { tclock := clock.RealClock{} pluginProvider := &perPodPluginProvider{ provider: &pluginProvider{ clock: tclock, lastCachePurge: tclock.Now(), matchImages: []string{"*.registry.io"}, cache: cache.NewExpirationStore(cacheKeyFunc, &cacheExpirationPolicy{clock: tclock}), plugin: &fakeExecPlugin{ cacheKeyType: credentialproviderapi.GlobalPluginCacheKeyType, cacheDuration: 0, // no cache auth: map[string]credentialproviderapi.AuthConfig{ "*.registry.io": { Username: "user", Password: "password", }, }, }, }, } expectedDockerConfig := credentialprovider.DockerConfig{ "*.registry.io": credentialprovider.DockerConfigEntry{ Username: "user", Password: "password", }, } dockerConfig := pluginProvider.Provide("test.registry.io/foo/bar") if !reflect.DeepEqual(dockerConfig, expectedDockerConfig) { t.Logf("actual docker config: %v", dockerConfig) t.Logf("expected docker config: %v", expectedDockerConfig) t.Fatal("unexpected docker config") } expectedCacheKeys := []string{} cacheKeys := pluginProvider.provider.cache.ListKeys() if !reflect.DeepEqual(cacheKeys, expectedCacheKeys) { t.Logf("actual cache keys: %v", cacheKeys) t.Logf("expected cache keys: %v", expectedCacheKeys) t.Error("unexpected cache keys") } } func Test_ExecPluginEnvVars(t *testing.T) { testcases := []struct { name string systemEnvVars []string execPlugin *execPlugin expectedEnvVars []string }{ { name: "positive append system env vars", systemEnvVars: []string{"HOME=/home/foo", "PATH=/usr/bin"}, execPlugin: &execPlugin{ envVars: []kubeletconfig.ExecEnvVar{ { Name: "SUPER_SECRET_STRONG_ACCESS_KEY", Value: "123456789", }, }, }, expectedEnvVars: []string{ "HOME=/home/foo", "PATH=/usr/bin", "SUPER_SECRET_STRONG_ACCESS_KEY=123456789", }, }, { name: "positive no env vars provided in plugin", systemEnvVars: []string{"HOME=/home/foo", "PATH=/usr/bin"}, execPlugin: &execPlugin{}, expectedEnvVars: []string{ "HOME=/home/foo", "PATH=/usr/bin", }, }, { name: "positive no system env vars but env vars are provided in plugin", execPlugin: &execPlugin{ envVars: []kubeletconfig.ExecEnvVar{ { Name: "SUPER_SECRET_STRONG_ACCESS_KEY", Value: "123456789", }, }, }, expectedEnvVars: []string{ "SUPER_SECRET_STRONG_ACCESS_KEY=123456789", }, }, { name: "positive no system or plugin provided env vars", execPlugin: &execPlugin{}, expectedEnvVars: nil, }, { name: "positive plugin provided vars takes priority", systemEnvVars: []string{"HOME=/home/foo", "PATH=/usr/bin", "SUPER_SECRET_STRONG_ACCESS_KEY=1111"}, execPlugin: &execPlugin{ envVars: []kubeletconfig.ExecEnvVar{ { Name: "SUPER_SECRET_STRONG_ACCESS_KEY", Value: "123456789", }, }, }, expectedEnvVars: []string{ "HOME=/home/foo", "PATH=/usr/bin", "SUPER_SECRET_STRONG_ACCESS_KEY=1111", "SUPER_SECRET_STRONG_ACCESS_KEY=123456789", }, }, } for _, testcase := range testcases { t.Run(testcase.name, func(t *testing.T) { testcase.execPlugin.environ = func() []string { return testcase.systemEnvVars } var configVars []string for _, envVar := range testcase.execPlugin.envVars { configVars = append(configVars, fmt.Sprintf("%s=%s", envVar.Name, envVar.Value)) } merged := mergeEnvVars(testcase.systemEnvVars, configVars) err := validate(testcase.expectedEnvVars, merged) if err != nil { t.Logf("unexpecged error %v", err) } }) } } func validate(expected, actual []string) error { if len(actual) != len(expected) { return fmt.Errorf("actual env var length [%d] and expected env var length [%d] don't match", len(actual), len(expected)) } for i := range actual { if actual[i] != expected[i] { return fmt.Errorf("mismatch in expected env var %s and actual env var %s", actual[i], expected[i]) } } return nil } func TestGenerateServiceAccountCacheKey_Deterministic(t *testing.T) { namespace1 := "default" name1 := "service-account1" uid1 := types.UID("633a81d0-0f58-4a43-9e84-113145201b72") annotations1 := map[string]string{"domain.io/identity-id": "1234567890", "domain.io/role": "admin"} namespace2 := "kube-system" name2 := "service-account2" uid2 := types.UID("1408a4e6-e40b-4bbf-9019-4d86bfea73ae") annotations2 := map[string]string{"domain.io/identity-id": "0987654321", "domain.io/role": "viewer"} testCases := []struct { serviceAccountNamespace string serviceAccountName string serviceAccountUID types.UID requiredAnnotations map[string]string }{ {namespace1, name1, uid1, annotations1}, {namespace1, name1, uid1, annotations2}, {namespace1, name2, uid1, annotations1}, {namespace1, name2, uid1, annotations2}, {namespace2, name1, uid1, annotations1}, {namespace2, name1, uid1, annotations2}, {namespace2, name2, uid1, annotations1}, {namespace2, name2, uid1, annotations2}, {namespace1, name1, uid2, annotations1}, {namespace1, name1, uid2, annotations2}, {namespace1, name2, uid2, annotations1}, {namespace1, name2, uid2, annotations2}, {namespace2, name1, uid2, annotations1}, {namespace2, name1, uid2, annotations2}, {namespace2, name2, uid2, annotations1}, {namespace2, name2, uid2, annotations2}, } for _, tc := range testCases { tc := tc for _, tc2 := range testCases { tc2 := tc2 t.Run(fmt.Sprintf("%+v-%+v", tc, tc2), func(t *testing.T) { serviceAccountCacheKey1, err1 := generateServiceAccountCacheKey(tc.serviceAccountNamespace, tc.serviceAccountName, tc.serviceAccountUID, tc.requiredAnnotations) serviceAccountCacheKey2, err2 := generateServiceAccountCacheKey(tc2.serviceAccountNamespace, tc2.serviceAccountName, tc2.serviceAccountUID, tc2.requiredAnnotations) if err1 != nil || err2 != nil { t.Errorf("expected no error, but got err1=%v, err2=%v", err1, err2) } if bytes.Equal([]byte(serviceAccountCacheKey1), []byte(serviceAccountCacheKey2)) != reflect.DeepEqual(tc, tc2) { t.Errorf("expected %v, got %v", reflect.DeepEqual(tc, tc2), bytes.Equal([]byte(serviceAccountCacheKey1), []byte(serviceAccountCacheKey2))) } cacheKey1, err1 := generateCacheKey("registry.io/image", serviceAccountCacheKey1) cacheKey2, err2 := generateCacheKey("registry.io/image", serviceAccountCacheKey2) if err1 != nil || err2 != nil { t.Errorf("expected no error, but got err1=%v, err2=%v", err1, err2) } if bytes.Equal([]byte(cacheKey1), []byte(cacheKey2)) != reflect.DeepEqual(tc, tc2) { t.Errorf("expected %v, got %v", reflect.DeepEqual(tc, tc2), bytes.Equal([]byte(cacheKey1), []byte(cacheKey2))) } }) } } } func TestGenerateServiceAccountCacheKey(t *testing.T) { tests := []struct { name string saNamespace string saName string saUID types.UID saAnnotations map[string]string want string }{ { name: "no annotations", saNamespace: "namespace", saName: "service-account", saUID: "service-account-uid", saAnnotations: nil, want: "\x00\tnamespace\x00\x0fservice-account\x00\x13service-account-uid\x00\x00\x00\x00", }, { name: "single annotation", saNamespace: "namespace", saName: "service-account", saUID: "service-account-uid", saAnnotations: map[string]string{"domain.io/annotation-1": "value1"}, want: "\x00\tnamespace\x00\x0fservice-account\x00\x13service-account-uid\x00\x00\x00\x01\x00\x16domain.io/annotation-1\x00\x06value1", }, { name: "multiple annotations", saNamespace: "namespace", saName: "service-account", saUID: "service-account-uid", saAnnotations: map[string]string{"domain.io/annotation-1": "value1", "domain.io/annotation-2": "value2"}, want: "\x00\tnamespace\x00\x0fservice-account\x00\x13service-account-uid\x00\x00\x00\x02\x00\x16domain.io/annotation-1\x00\x06value1\x00\x16domain.io/annotation-2\x00\x06value2", }, { name: "annotations with different order should be sorted", saNamespace: "namespace", saName: "service-account", saUID: "service-account-uid", saAnnotations: map[string]string{"domain.io/annotation-2": "value2", "domain.io/annotation-1": "value1"}, want: "\x00\tnamespace\x00\x0fservice-account\x00\x13service-account-uid\x00\x00\x00\x02\x00\x16domain.io/annotation-1\x00\x06value1\x00\x16domain.io/annotation-2\x00\x06value2", }, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { got, err := generateServiceAccountCacheKey(tc.saNamespace, tc.saName, tc.saUID, tc.saAnnotations) if err != nil { t.Errorf("unexpected error: %v", err) } if got != tc.want { t.Errorf("expected %q, got '%q'", tc.want, got) } }) } } func TestGenerateCacheKey(t *testing.T) { tests := []struct { name string baseKey string serviceAccountCacheKey string want string }{ { name: "empty service account cache key", baseKey: "registry.io/image", serviceAccountCacheKey: "", want: "\x00\x11registry.io/image\x00\x00", }, { name: "combined key", baseKey: "registry.io/image", serviceAccountCacheKey: "\x00\tnamespace\x00\x0fservice-account\x00\x13service-account-uid\x00\x00\x00\x02\x00\x16domain.io/annotation-1\x00\x06value1\x00\x16domain.io/annotation-2\x00\x06value2", want: "\x00\x11registry.io/image\x00u\x00\tnamespace\x00\x0fservice-account\x00\x13service-account-uid\x00\x00\x00\x02\x00\x16domain.io/annotation-1\x00\x06value1\x00\x16domain.io/annotation-2\x00\x06value2", }, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { got, err := generateCacheKey(tc.baseKey, tc.serviceAccountCacheKey) if err != nil { t.Errorf("unexpected error: %v", err) } if got != tc.want { t.Errorf("expected %q, got %q", tc.want, got) } }) } }