mirror of
https://github.com/optim-enterprises-bv/kubernetes.git
synced 2025-11-02 03:08:15 +00:00
04c6d9324e
The test for checking container restarts in a Pod with restartable-init-1 and regular-1 is flaky. Right now, when we check if restartable-init-1 has restarted, we see if it hasn’t written the "Started" log after regular-1 has written its "Started" log. But even though the startup sequence starts with restartable-init-1 and then regular-1, there’s no guarantee they’ll finish starting up in that order. Sometimes regular-1 finishes first and writes its "Started" log before restartable-init-1. 1. restartable-init-1 Starting 2. regular-1 Starting 3. regular-1 Started 4. restartable-init-1 Started In this test, the startup order doesn’t really matter; all we need to check is if restartable-init-1 restarted. So I changed the test to simply look for more than one "Starting" log in restartable-init-1's logs. There were other places that used the same helper function DoesntStartAfter, so replaced those as well and deleted the helper function.