kubernetes/pkg/scheduler/algorithmprovider/registry_test.go

/*
Copyright 2017 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package algorithmprovider

import (
	"fmt"
	"testing"

	"github.com/google/go-cmp/cmp"

	"k8s.io/apimachinery/pkg/runtime"
	utilfeature "k8s.io/apiserver/pkg/util/feature"
	featuregatetesting "k8s.io/component-base/featuregate/testing"
	"k8s.io/kubernetes/pkg/features"
	schedulerapi "k8s.io/kubernetes/pkg/scheduler/apis/config"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultpodtopologyspread"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/imagelocality"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/interpodaffinity"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodeaffinity"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodename"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodeports"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodepreferavoidpods"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/noderesources"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodeunschedulable"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/nodevolumelimits"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/podtopologyspread"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/tainttoleration"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumerestrictions"
	"k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumezone"
)

func TestClusterAutoscalerProvider(t *testing.T) {
	hardPodAffinityWeight := int64(1)
	wantConfig := &Config{
		FrameworkPlugins: &schedulerapi.Plugins{
			PreFilter: &schedulerapi.PluginSet{
				Enabled: []schedulerapi.Plugin{
					{Name: noderesources.FitName},
					{Name: nodeports.Name},
					{Name: interpodaffinity.Name},
				},
			},
			Filter: &schedulerapi.PluginSet{
				Enabled: []schedulerapi.Plugin{
					{Name: nodeunschedulable.Name},
					{Name: noderesources.FitName},
					{Name: nodename.Name},
					{Name: nodeports.Name},
					{Name: nodeaffinity.Name},
					{Name: volumerestrictions.Name},
					{Name: tainttoleration.Name},
					{Name: nodevolumelimits.EBSName},
					{Name: nodevolumelimits.GCEPDName},
					{Name: nodevolumelimits.CSIName},
					{Name: nodevolumelimits.AzureDiskName},
					{Name: volumebinding.Name},
					{Name: volumezone.Name},
					{Name: interpodaffinity.Name},
				},
			},
			PostFilter: &schedulerapi.PluginSet{
				Enabled: []schedulerapi.Plugin{
					{Name: interpodaffinity.Name},
					{Name: tainttoleration.Name},
				},
			},
			Score: &schedulerapi.PluginSet{
				Enabled: []schedulerapi.Plugin{
					{Name: noderesources.BalancedAllocationName, Weight: 1},
					{Name: imagelocality.Name, Weight: 1},
					{Name: interpodaffinity.Name, Weight: 1},
					{Name: noderesources.MostAllocatedName, Weight: 1},
					{Name: nodeaffinity.Name, Weight: 1},
					{Name: nodepreferavoidpods.Name, Weight: 10000},
					{Name: defaultpodtopologyspread.Name, Weight: 1},
					{Name: tainttoleration.Name, Weight: 1},
				},
			},
		},
		FrameworkPluginConfig: []schedulerapi.PluginConfig{
			{
				Name: interpodaffinity.Name,
				Args: runtime.Unknown{Raw: []byte(fmt.Sprintf(`{"hardPodAffinityWeight":%d}`, hardPodAffinityWeight))},
			},
		},
	}

	r := NewRegistry(hardPodAffinityWeight)
	gotConfig := r[ClusterAutoscalerProvider]
	if diff := cmp.Diff(wantConfig, gotConfig); diff != "" {
		t.Errorf("unexpected config diff (-want, +got): %s", diff)
	}
}

func TestApplyFeatureGates(t *testing.T) {
	hardPodAffinityWeight := int64(1)
	tests := []struct {
		name            string
		featuresEnabled bool
		wantConfig      *Config
	}{
		{
			name:            "Feature gates disabled",
			featuresEnabled: false,
			wantConfig: &Config{
				FrameworkPlugins: &schedulerapi.Plugins{
					PreFilter: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: noderesources.FitName},
							{Name: nodeports.Name},
							{Name: interpodaffinity.Name},
						},
					},
					Filter: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: nodeunschedulable.Name},
							{Name: noderesources.FitName},
							{Name: nodename.Name},
							{Name: nodeports.Name},
							{Name: nodeaffinity.Name},
							{Name: volumerestrictions.Name},
							{Name: tainttoleration.Name},
							{Name: nodevolumelimits.EBSName},
							{Name: nodevolumelimits.GCEPDName},
							{Name: nodevolumelimits.CSIName},
							{Name: nodevolumelimits.AzureDiskName},
							{Name: volumebinding.Name},
							{Name: volumezone.Name},
							{Name: interpodaffinity.Name},
						},
					},
					PostFilter: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: interpodaffinity.Name},
							{Name: tainttoleration.Name},
						},
					},
					Score: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: noderesources.BalancedAllocationName, Weight: 1},
							{Name: imagelocality.Name, Weight: 1},
							{Name: interpodaffinity.Name, Weight: 1},
							{Name: noderesources.LeastAllocatedName, Weight: 1},
							{Name: nodeaffinity.Name, Weight: 1},
							{Name: nodepreferavoidpods.Name, Weight: 10000},
							{Name: defaultpodtopologyspread.Name, Weight: 1},
							{Name: tainttoleration.Name, Weight: 1},
						},
					},
				},
				FrameworkPluginConfig: []schedulerapi.PluginConfig{
					{
						Name: interpodaffinity.Name,
						Args: runtime.Unknown{Raw: []byte(fmt.Sprintf(`{"hardPodAffinityWeight":%d}`, hardPodAffinityWeight))},
					},
				},
			},
		},
		{
			name:            "Feature gates enabled",
			featuresEnabled: true,
			wantConfig: &Config{
				FrameworkPlugins: &schedulerapi.Plugins{
					PreFilter: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: noderesources.FitName},
							{Name: nodeports.Name},
							{Name: interpodaffinity.Name},
							{Name: podtopologyspread.Name},
						},
					},
					Filter: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: nodeunschedulable.Name},
							{Name: noderesources.FitName},
							{Name: nodename.Name},
							{Name: nodeports.Name},
							{Name: nodeaffinity.Name},
							{Name: volumerestrictions.Name},
							{Name: tainttoleration.Name},
							{Name: nodevolumelimits.EBSName},
							{Name: nodevolumelimits.GCEPDName},
							{Name: nodevolumelimits.CSIName},
							{Name: nodevolumelimits.AzureDiskName},
							{Name: volumebinding.Name},
							{Name: volumezone.Name},
							{Name: interpodaffinity.Name},
							{Name: podtopologyspread.Name},
						},
					},
					PostFilter: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: interpodaffinity.Name},
							{Name: tainttoleration.Name},
							{Name: podtopologyspread.Name},
						},
					},
					Score: &schedulerapi.PluginSet{
						Enabled: []schedulerapi.Plugin{
							{Name: noderesources.BalancedAllocationName, Weight: 1},
							{Name: imagelocality.Name, Weight: 1},
							{Name: interpodaffinity.Name, Weight: 1},
							{Name: noderesources.LeastAllocatedName, Weight: 1},
							{Name: nodeaffinity.Name, Weight: 1},
							{Name: nodepreferavoidpods.Name, Weight: 10000},
							{Name: defaultpodtopologyspread.Name, Weight: 1},
							{Name: tainttoleration.Name, Weight: 1},
							{Name: podtopologyspread.Name, Weight: 1},
							{Name: noderesources.ResourceLimitsName, Weight: 1},
						},
					},
				},
				FrameworkPluginConfig: []schedulerapi.PluginConfig{
					{
						Name: interpodaffinity.Name,
						Args: runtime.Unknown{Raw: []byte(fmt.Sprintf(`{"hardPodAffinityWeight":%d}`, hardPodAffinityWeight))},
					},
				},
			},
		},
	}

	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ResourceLimitsPriorityFunction, test.featuresEnabled)()
			defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.EvenPodsSpread, test.featuresEnabled)()

			r := NewRegistry(hardPodAffinityWeight)
			gotConfig := r[schedulerapi.SchedulerDefaultProviderName]
			if diff := cmp.Diff(test.wantConfig, gotConfig); diff != "" {
				t.Errorf("unexpected config diff (-want, +got): %s", diff)
			}
		})
	}
}