mirror of
https://github.com/optim-enterprises-bv/kubernetes.git
synced 2025-11-03 19:58:17 +00:00
The current dryrun client implemnetation is suboptimal and sparse. It has the following problems: - When an object CREATE or UPDATE reaches the default dryrun client the operation is a NO-OP, which means subsequent GET calls must fully emulate the object that exists in the store. - There are multiple implmentations of a DryRunGetter interface such the one in init_dryrun.go but there are no implementations for reset, upgrade, join. - There is a specific DryRunGetter that is backed by a real client in clientbacked_dryrun.go, but this is used for upgrade and does not work in conjuction with a fake client. This commit does the following changes: - Removes all existing *dryrun*.go implementations. - Add a new DryRun implementation in dryrun.go that implements 3 clients - fake clientset, real clientset, real dynamic client. - The DryRun object uses the method chaining pattern. - Allows the user opt-in into real clients only if needed, by passing a real kubeconfig. By default only constructs a fake client. - The default reactor chain for the fake client, always logs the object action, then for GET or LIST actions attempts to use the real dynamic client to get the object. If a real object does not exist it attempts to get the object from the fake object store. - The user can prepend or append reactors to the chain. - All known needed reactors for operations during init, join, reset, upgrade are added as methods of the DryRun struct. - Adds detailed unit test for the DryRun struct and its methods including reactors. Additional changes: - Use the new DryRun implementation in all command workflows - init, join, reset, upgrade. - Ensure that --dry-run works even if there is no active cluster by returning faked objects. For join, a faked cluster-info with a fake bootstrap token and CA are used.
172 lines
6.5 KiB
Go
172 lines
6.5 KiB
Go
/*
|
||
Copyright 2017 The Kubernetes Authors.
|
||
|
||
Licensed under the Apache License, Version 2.0 (the "License");
|
||
you may not use this file except in compliance with the License.
|
||
You may obtain a copy of the License at
|
||
|
||
http://www.apache.org/licenses/LICENSE-2.0
|
||
|
||
Unless required by applicable law or agreed to in writing, software
|
||
distributed under the License is distributed on an "AS IS" BASIS,
|
||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
See the License for the specific language governing permissions and
|
||
limitations under the License.
|
||
*/
|
||
|
||
package dryrun
|
||
|
||
import (
|
||
"fmt"
|
||
"io"
|
||
"os"
|
||
"path/filepath"
|
||
"time"
|
||
|
||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
||
errorsutil "k8s.io/apimachinery/pkg/util/errors"
|
||
|
||
kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
|
||
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
|
||
"k8s.io/kubernetes/cmd/kubeadm/app/util/apiclient"
|
||
)
|
||
|
||
// FileToPrint represents a temporary file on disk that might want to be aliased when printing
|
||
// Useful for things like loading a file from /tmp/ but saying to the user "Would write file foo to /etc/kubernetes/..."
|
||
type FileToPrint struct {
|
||
RealPath string
|
||
PrintPath string
|
||
}
|
||
|
||
// NewFileToPrint makes a new instance of FileToPrint with the specified arguments
|
||
func NewFileToPrint(realPath, printPath string) FileToPrint {
|
||
return FileToPrint{
|
||
RealPath: realPath,
|
||
PrintPath: printPath,
|
||
}
|
||
}
|
||
|
||
// PrintDryRunFile is a helper method around PrintDryRunFiles
|
||
func PrintDryRunFile(fileName, realDir, printDir string, w io.Writer) error {
|
||
return PrintDryRunFiles([]FileToPrint{
|
||
NewFileToPrint(filepath.Join(realDir, fileName), filepath.Join(printDir, fileName)),
|
||
}, w)
|
||
}
|
||
|
||
// PrintDryRunFiles prints the contents of the FileToPrints given to it to the writer w
|
||
func PrintDryRunFiles(files []FileToPrint, w io.Writer) error {
|
||
errs := []error{}
|
||
for _, file := range files {
|
||
if len(file.RealPath) == 0 {
|
||
continue
|
||
}
|
||
|
||
fileBytes, err := os.ReadFile(file.RealPath)
|
||
if err != nil {
|
||
errs = append(errs, err)
|
||
continue
|
||
}
|
||
|
||
// Make it possible to fake the path of the file; i.e. you may want to tell the user
|
||
// "Here is what would be written to /etc/kubernetes/admin.conf", although you wrote it to /tmp/kubeadm-dryrun/admin.conf and are loading it from there
|
||
// Fall back to the "real" path if PrintPath is not set
|
||
outputFilePath := file.PrintPath
|
||
if len(outputFilePath) == 0 {
|
||
outputFilePath = file.RealPath
|
||
}
|
||
|
||
fmt.Fprintf(w, "[dryrun] Would write file %q with content:\n", outputFilePath)
|
||
fmt.Fprintf(w, "%s", fileBytes)
|
||
}
|
||
return errorsutil.NewAggregate(errs)
|
||
}
|
||
|
||
// Waiter is an implementation of apiclient.Waiter that should be used for dry-running
|
||
type Waiter struct{}
|
||
|
||
// NewWaiter returns a new Waiter object that talks to the given Kubernetes cluster
|
||
func NewWaiter() apiclient.Waiter {
|
||
return &Waiter{}
|
||
}
|
||
|
||
// WaitForControlPlaneComponents just returns a dummy nil, to indicate that the program should just proceed
|
||
func (w *Waiter) WaitForControlPlaneComponents(cfg *kubeadmapi.ClusterConfiguration) error {
|
||
return nil
|
||
}
|
||
|
||
// WaitForAPI just returns a dummy nil, to indicate that the program should just proceed
|
||
func (w *Waiter) WaitForAPI() error {
|
||
fmt.Println("[dryrun] Would wait for the API Server's /healthz endpoint to return 'ok'")
|
||
return nil
|
||
}
|
||
|
||
// WaitForPodsWithLabel just returns a dummy nil, to indicate that the program should just proceed
|
||
func (w *Waiter) WaitForPodsWithLabel(kvLabel string) error {
|
||
fmt.Printf("[dryrun] Would wait for the Pods with the label %q in the %s namespace to become Running\n", kvLabel, metav1.NamespaceSystem)
|
||
return nil
|
||
}
|
||
|
||
// WaitForPodToDisappear just returns a dummy nil, to indicate that the program should just proceed
|
||
func (w *Waiter) WaitForPodToDisappear(podName string) error {
|
||
fmt.Printf("[dryrun] Would wait for the %q Pod in the %s namespace to be deleted\n", podName, metav1.NamespaceSystem)
|
||
return nil
|
||
}
|
||
|
||
// WaitForKubelet blocks until the kubelet /healthz endpoint returns 'ok'
|
||
func (w *Waiter) WaitForKubelet(healthzAddress string, healthzPort int32) error {
|
||
fmt.Printf("[dryrun] Would make sure the kubelet returns 'ok' at http://%s:%d/healthz\n", healthzAddress, healthzPort)
|
||
return nil
|
||
}
|
||
|
||
// SetTimeout is a no-op; we don't wait in this implementation
|
||
func (w *Waiter) SetTimeout(_ time.Duration) {}
|
||
|
||
// WaitForStaticPodControlPlaneHashes returns an empty hash for all control plane images;
|
||
func (w *Waiter) WaitForStaticPodControlPlaneHashes(_ string) (map[string]string, error) {
|
||
return map[string]string{
|
||
kubeadmconstants.KubeAPIServer: "",
|
||
kubeadmconstants.KubeControllerManager: "",
|
||
kubeadmconstants.KubeScheduler: "",
|
||
}, nil
|
||
}
|
||
|
||
// WaitForStaticPodSingleHash returns an empty hash
|
||
// but the empty strings there are needed
|
||
func (w *Waiter) WaitForStaticPodSingleHash(_ string, _ string) (string, error) {
|
||
return "", nil
|
||
}
|
||
|
||
// WaitForStaticPodHashChange returns a dummy nil error in order for the flow to just continue as we're dryrunning
|
||
func (w *Waiter) WaitForStaticPodHashChange(_, _, _ string) error {
|
||
return nil
|
||
}
|
||
|
||
// PrintFilesIfDryRunning prints the static pod manifests to stdout and informs about the temporary directory to go and lookup when dry running
|
||
func PrintFilesIfDryRunning(needPrintManifest bool, manifestDir string, outputWriter io.Writer) error {
|
||
var files []FileToPrint
|
||
// Print static pod manifests if it is a control plane
|
||
if needPrintManifest {
|
||
fmt.Printf("[dryrun] Wrote certificates, kubeconfig files and control plane manifests to the %q directory\n", manifestDir)
|
||
for _, component := range kubeadmconstants.ControlPlaneComponents {
|
||
realPath := kubeadmconstants.GetStaticPodFilepath(component, manifestDir)
|
||
outputPath := kubeadmconstants.GetStaticPodFilepath(component, kubeadmconstants.GetStaticPodDirectory())
|
||
files = append(files, NewFileToPrint(realPath, outputPath))
|
||
}
|
||
} else {
|
||
fmt.Printf("[dryrun] Wrote certificates and kubeconfig files to the %q directory\n", manifestDir)
|
||
}
|
||
|
||
fmt.Println("[dryrun] The certificates or kubeconfig files would not be printed due to their sensitive nature")
|
||
fmt.Printf("[dryrun] Please examine the %q directory for details about what would be written\n", manifestDir)
|
||
|
||
// Print kubelet config manifests
|
||
kubeletConfigFiles := []string{kubeadmconstants.KubeletConfigurationFileName, kubeadmconstants.KubeletEnvFileName}
|
||
for _, filename := range kubeletConfigFiles {
|
||
realPath := filepath.Join(manifestDir, filename)
|
||
outputPath := filepath.Join(kubeadmconstants.KubeletRunDirectory, filename)
|
||
files = append(files, NewFileToPrint(realPath, outputPath))
|
||
}
|
||
|
||
return PrintDryRunFiles(files, outputWriter)
|
||
}
|