mirror of
https://github.com/optim-enterprises-bv/kubernetes.git
synced 2025-11-28 12:23:55 +00:00
When using iscsi storage with multiple target portal (TP) addresses and multipathing the volume manager logs on to the IQN for all portal addresses, but when a pod gets destroyed the volume manager only logs out for the primary TP and sessions for another TPs are always remained. This patch adds methods to store and load iscsi disk configrations, then uses the stored config at DetachDisk path. Fix #45394
174 lines
6.2 KiB
Go
Executable File
174 lines
6.2 KiB
Go
Executable File
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package iscsi
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"k8s.io/kubernetes/pkg/util/mount"
|
|
)
|
|
|
|
func TestGetDevicePrefixRefCount(t *testing.T) {
|
|
fm := &mount.FakeMounter{
|
|
MountPoints: []mount.MountPoint{
|
|
{Device: "/dev/sdb",
|
|
Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0"},
|
|
{Device: "/dev/sdb",
|
|
Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-1"},
|
|
{Device: "/dev/sdb",
|
|
Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-2"},
|
|
{Device: "/dev/sdb",
|
|
Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-3"},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
devicePrefix string
|
|
expectedRefs int
|
|
}{
|
|
{
|
|
"/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00",
|
|
4,
|
|
},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
if refs, err := getDevicePrefixRefCount(fm, test.devicePrefix); err != nil || test.expectedRefs != refs {
|
|
t.Errorf("%d. GetDevicePrefixRefCount(%s) = %d, %v; expected %d, nil", i, test.devicePrefix, refs, err, test.expectedRefs)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExtractDeviceAndPrefix(t *testing.T) {
|
|
devicePath := "127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00"
|
|
mountPrefix := "/var/lib/kubelet/plugins/kubernetes.io/iscsi/iface-default/" + devicePath
|
|
lun := "-lun-0"
|
|
device, prefix, err := extractDeviceAndPrefix(mountPrefix + lun)
|
|
if err != nil || device != (devicePath+lun) || prefix != mountPrefix {
|
|
t.Errorf("extractDeviceAndPrefix: expected %s and %s, got %v %s and %s", devicePath+lun, mountPrefix, err, device, prefix)
|
|
}
|
|
}
|
|
|
|
func TestExtractIface(t *testing.T) {
|
|
ifaceName := "default"
|
|
devicePath := "127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0"
|
|
iface, found := extractIface("/var/lib/kubelet/plugins/kubernetes.io/iscsi/iface-" + ifaceName + "/" + devicePath)
|
|
if !found || iface != ifaceName {
|
|
t.Errorf("extractIface: expected %s and %t, got %s and %t", ifaceName, true, iface, found)
|
|
}
|
|
iface, found = extractIface("/var/lib/kubelet/plugins/kubernetes.io/iscsi/" + devicePath)
|
|
if found || iface != "" {
|
|
t.Errorf("extractIface: expected %s and %t, got %s and %t", "", false, iface, found)
|
|
}
|
|
}
|
|
|
|
func TestExtractPortalAndIqn(t *testing.T) {
|
|
devicePath := "127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0"
|
|
portal, iqn, err := extractPortalAndIqn(devicePath)
|
|
if err != nil || portal != "127.0.0.1:3260" || iqn != "iqn.2014-12.com.example:test.tgt00" {
|
|
t.Errorf("extractPortalAndIqn: got %v %s %s", err, portal, iqn)
|
|
}
|
|
devicePath = "127.0.0.1:3260-eui.02004567A425678D-lun-0"
|
|
portal, iqn, err = extractPortalAndIqn(devicePath)
|
|
if err != nil || portal != "127.0.0.1:3260" || iqn != "eui.02004567A425678D" {
|
|
t.Errorf("extractPortalAndIqn: got %v %s %s", err, portal, iqn)
|
|
}
|
|
}
|
|
|
|
func TestRemoveDuplicate(t *testing.T) {
|
|
dupPortals := []string{"127.0.0.1:3260", "127.0.0.1:3260", "127.0.0.100:3260"}
|
|
portals := removeDuplicate(dupPortals)
|
|
want := []string{"127.0.0.1:3260", "127.0.0.100:3260"}
|
|
if reflect.DeepEqual(portals, want) == false {
|
|
t.Errorf("removeDuplicate: want: %s, got: %s", want, portals)
|
|
}
|
|
}
|
|
|
|
func fakeOsStat(devicePath string) (fi os.FileInfo, err error) {
|
|
var cmd os.FileInfo
|
|
return cmd, nil
|
|
}
|
|
|
|
func fakeFilepathGlob(devicePath string) (globs []string, err error) {
|
|
return []string{devicePath}, nil
|
|
}
|
|
|
|
func TestExtractTransportname(t *testing.T) {
|
|
fakeIscsiadmOutput := []string{
|
|
"# BEGIN RECORD 2.0-873\n" +
|
|
"iface.iscsi_ifacename = default\n" +
|
|
"iface.transport_name = tcp\n" +
|
|
"iface.initiatorname = <empty>\n" +
|
|
"# END RECORD",
|
|
"# BEGIN RECORD 2.0-873\n" +
|
|
"iface.iscsi_ifacename = default\n" +
|
|
"iface.transport_name = cxgb4i\n" +
|
|
"iface.initiatorname = <empty>\n" +
|
|
"# END RECORD",
|
|
"# BEGIN RECORD 2.0-873\n" +
|
|
"iface.iscsi_ifacename = default\n" +
|
|
"iface.transport_name = <empty>\n" +
|
|
"iface.initiatorname = <empty>\n" +
|
|
"# END RECORD",
|
|
"# BEGIN RECORD 2.0-873\n" +
|
|
"iface.iscsi_ifacename = default\n" +
|
|
"iface.initiatorname = <empty>\n" +
|
|
"# END RECORD"}
|
|
transportName := extractTransportname(fakeIscsiadmOutput[0])
|
|
if transportName != "tcp" {
|
|
t.Errorf("extractTransportname: Could not extract correct iface.transport_name 'tcp', got %s", transportName)
|
|
}
|
|
transportName = extractTransportname(fakeIscsiadmOutput[1])
|
|
if transportName != "cxgb4i" {
|
|
t.Errorf("extractTransportname: Could not extract correct iface.transport_name 'cxgb4i', got %s", transportName)
|
|
}
|
|
transportName = extractTransportname(fakeIscsiadmOutput[2])
|
|
if transportName != "tcp" {
|
|
t.Errorf("extractTransportname: Could not extract correct iface.transport_name 'tcp', got %s", transportName)
|
|
}
|
|
transportName = extractTransportname(fakeIscsiadmOutput[3])
|
|
if transportName != "" {
|
|
t.Errorf("extractTransportname: Could not extract correct iface.transport_name '', got %s", transportName)
|
|
}
|
|
}
|
|
|
|
func TestWaitForPathToExist(t *testing.T) {
|
|
devicePath := []string{"/dev/disk/by-path/ip-127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0",
|
|
"/dev/disk/by-path/pci-0000:00:00.0-ip-127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0"}
|
|
|
|
exist := waitForPathToExistInternal(devicePath[0], 1, "tcp", fakeOsStat, filepath.Glob)
|
|
if exist == false {
|
|
t.Errorf("waitForPathToExist: could not find path %s", devicePath[0])
|
|
}
|
|
exist = waitForPathToExistInternal(devicePath[0], 1, "fake_iface", fakeOsStat, filepath.Glob)
|
|
if exist != false {
|
|
t.Errorf("waitForPathToExist: wrong code path called for %s", devicePath[0])
|
|
}
|
|
|
|
exist = waitForPathToExistInternal(devicePath[1], 1, "fake_iface", os.Stat, fakeFilepathGlob)
|
|
if exist == false {
|
|
t.Errorf("waitForPathToExist: could not find path %s", devicePath[1])
|
|
}
|
|
exist = waitForPathToExistInternal(devicePath[1], 1, "tcp", os.Stat, fakeFilepathGlob)
|
|
if exist != false {
|
|
t.Errorf("waitForPathToExist: wrong code path called for %s", devicePath[1])
|
|
}
|
|
}
|