mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-10-31 10:18:13 +00:00 
			
		
		
		
	 0fb1f59a88
			
		
	
	0fb1f59a88
	
	
	
		
			
			Mark the helper functions with t.Helper() so that if t.Errorf() in these functions gets called, it will report that the failure occurred on the line number of the caller of the helper, rather than the line number of the helper itself, which makes it hard to identify which case causes the failure. Signed-off-by: Quan Tian <qtian@vmware.com>
		
			
				
	
	
		
			314 lines
		
	
	
		
			8.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			314 lines
		
	
	
		
			8.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
| Copyright 2016 The Kubernetes Authors.
 | |
| 
 | |
| Licensed under the Apache License, Version 2.0 (the "License");
 | |
| you may not use this file except in compliance with the License.
 | |
| You may obtain a copy of the License at
 | |
| 
 | |
|     http://www.apache.org/licenses/LICENSE-2.0
 | |
| 
 | |
| Unless required by applicable law or agreed to in writing, software
 | |
| distributed under the License is distributed on an "AS IS" BASIS,
 | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| See the License for the specific language governing permissions and
 | |
| limitations under the License.
 | |
| */
 | |
| 
 | |
| package service
 | |
| 
 | |
| import (
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| 
 | |
| 	v1 "k8s.io/api/core/v1"
 | |
| 	utilnet "k8s.io/utils/net"
 | |
| )
 | |
| 
 | |
| func TestGetLoadBalancerSourceRanges(t *testing.T) {
 | |
| 	checkError := func(v string) {
 | |
| 		t.Helper()
 | |
| 		annotations := make(map[string]string)
 | |
| 		annotations[v1.AnnotationLoadBalancerSourceRangesKey] = v
 | |
| 		svc := v1.Service{}
 | |
| 		svc.Annotations = annotations
 | |
| 		_, err := GetLoadBalancerSourceRanges(&svc)
 | |
| 		if err == nil {
 | |
| 			t.Errorf("Expected error parsing: %q", v)
 | |
| 		}
 | |
| 		svc = v1.Service{}
 | |
| 		svc.Spec.LoadBalancerSourceRanges = strings.Split(v, ",")
 | |
| 		_, err = GetLoadBalancerSourceRanges(&svc)
 | |
| 		if err == nil {
 | |
| 			t.Errorf("Expected error parsing: %q", v)
 | |
| 		}
 | |
| 	}
 | |
| 	checkError("10.0.0.1/33")
 | |
| 	checkError("foo.bar")
 | |
| 	checkError("10.0.0.1/32,*")
 | |
| 	checkError("10.0.0.1/32,")
 | |
| 	checkError("10.0.0.1/32, ")
 | |
| 	checkError("10.0.0.1")
 | |
| 
 | |
| 	checkOK := func(v string) utilnet.IPNetSet {
 | |
| 		t.Helper()
 | |
| 		annotations := make(map[string]string)
 | |
| 		annotations[v1.AnnotationLoadBalancerSourceRangesKey] = v
 | |
| 		svc := v1.Service{}
 | |
| 		svc.Annotations = annotations
 | |
| 		_, err := GetLoadBalancerSourceRanges(&svc)
 | |
| 		if err != nil {
 | |
| 			t.Errorf("Unexpected error parsing: %q", v)
 | |
| 		}
 | |
| 		svc = v1.Service{}
 | |
| 		svc.Spec.LoadBalancerSourceRanges = strings.Split(v, ",")
 | |
| 		cidrs, err := GetLoadBalancerSourceRanges(&svc)
 | |
| 		if err != nil {
 | |
| 			t.Errorf("Unexpected error parsing: %q", v)
 | |
| 		}
 | |
| 		return cidrs
 | |
| 	}
 | |
| 	cidrs := checkOK("192.168.0.1/32")
 | |
| 	if len(cidrs) != 1 {
 | |
| 		t.Errorf("Expected exactly one CIDR: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	cidrs = checkOK("192.168.0.1/32,192.168.0.1/32")
 | |
| 	if len(cidrs) != 1 {
 | |
| 		t.Errorf("Expected exactly one CIDR (after de-dup): %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	cidrs = checkOK("192.168.0.1/32,192.168.0.2/32")
 | |
| 	if len(cidrs) != 2 {
 | |
| 		t.Errorf("Expected two CIDRs: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	cidrs = checkOK("  192.168.0.1/32 , 192.168.0.2/32   ")
 | |
| 	if len(cidrs) != 2 {
 | |
| 		t.Errorf("Expected two CIDRs: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	// check LoadBalancerSourceRanges not specified
 | |
| 	svc := v1.Service{}
 | |
| 	cidrs, err := GetLoadBalancerSourceRanges(&svc)
 | |
| 	if err != nil {
 | |
| 		t.Errorf("Unexpected error: %v", err)
 | |
| 	}
 | |
| 	if len(cidrs) != 1 {
 | |
| 		t.Errorf("Expected exactly one CIDR: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	if !IsAllowAll(cidrs) {
 | |
| 		t.Errorf("Expected default to be allow-all: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	// check SourceRanges annotation is empty
 | |
| 	annotations := make(map[string]string)
 | |
| 	annotations[v1.AnnotationLoadBalancerSourceRangesKey] = ""
 | |
| 	svc = v1.Service{}
 | |
| 	svc.Annotations = annotations
 | |
| 	cidrs, err = GetLoadBalancerSourceRanges(&svc)
 | |
| 	if err != nil {
 | |
| 		t.Errorf("Unexpected error: %v", err)
 | |
| 	}
 | |
| 	if len(cidrs) != 1 {
 | |
| 		t.Errorf("Expected exactly one CIDR: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| 	if !IsAllowAll(cidrs) {
 | |
| 		t.Errorf("Expected default to be allow-all: %v", cidrs.StringSlice())
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestAllowAll(t *testing.T) {
 | |
| 	checkAllowAll := func(allowAll bool, cidrs ...string) {
 | |
| 		t.Helper()
 | |
| 		ipnets, err := utilnet.ParseIPNets(cidrs...)
 | |
| 		if err != nil {
 | |
| 			t.Errorf("Unexpected error parsing cidrs: %v", cidrs)
 | |
| 		}
 | |
| 		if allowAll != IsAllowAll(ipnets) {
 | |
| 			t.Errorf("IsAllowAll did not return expected value for %v", cidrs)
 | |
| 		}
 | |
| 	}
 | |
| 	checkAllowAll(false, "10.0.0.1/32")
 | |
| 	checkAllowAll(false, "10.0.0.1/32", "10.0.0.2/32")
 | |
| 	checkAllowAll(false, "10.0.0.1/32", "10.0.0.1/32")
 | |
| 
 | |
| 	checkAllowAll(true, "0.0.0.0/0")
 | |
| 	checkAllowAll(true, "192.168.0.0/0")
 | |
| 	checkAllowAll(true, "192.168.0.1/32", "0.0.0.0/0")
 | |
| }
 | |
| 
 | |
| func TestExternallyAccessible(t *testing.T) {
 | |
| 	checkExternallyAccessible := func(expect bool, service *v1.Service) {
 | |
| 		t.Helper()
 | |
| 		res := ExternallyAccessible(service)
 | |
| 		if res != expect {
 | |
| 			t.Errorf("Expected ExternallyAccessible = %v, got %v", expect, res)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	checkExternallyAccessible(false, &v1.Service{})
 | |
| 	checkExternallyAccessible(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeClusterIP,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternallyAccessible(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:        v1.ServiceTypeClusterIP,
 | |
| 			ExternalIPs: []string{"1.2.3.4"},
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternallyAccessible(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeLoadBalancer,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternallyAccessible(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeNodePort,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternallyAccessible(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeExternalName,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternallyAccessible(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:        v1.ServiceTypeExternalName,
 | |
| 			ExternalIPs: []string{"1.2.3.4"},
 | |
| 		},
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func TestExternalPolicyLocal(t *testing.T) {
 | |
| 	checkExternalPolicyLocal := func(requestsOnlyLocalTraffic bool, service *v1.Service) {
 | |
| 		t.Helper()
 | |
| 		res := ExternalPolicyLocal(service)
 | |
| 		if res != requestsOnlyLocalTraffic {
 | |
| 			t.Errorf("Expected requests OnlyLocal traffic = %v, got %v",
 | |
| 				requestsOnlyLocalTraffic, res)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{})
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeClusterIP,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:        v1.ServiceTypeClusterIP,
 | |
| 			ExternalIPs: []string{"1.2.3.4"},
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeClusterIP,
 | |
| 			ExternalIPs:           []string{"1.2.3.4"},
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyCluster,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeClusterIP,
 | |
| 			ExternalIPs:           []string{"1.2.3.4"},
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyLocal,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeNodePort,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeNodePort,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyCluster,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeNodePort,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyLocal,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeLoadBalancer,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyCluster,
 | |
| 		},
 | |
| 	})
 | |
| 	checkExternalPolicyLocal(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeLoadBalancer,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyLocal,
 | |
| 		},
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func TestNeedsHealthCheck(t *testing.T) {
 | |
| 	checkNeedsHealthCheck := func(needsHealthCheck bool, service *v1.Service) {
 | |
| 		t.Helper()
 | |
| 		res := NeedsHealthCheck(service)
 | |
| 		if res != needsHealthCheck {
 | |
| 			t.Errorf("Expected needs health check = %v, got %v",
 | |
| 				needsHealthCheck, res)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	checkNeedsHealthCheck(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type: v1.ServiceTypeClusterIP,
 | |
| 		},
 | |
| 	})
 | |
| 	checkNeedsHealthCheck(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeNodePort,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyCluster,
 | |
| 		},
 | |
| 	})
 | |
| 	checkNeedsHealthCheck(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeNodePort,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyLocal,
 | |
| 		},
 | |
| 	})
 | |
| 	checkNeedsHealthCheck(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeLoadBalancer,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyCluster,
 | |
| 		},
 | |
| 	})
 | |
| 	checkNeedsHealthCheck(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			Type:                  v1.ServiceTypeLoadBalancer,
 | |
| 			ExternalTrafficPolicy: v1.ServiceExternalTrafficPolicyLocal,
 | |
| 		},
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func TestInternalPolicyLocal(t *testing.T) {
 | |
| 	checkInternalPolicyLocal := func(expected bool, service *v1.Service) {
 | |
| 		t.Helper()
 | |
| 		res := InternalPolicyLocal(service)
 | |
| 		if res != expected {
 | |
| 			t.Errorf("Expected internal local traffic = %v, got %v",
 | |
| 				expected, res)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// default InternalTrafficPolicy is nil
 | |
| 	checkInternalPolicyLocal(false, &v1.Service{})
 | |
| 
 | |
| 	local := v1.ServiceInternalTrafficPolicyLocal
 | |
| 	checkInternalPolicyLocal(true, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			InternalTrafficPolicy: &local,
 | |
| 		},
 | |
| 	})
 | |
| 
 | |
| 	cluster := v1.ServiceInternalTrafficPolicyCluster
 | |
| 	checkInternalPolicyLocal(false, &v1.Service{
 | |
| 		Spec: v1.ServiceSpec{
 | |
| 			InternalTrafficPolicy: &cluster,
 | |
| 		},
 | |
| 	})
 | |
| }
 |