mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-04 04:08:16 +00:00 
			
		
		
		
	Make unversioned.ListMeta implement List. Update all the *List types so they implement GetListMeta. This helps avoid using reflection to get list information. Remove all unnecessary boilerplate, move the interfaces to the right places, and add a test that verifies that objects implement one, the other, but never both.
		
			
				
	
	
		
			175 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			175 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
Copyright 2014 The Kubernetes Authors All rights reserved.
 | 
						|
 | 
						|
Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
you may not use this file except in compliance with the License.
 | 
						|
You may obtain a copy of the License at
 | 
						|
 | 
						|
    http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 | 
						|
Unless required by applicable law or agreed to in writing, software
 | 
						|
distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
See the License for the specific language governing permissions and
 | 
						|
limitations under the License.
 | 
						|
*/
 | 
						|
 | 
						|
package api_test
 | 
						|
 | 
						|
import (
 | 
						|
	"reflect"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/google/gofuzz"
 | 
						|
 | 
						|
	"k8s.io/kubernetes/pkg/api"
 | 
						|
	"k8s.io/kubernetes/pkg/api/meta"
 | 
						|
	"k8s.io/kubernetes/pkg/api/meta/metatypes"
 | 
						|
	"k8s.io/kubernetes/pkg/api/testapi"
 | 
						|
	"k8s.io/kubernetes/pkg/api/unversioned"
 | 
						|
	"k8s.io/kubernetes/pkg/runtime"
 | 
						|
)
 | 
						|
 | 
						|
var _ meta.Object = &api.ObjectMeta{}
 | 
						|
 | 
						|
// TestFillObjectMetaSystemFields validates that system populated fields are set on an object
 | 
						|
func TestFillObjectMetaSystemFields(t *testing.T) {
 | 
						|
	ctx := api.NewDefaultContext()
 | 
						|
	resource := api.ObjectMeta{}
 | 
						|
	api.FillObjectMetaSystemFields(ctx, &resource)
 | 
						|
	if resource.CreationTimestamp.Time.IsZero() {
 | 
						|
		t.Errorf("resource.CreationTimestamp is zero")
 | 
						|
	} else if len(resource.UID) == 0 {
 | 
						|
		t.Errorf("resource.UID missing")
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// TestHasObjectMetaSystemFieldValues validates that true is returned if and only if all fields are populated
 | 
						|
func TestHasObjectMetaSystemFieldValues(t *testing.T) {
 | 
						|
	ctx := api.NewDefaultContext()
 | 
						|
	resource := api.ObjectMeta{}
 | 
						|
	if api.HasObjectMetaSystemFieldValues(&resource) {
 | 
						|
		t.Errorf("the resource does not have all fields yet populated, but incorrectly reports it does")
 | 
						|
	}
 | 
						|
	api.FillObjectMetaSystemFields(ctx, &resource)
 | 
						|
	if !api.HasObjectMetaSystemFieldValues(&resource) {
 | 
						|
		t.Errorf("the resource does have all fields populated, but incorrectly reports it does not")
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func getObjectMetaAndOwnerReferences() (objectMeta api.ObjectMeta, metaOwnerReferences []metatypes.OwnerReference) {
 | 
						|
	fuzz.New().NilChance(.5).NumElements(1, 5).Fuzz(&objectMeta)
 | 
						|
	references := objectMeta.OwnerReferences
 | 
						|
	metaOwnerReferences = make([]metatypes.OwnerReference, 0)
 | 
						|
	for i := 0; i < len(references); i++ {
 | 
						|
		metaOwnerReferences = append(metaOwnerReferences, metatypes.OwnerReference{
 | 
						|
			Kind:       references[i].Kind,
 | 
						|
			Name:       references[i].Name,
 | 
						|
			UID:        references[i].UID,
 | 
						|
			APIVersion: references[i].APIVersion,
 | 
						|
			Controller: references[i].Controller,
 | 
						|
		})
 | 
						|
	}
 | 
						|
	if len(references) == 0 {
 | 
						|
		objectMeta.OwnerReferences = make([]api.OwnerReference, 0)
 | 
						|
	}
 | 
						|
	return objectMeta, metaOwnerReferences
 | 
						|
}
 | 
						|
 | 
						|
func testGetOwnerReferences(t *testing.T) {
 | 
						|
	meta, expected := getObjectMetaAndOwnerReferences()
 | 
						|
	refs := meta.GetOwnerReferences()
 | 
						|
	if !reflect.DeepEqual(refs, expected) {
 | 
						|
		t.Errorf("expect %v\n got %v", expected, refs)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func testSetOwnerReferences(t *testing.T) {
 | 
						|
	expected, newRefs := getObjectMetaAndOwnerReferences()
 | 
						|
	objectMeta := &api.ObjectMeta{}
 | 
						|
	objectMeta.SetOwnerReferences(newRefs)
 | 
						|
	if !reflect.DeepEqual(expected.OwnerReferences, objectMeta.OwnerReferences) {
 | 
						|
		t.Errorf("expect: %#v\n got: %#v", expected.OwnerReferences, objectMeta.OwnerReferences)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestAccessOwnerReferences(t *testing.T) {
 | 
						|
	fuzzIter := 5
 | 
						|
	for i := 0; i < fuzzIter; i++ {
 | 
						|
		testGetOwnerReferences(t)
 | 
						|
		testSetOwnerReferences(t)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestAccessorImplementations(t *testing.T) {
 | 
						|
	for _, group := range testapi.Groups {
 | 
						|
		for _, gv := range []unversioned.GroupVersion{*group.GroupVersion(), group.InternalGroupVersion()} {
 | 
						|
			for kind, knownType := range api.Scheme.KnownTypes(gv) {
 | 
						|
				value := reflect.New(knownType)
 | 
						|
				obj := value.Interface()
 | 
						|
				if _, ok := obj.(runtime.Object); !ok {
 | 
						|
					t.Errorf("%v (%v) does not implement runtime.Object", gv.WithKind(kind), knownType)
 | 
						|
				}
 | 
						|
				lm, isLM := obj.(meta.ListMetaAccessor)
 | 
						|
				om, isOM := obj.(meta.ObjectMetaAccessor)
 | 
						|
				switch {
 | 
						|
				case isLM && isOM:
 | 
						|
					t.Errorf("%v (%v) implements ListMetaAccessor and ObjectMetaAccessor", gv.WithKind(kind), knownType)
 | 
						|
					continue
 | 
						|
				case isLM:
 | 
						|
					m := lm.GetListMeta()
 | 
						|
					if m == nil {
 | 
						|
						t.Errorf("%v (%v) returns nil ListMeta", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					m.SetResourceVersion("102030")
 | 
						|
					if m.GetResourceVersion() != "102030" {
 | 
						|
						t.Errorf("%v (%v) did not preserve resource version", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					m.SetSelfLink("102030")
 | 
						|
					if m.GetSelfLink() != "102030" {
 | 
						|
						t.Errorf("%v (%v) did not preserve self link", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
				case isOM:
 | 
						|
					m := om.GetObjectMeta()
 | 
						|
					if m == nil {
 | 
						|
						t.Errorf("%v (%v) returns nil ObjectMeta", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					m.SetResourceVersion("102030")
 | 
						|
					if m.GetResourceVersion() != "102030" {
 | 
						|
						t.Errorf("%v (%v) did not preserve resource version", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					m.SetSelfLink("102030")
 | 
						|
					if m.GetSelfLink() != "102030" {
 | 
						|
						t.Errorf("%v (%v) did not preserve self link", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					labels := map[string]string{"a": "b"}
 | 
						|
					m.SetLabels(labels)
 | 
						|
					if !reflect.DeepEqual(m.GetLabels(), labels) {
 | 
						|
						t.Errorf("%v (%v) did not preserve labels", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
				default:
 | 
						|
					if _, ok := obj.(unversioned.ListMetaAccessor); ok {
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					if _, ok := value.Elem().Type().FieldByName("ObjectMeta"); ok {
 | 
						|
						t.Errorf("%v (%v) has ObjectMeta but does not implement ObjectMetaAccessor", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					if _, ok := value.Elem().Type().FieldByName("ListMeta"); ok {
 | 
						|
						t.Errorf("%v (%v) has ListMeta but does not implement ListMetaAccessor", gv.WithKind(kind), knownType)
 | 
						|
						continue
 | 
						|
					}
 | 
						|
					t.Logf("%v (%v) does not implement ListMetaAccessor or ObjectMetaAccessor", gv.WithKind(kind), knownType)
 | 
						|
				}
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |