kubernetes/pkg/kubectl/clusterrolebinding_test.go

/*
Copyright 2017 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package kubectl

import (
	"reflect"
	"testing"

	rbacv1beta1 "k8s.io/api/rbac/v1beta1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

func TestClusterRoleBindingGenerate(t *testing.T) {
	tests := []struct {
		name      string
		params    map[string]interface{}
		expected  *rbacv1beta1.ClusterRoleBinding
		expectErr bool
	}{
		{
			name: "valid case 1",
			params: map[string]interface{}{
				"name":           "foo",
				"clusterrole":    "admin",
				"user":           []string{"user"},
				"group":          []string{"group"},
				"serviceaccount": []string{"ns1:name1"},
			},
			expected: &rbacv1beta1.ClusterRoleBinding{
				ObjectMeta: metav1.ObjectMeta{
					Name: "foo",
				},
				RoleRef: rbacv1beta1.RoleRef{
					APIGroup: rbacv1beta1.GroupName,
					Kind:     "ClusterRole",
					Name:     "admin",
				},
				Subjects: []rbacv1beta1.Subject{
					{
						APIGroup: rbacv1beta1.GroupName,
						Kind:     rbacv1beta1.UserKind,
						Name:     "user",
					},
					{
						APIGroup: rbacv1beta1.GroupName,
						Kind:     rbacv1beta1.GroupKind,
						Name:     "group",
					},
					{
						Kind:      rbacv1beta1.ServiceAccountKind,
						APIGroup:  "",
						Namespace: "ns1",
						Name:      "name1",
					},
				},
			},
			expectErr: false,
		},
		{
			name: "valid case 2",
			params: map[string]interface{}{
				"name":           "foo",
				"clusterrole":    "admin",
				"user":           []string{"user1", "user2"},
				"group":          []string{"group1", "group2"},
				"serviceaccount": []string{"ns1:name1", "ns2:name2"},
			},
			expected: &rbacv1beta1.ClusterRoleBinding{
				ObjectMeta: metav1.ObjectMeta{
					Name: "foo",
				},
				RoleRef: rbacv1beta1.RoleRef{
					APIGroup: rbacv1beta1.GroupName,
					Kind:     "ClusterRole",
					Name:     "admin",
				},
				Subjects: []rbacv1beta1.Subject{
					{
						APIGroup: rbacv1beta1.GroupName,
						Kind:     rbacv1beta1.UserKind,
						Name:     "user1",
					},
					{
						APIGroup: rbacv1beta1.GroupName,
						Kind:     rbacv1beta1.UserKind,
						Name:     "user2",
					},
					{
						APIGroup: rbacv1beta1.GroupName,
						Kind:     rbacv1beta1.GroupKind,
						Name:     "group1",
					},
					{
						APIGroup: rbacv1beta1.GroupName,
						Kind:     rbacv1beta1.GroupKind,
						Name:     "group2",
					},
					{
						Kind:      rbacv1beta1.ServiceAccountKind,
						APIGroup:  "",
						Namespace: "ns1",
						Name:      "name1",
					},
					{
						Kind:      rbacv1beta1.ServiceAccountKind,
						APIGroup:  "",
						Namespace: "ns2",
						Name:      "name2",
					},
				},
			},
			expectErr: false,
		},
		{
			name: "valid case 3",
			params: map[string]interface{}{
				"name":        "foo",
				"clusterrole": "admin",
			},
			expected: &rbacv1beta1.ClusterRoleBinding{
				ObjectMeta: metav1.ObjectMeta{
					Name: "foo",
				},
				RoleRef: rbacv1beta1.RoleRef{
					APIGroup: rbacv1beta1.GroupName,
					Kind:     "ClusterRole",
					Name:     "admin",
				},
			},
			expectErr: false,
		},
		{
			name: "invalid serviceaccount, expected format: <namespace:name>",
			params: map[string]interface{}{
				"name":           "role",
				"clusterrole":    "admin",
				"user":           []string{"user"},
				"group":          []string{"group"},
				"serviceaccount": []string{"ns1-name1"},
			},
			expectErr: true,
		},
		{
			name: "name must be specified",
			params: map[string]interface{}{
				"name":           "",
				"clusterrole":    "admin",
				"user":           []string{"user"},
				"group":          []string{"group"},
				"serviceaccount": []string{"ns1:name1"},
			},
			expectErr: true,
		},
		{
			name: "clusterrole must be specified",
			params: map[string]interface{}{
				"name":           "foo",
				"clusterrole":    "",
				"user":           []string{"user"},
				"group":          []string{"group"},
				"serviceaccount": []string{"ns1:name1"},
			},
			expectErr: true,
		},
		{
			name: "expected user []string",
			params: map[string]interface{}{
				"name":           "role",
				"clusterrole":    "admin",
				"user":           "user",
				"group":          []string{"group"},
				"serviceaccount": []string{"ns1:name1"},
			},
			expectErr: true,
		},
		{
			name: "expected group []string",
			params: map[string]interface{}{
				"name":           "role",
				"clusterrole":    "admin",
				"user":           []string{"user"},
				"group":          "group",
				"serviceaccount": []string{"ns1:name1"},
			},
			expectErr: true,
		},
		{
			name: "expected serviceaccount []string",
			params: map[string]interface{}{
				"name":           "role",
				"clusterrole":    "admin",
				"user":           []string{"user"},
				"group":          []string{"group"},
				"serviceaccount": "ns1",
			},
			expectErr: true,
		},
	}
	generator := ClusterRoleBindingGeneratorV1{}
	for i := range tests {
		obj, err := generator.Generate(tests[i].params)
		if !tests[i].expectErr && err != nil {
			t.Errorf("[%d] unexpected error: %v", i, err)
		}
		if tests[i].expectErr && err != nil {
			continue
		}
		if tests[i].expectErr && err == nil {
			t.Errorf("[%s] expect error, got nil", tests[i].name)
		}
		if !reflect.DeepEqual(obj.(*rbacv1beta1.ClusterRoleBinding), tests[i].expected) {
			t.Errorf("\n[%s] want:\n%#v\ngot:\n%#v", tests[i].name, tests[i].expected, obj.(*rbacv1beta1.ClusterRoleBinding))
		}
	}
}