Files
kubernetes/cmd/kubeadm/app/util/env_test.go
Lubomir I. Ivanov a9f681d40a kubeadm: sort the results of MergeKubeadmEnvVars
MergeKubeadmEnvVars use a map which results in non
deterministic output in the end slice EnvVar objects.
Before returning the slice, sort it by the Name field.

Update the unit test to capture the sorting aspect.
2024-08-20 09:11:53 +03:00

138 lines
3.3 KiB
Go

/*
Copyright 2023 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package util
import (
"reflect"
"testing"
v1 "k8s.io/api/core/v1"
kubeadmapi "k8s.io/kubernetes/cmd/kubeadm/app/apis/kubeadm"
)
func TestMergeKubeadmEnvVars(t *testing.T) {
baseEnv := []kubeadmapi.EnvVar{}
extraEnv := []kubeadmapi.EnvVar{}
MergeKubeadmEnvVars(append(baseEnv, extraEnv...))
var tests = []struct {
name string
proxyEnv []kubeadmapi.EnvVar
extraEnv []kubeadmapi.EnvVar
mergedEnv []v1.EnvVar
}{
{
name: "normal case without duplicated env",
proxyEnv: []kubeadmapi.EnvVar{
{
EnvVar: v1.EnvVar{Name: "Foo2", Value: "Bar2"},
},
{
EnvVar: v1.EnvVar{Name: "Foo1", Value: "Bar1"},
},
},
extraEnv: []kubeadmapi.EnvVar{
{
EnvVar: v1.EnvVar{Name: "Foo3", Value: "Bar3"},
},
},
mergedEnv: []v1.EnvVar{
{Name: "Foo1", Value: "Bar1"},
{Name: "Foo2", Value: "Bar2"},
{Name: "Foo3", Value: "Bar3"},
},
},
{
name: "extraEnv env take precedence over the proxyEnv",
proxyEnv: []kubeadmapi.EnvVar{
{
EnvVar: v1.EnvVar{Name: "Foo1", Value: "Bar1"},
},
{
EnvVar: v1.EnvVar{Name: "Foo2", Value: "Bar2"},
},
},
extraEnv: []kubeadmapi.EnvVar{
{
EnvVar: v1.EnvVar{Name: "Foo2", Value: "Bar3"},
},
},
mergedEnv: []v1.EnvVar{
{Name: "Foo1", Value: "Bar1"},
{Name: "Foo2", Value: "Bar3"},
},
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
envs := MergeKubeadmEnvVars(test.proxyEnv, test.extraEnv)
if !reflect.DeepEqual(envs, test.mergedEnv) {
t.Errorf("expected env: %v, got: %v", test.mergedEnv, envs)
}
})
}
}
func TestGetProxyEnvVars(t *testing.T) {
var tests = []struct {
name string
environment []string
expected []kubeadmapi.EnvVar
}{
{
name: "environment with lowercase proxy vars",
environment: []string{
"http_proxy=p1",
"foo1=bar1",
"https_proxy=p2",
"foo2=bar2",
"no_proxy=p3",
},
expected: []kubeadmapi.EnvVar{
{EnvVar: v1.EnvVar{Name: "http_proxy", Value: "p1"}},
{EnvVar: v1.EnvVar{Name: "https_proxy", Value: "p2"}},
{EnvVar: v1.EnvVar{Name: "no_proxy", Value: "p3"}},
},
},
{
name: "environment with uppercase proxy vars",
environment: []string{
"HTTP_PROXY=p1",
"foo1=bar1",
"HTTPS_PROXY=p2",
"foo2=bar2",
"NO_PROXY=p3",
},
expected: []kubeadmapi.EnvVar{
{EnvVar: v1.EnvVar{Name: "HTTP_PROXY", Value: "p1"}},
{EnvVar: v1.EnvVar{Name: "HTTPS_PROXY", Value: "p2"}},
{EnvVar: v1.EnvVar{Name: "NO_PROXY", Value: "p3"}},
},
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
envs := GetProxyEnvVars(test.environment)
if !reflect.DeepEqual(envs, test.expected) {
t.Errorf("expected env: %v, got: %v", test.expected, envs)
}
})
}
}