mirror of
https://github.com/optim-enterprises-bv/kubernetes.git
synced 2025-12-03 06:43:53 +00:00
CodecFactory is started with EnableStrict that throws an error when deserializing a Kubelet component config that is malformed (e.g. unknown or duplicate keys). When strict decoding a v1beta1 config fails, non-strict decoding is used and a warning is emitted. For this, NewSchemeAndCodecs is now a variadic function that can take multiple arguments for augmenting the returned codec factory. Strict decoding is then explicitely enabled when decoding a kubelet config. Additionally, decoding a RemoteConfigSource needs to be non-strict to avoid an accidental error when it contains newer API fields that are not yet known to the Kubelet. DecodeKubeletConfiguration returns a wrapped error instead of a simple string so its type can be tested. Add unit tests for unhappy paths when loading a component config Add keys for test cases struct fields, remove nil field initialization Co-Authored-By: Jordan Liggitt <jordan@liggitt.net>
137 lines
5.1 KiB
Go
137 lines
5.1 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package codec
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/pkg/errors"
|
|
"k8s.io/klog"
|
|
|
|
// ensure the core apis are installed
|
|
_ "k8s.io/kubernetes/pkg/apis/core/install"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
"k8s.io/apimachinery/pkg/runtime/serializer"
|
|
"k8s.io/kubernetes/pkg/api/legacyscheme"
|
|
kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config"
|
|
"k8s.io/kubernetes/pkg/kubelet/apis/config/scheme"
|
|
kubeletconfigv1beta1 "k8s.io/kubernetes/pkg/kubelet/apis/config/v1beta1"
|
|
)
|
|
|
|
// EncodeKubeletConfig encodes an internal KubeletConfiguration to an external YAML representation.
|
|
func EncodeKubeletConfig(internal *kubeletconfig.KubeletConfiguration, targetVersion schema.GroupVersion) ([]byte, error) {
|
|
encoder, err := NewKubeletconfigYAMLEncoder(targetVersion)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
// encoder will convert to external version
|
|
data, err := runtime.Encode(encoder, internal)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return data, nil
|
|
}
|
|
|
|
// NewKubeletconfigYAMLEncoder returns an encoder that can write objects in the kubeletconfig API group to YAML.
|
|
func NewKubeletconfigYAMLEncoder(targetVersion schema.GroupVersion) (runtime.Encoder, error) {
|
|
_, codecs, err := scheme.NewSchemeAndCodecs()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
mediaType := "application/yaml"
|
|
info, ok := runtime.SerializerInfoForMediaType(codecs.SupportedMediaTypes(), mediaType)
|
|
if !ok {
|
|
return nil, fmt.Errorf("unsupported media type %q", mediaType)
|
|
}
|
|
return codecs.EncoderForVersion(info.Serializer, targetVersion), nil
|
|
}
|
|
|
|
// NewYAMLEncoder generates a new runtime.Encoder that encodes objects to YAML.
|
|
func NewYAMLEncoder(groupName string) (runtime.Encoder, error) {
|
|
// encode to YAML
|
|
mediaType := "application/yaml"
|
|
info, ok := runtime.SerializerInfoForMediaType(legacyscheme.Codecs.SupportedMediaTypes(), mediaType)
|
|
if !ok {
|
|
return nil, fmt.Errorf("unsupported media type %q", mediaType)
|
|
}
|
|
|
|
versions := legacyscheme.Scheme.PrioritizedVersionsForGroup(groupName)
|
|
if len(versions) == 0 {
|
|
return nil, fmt.Errorf("no enabled versions for group %q", groupName)
|
|
}
|
|
|
|
// the "best" version supposedly comes first in the list returned from legacyscheme.Registry.EnabledVersionsForGroup.
|
|
return legacyscheme.Codecs.EncoderForVersion(info.Serializer, versions[0]), nil
|
|
}
|
|
|
|
// newLenientSchemeAndCodecs returns a scheme that has only v1beta1 registered into
|
|
// it and a CodecFactory with strict decoding disabled.
|
|
func newLenientSchemeAndCodecs() (*runtime.Scheme, *serializer.CodecFactory, error) {
|
|
lenientScheme := runtime.NewScheme()
|
|
if err := kubeletconfig.AddToScheme(lenientScheme); err != nil {
|
|
return nil, nil, fmt.Errorf("failed to add internal kubelet config API to lenient scheme: %v", err)
|
|
}
|
|
if err := kubeletconfigv1beta1.AddToScheme(lenientScheme); err != nil {
|
|
return nil, nil, fmt.Errorf("failed to add kubelet config v1beta1 API to lenient scheme: %v", err)
|
|
}
|
|
lenientCodecs := serializer.NewCodecFactory(lenientScheme, serializer.DisableStrict)
|
|
return lenientScheme, &lenientCodecs, nil
|
|
}
|
|
|
|
// DecodeKubeletConfiguration decodes a serialized KubeletConfiguration to the internal type.
|
|
func DecodeKubeletConfiguration(kubeletCodecs *serializer.CodecFactory, data []byte) (*kubeletconfig.KubeletConfiguration, error) {
|
|
var (
|
|
obj runtime.Object
|
|
gvk *schema.GroupVersionKind
|
|
)
|
|
|
|
// The UniversalDecoder runs defaulting and returns the internal type by default.
|
|
obj, gvk, err := kubeletCodecs.UniversalDecoder().Decode(data, nil, nil)
|
|
if err != nil {
|
|
// Try strict decoding first. If that fails decode with a lenient
|
|
// decoder, which has only v1beta1 registered, and log a warning.
|
|
// The lenient path is to be dropped when support for v1beta1 is dropped.
|
|
if !runtime.IsStrictDecodingError(err) {
|
|
return nil, errors.Wrap(err, "failed to decode")
|
|
}
|
|
|
|
var lenientErr error
|
|
_, lenientCodecs, lenientErr := newLenientSchemeAndCodecs()
|
|
if lenientErr != nil {
|
|
return nil, lenientErr
|
|
}
|
|
|
|
obj, gvk, lenientErr = lenientCodecs.UniversalDecoder().Decode(data, nil, nil)
|
|
if lenientErr != nil {
|
|
// Lenient decoding failed with the current version, return the
|
|
// original strict error.
|
|
return nil, fmt.Errorf("failed lenient decoding: %v", err)
|
|
}
|
|
// Continue with the v1beta1 object that was decoded leniently, but emit a warning.
|
|
klog.Warningf("using lenient decoding as strict decoding failed: %v", err)
|
|
}
|
|
|
|
internalKC, ok := obj.(*kubeletconfig.KubeletConfiguration)
|
|
if !ok {
|
|
return nil, fmt.Errorf("failed to cast object to KubeletConfiguration, unexpected type: %v", gvk)
|
|
}
|
|
|
|
return internalKC, nil
|
|
}
|