scottk/ols-nos
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/ols-nos.git synced 2025-12-23 16:27:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sonic-cfggen] remove lazy_re workaround due to many optimizations done (#8226)

Browse Source 
lazy_re had an issue when importing sonic-cfggen in another application that
uses re.search(). There is no much improvement of lazy_re today after many 
other good optimization work done for sonic-cfggen. It served as a quick 
temporary solution.

Some quick test for fast-reboot and warm-reboot done on top of 201911 branch:

Fast-reboot: from ASIC reset to ports in up state:
with lazy_re: 18 sec
without lazy_re: 18 sec

Warm-reboot: LAG restoration time:
with lazy_re: 73 sec
without lazy_re: 72 sec

So, there is no real optimization since the number of sonic-cfggen calls is greatly 
reduced in latest SONiC. This means it is time to revert this change.

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This commit is contained in:
Stepan Blyshchak
2021-07-24 15:35:09 +03:00
committed by GitHub
parent d37361bf6a
commit 5361794ffd
3 changed files with 0 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sonic-config-engine/setup.py
View File

@@ -40,7 +40,6 @@ else:
# Common modules for python2 and python3
py_modules = [
'config_samples',
'lazy_re',
'minigraph',
'openconfig_acl',
'portconfig',