scottk/oopt-gnpy
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/oopt-gnpy.git synced 2025-11-02 11:07:57 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

EDFA Parameters restructuring

Browse Source 
The parameters of the EDFA are explicitely retrieved in the EDFAParams class.
All the defaults are set instead in the gnpy.tool.json_io.AMP class.
Where required, the AMP.default_values are used instead of an empty dictionary.

Change-Id: Iba80a6a56bc89feb7e959b54b9bd424ec9b0bf06
Co-authored-by: Vittorio Gatto <vittoriogatto98@gmail.com>
This commit is contained in:
AndreaDAmico
2023-05-09 15:56:43 +02:00
committed by EstherLerouzic
parent bbe5fb7821
commit 4ab5bac45f
6 changed files with 186 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/test_logger.py
View File

@@ -342,8 +342,8 @@ def wrong_element():
}],
"connections": []
},
"expected_msg": "The Edfa of variety type not_valid_variety was not recognized: "
+ "please check it is properly defined in the eqpt_config json file"
"expected_msg": "The Edfa of variety type not_valid_variety was not recognized:"
+ "\nplease check it is properly defined in the eqpt_config json file"
})
data.append({
"error": ParametersError,