scottk/oopt-gnpy
1
0
Fork 0
mirror of https://github.com/Telecominfraproject/oopt-gnpy.git synced 2025-11-02 02:57:52 +00:00
Code Issues Packages Projects Releases 10 Wiki Activity

Change sign convention for amplifier tilt

Browse Source 
As pointed out in GitHub issue #390, the normal convention for the sign
of amplifier tilt is to define it with regard to wavelength, i.e.
negative tilt means lower gain for longer wavelengths (lower
frequencies). Currently GNPy uses the opposite convention, which this
patch proposes to change.

Signed-off-by: Jonas Mårtensson <jonas.martensson@ri.se>
Change-Id: I8f7829a3b0b0b710f7da013c525630a60b22a2b5
This commit is contained in:
Jonas Mårtensson
2021-04-21 13:19:56 +02:00
parent a211e305c3
commit b58c089945
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gnpy/core/elements.py
View File

@@ -814,7 +814,7 @@ class Edfa(_Node):
dgt_slope = p[0]
# Calculate the target slope
targ_slope = self.tilt_target / (self.params.f_max - self.params.f_min)
targ_slope = -self.tilt_target / (self.params.f_max - self.params.f_min)
# first estimate of DGT scaling
try: