Commit Graph

8 Commits

Author SHA1 Message Date
Jan Kundrát
3b981853d4 SimParams: pretty exceptions upon a misconfiguration
Change-Id: I69f47925dd08c492b295b6824618a4595d142954
2020-05-23 22:03:23 +02:00
Jan Kundrát
6fa3ef8df1 params: Remove extra if
`kwargs` is always a dict, so it's still safe to prove individual
elements in there.

Change-Id: I2dea3159764807a2ff6a96d613ff69c68a7ba3ce
2020-05-23 22:03:23 +02:00
Jan Kundrát
76cdd5dc71 parameters: remove unused logger
Change-Id: I2d51081c8e1f7315861c2280ceb92304327c2ac6
2020-05-23 14:30:15 +02:00
Jan Kundrát
07eb2dd13a Refactoring: conversion functions instead of gnpy.core.units.UNITS
The TL;DR behind this patch is that it's better to have a utility
conversion function instead of having multiplier LUT and open code which
implements the conversion.

The FiberParams handling looked fishy -- apparently, it was keeping the
multiplier around, but it was unconditionally setting the units to
meters, anyway. Given that the units were not being preserved anyway
(everything got converted to meters), and that the multipler was not
used anywhere, let's refactor the code to just convert to meters using
our new utility function, and remove the unused argument.

Change-Id: Id886d409a4046f980eed569265baefd97db841bd
2020-05-23 13:50:25 +02:00
Jan Kundrát
04e764d024 FiberParams: print out the configuration upon failure
Apparently it's sometimes not obvious where the input data come from
(see next commit), so let's show the data which caused this excpetion to
the user.

Change-Id: Id333903a0549c4ef5dc37c2f6ff340bd357279ea
2020-05-23 13:50:25 +02:00
Jan Kundrát
3548ed74e2 coding style: autopep --in-place --recursive --jobs 4 --max-line-length 120 gnpy/ tests/
Change-Id: I2f0fca5aa1314f9bb546a3e6dc712a42580cd562
2020-05-19 12:40:00 +02:00
Jan Kundrát
2a477071a0 docs: emphasise the API reference over bits which are duplicated in the README
Also make sure that all modules are covered. It seems that there's no
automatic way for doing this, aargh. On the other hand, there's
apparently no need to repeat all the Sphinx markup blurb, and even
sectioning works nicely (read, "as I expect it to work") now :). I think
that it's still necessary to keep these "intermediate files" that only
trigger package-level and module-level autodocs, but hey, I can live
with this.

Change-Id: I705e0054cd7cd4350171770795d69f5c15c226d6
2020-05-07 19:54:55 +02:00
AndreaDAmico
c41cddfff5 Introduce new parameter structure for all Fibers
The Polito team wanted to have a single object with all parameters
required for each `Fiber` instance -- apparently for better code
readability.

Signed-off-by: AndreaDAmico <andrea.damico@polito.it>
Co-authored-by: Alessio Ferrari <alessio.ferrari@polito.it>
Co-authored-by: EstherLerouzic <esther.lerouzic@orange.com>
Signed-off-by: Jan Kundrát <jan.kundrat@telecominfraproject.com>
2019-12-17 11:12:52 +01:00