TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements (#4354)

* ESLint rule: only take explicit boolean predicates in if statements Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> * Merge main Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> * Fix frontend linter errors Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> * Fix jest Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> * Refactor according to review Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> * Refactor according to review Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> * Fix lint on new code Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br> --------- Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com> Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br>
2025-11-01 13:17:57 +00:00 · 2024-03-09 10:48:19 +01:00
parent 40bea0d95e
commit 17511be0cf
164 changed files with 655 additions and 367 deletions
--- a/tools/eslint-rules/rules/explicit-boolean-predicates-in-if.ts
+++ b/tools/eslint-rules/rules/explicit-boolean-predicates-in-if.ts
@@ -0,0 +1,43 @@
+import { ESLintUtils, TSESTree } from '@typescript-eslint/experimental-utils';
+
+export const RULE_NAME = 'explicit-boolean-predicates-in-if';
+
+export const rule = ESLintUtils.RuleCreator(() => __filename)({
+  name: RULE_NAME,
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Enforce explicit boolean predicates in if statements',
+      recommended: 'warn',
+    },
+    fixable: 'code',
+    schema: [],
+    messages: {
+      nonExplicitPredicate:
+        'Use an explicit boolean predicate in if statements.',
+    },
+  },
+  defaultOptions: [],
+  create: (context) => {
+    const parserServices = ESLintUtils.getParserServices(context);
+    const typeChecker = parserServices.program.getTypeChecker();
+
+    return {
+      IfStatement: (node: TSESTree.IfStatement) => {
+        const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node.test);
+        const type = typeChecker.getTypeAtLocation(tsNode);
+
+        if (typeChecker.typeToString(type) !== 'boolean') {
+          const { test } = node;
+
+          context.report({
+            node: test,
+            messageId: 'nonExplicitPredicate',
+          });
+        }
+      },
+    };
+  },
+});
+
+export default rule;