From c42ea57b97fc7ecf293c14913b9b2c35171be7ab Mon Sep 17 00:00:00 2001 From: "gitstart-app[bot]" <57568882+gitstart-app[bot]@users.noreply.github.com> Date: Tue, 17 Sep 2024 18:29:00 +0200 Subject: [PATCH] New Settings Layout (#6867) #### \ Description - **Added "Exit Settings" Back Button**: Introduced a new back button labeled "Exit Settings" for easy navigation back to the app content. - **Implemented Settings Navbar Breadcrumb**: A breadcrumb navigation bar for each settings page has been added to improve navigation within the settings. This ensures users can easily trace their location within the settings. - **Persistent CTA Zone**: The Call-to-Action (CTA) zone at the top of the page now remains visible even when the user scrolls down, preventing unresponsive behavior and improving accessibility. - **Page Title**: The page title has been added to each settings page and separated from the breadcrumb, following the app's layout standards. - we could not reproduce the Billing and CMR Migrations settings on the app, but we updated the files according, please let's us know if is there any way to log in with access to these pages, or if is everything ok. - Some breadcrumbs are not following the Figma, are following the current app sections isntead, because we would need to change the sidebar structure, and we should not do it on this PR ### Demo ### Refs: #6144 Fixes #6144 --------- Co-authored-by: gitstart-twenty Co-authored-by: Lucas Bordeau --- .../components/AppNavigationDrawer.tsx | 2 +- .../SettingsNavigationDrawerItems.tsx | 2 +- .../components/SettingsPageContainer.tsx | 2 +- .../SettingsReadDocumentationButton.tsx | 2 +- .../src/modules/ui/layout/page/PageHeader.tsx | 2 +- .../src/modules/ui/layout/page/PagePanel.tsx | 1 + .../ui/layout/page/SubMenuTopBarContainer.tsx | 34 +++++++----- .../bread-crumb/components/Breadcrumb.tsx | 34 +++++------- .../components/NavigationDrawer.tsx | 5 +- .../components/NavigationDrawerBackButton.tsx | 18 ++++-- .../src/pages/settings/Releases.tsx | 23 +++++--- .../src/pages/settings/SettingsBilling.tsx | 14 ++++- .../src/pages/settings/SettingsProfile.tsx | 14 ++++- .../src/pages/settings/SettingsWorkspace.tsx | 14 ++++- .../settings/SettingsWorkspaceMembers.tsx | 14 ++++- .../SettingsAppearance.stories.tsx | 2 +- .../settings/accounts/SettingsAccounts.tsx | 14 ++++- .../accounts/SettingsAccountsCalendars.tsx | 24 ++++---- .../accounts/SettingsAccountsEmails.tsx | 23 +++++--- .../settings/accounts/SettingsNewAccount.tsx | 23 +++++--- .../crm-migration/SettingsCRMMigration.tsx | 12 +++- .../settings/data-model/SettingsNewObject.tsx | 26 ++++----- .../SettingsObjectDetailPageContent.tsx | 18 +++--- .../data-model/SettingsObjectEdit.tsx | 55 +++++++++---------- .../data-model/SettingsObjectFieldEdit.tsx | 38 +++++++------ .../SettingsObjectNewFieldStep1.tsx | 27 ++++----- .../SettingsObjectNewFieldStep2.tsx | 44 +++++++-------- .../data-model/SettingsObjectOverview.tsx | 23 ++++---- .../settings/data-model/SettingsObjects.tsx | 9 +++ .../SettingsObjectNewFieldStep1.stories.tsx | 1 - .../developers/SettingsDevelopers.tsx | 9 +++ .../SettingsDevelopersApiKeysNew.stories.tsx | 3 +- .../SettingsDevelopersApiKeyDetail.tsx | 23 ++++---- .../api-keys/SettingsDevelopersApiKeysNew.tsx | 23 +++++--- .../SettingsDevelopersWebhookDetail.tsx | 31 +++++++---- .../SettingsDevelopersWebhooksNew.tsx | 25 +++++---- .../SettingsIntegrationDatabase.tsx | 24 ++++---- ...tingsIntegrationEditDatabaseConnection.tsx | 23 +++++--- ...ttingsIntegrationNewDatabaseConnection.tsx | 32 +++++------ ...tingsIntegrationShowDatabaseConnection.tsx | 18 +++++- .../integrations/SettingsIntegrations.tsx | 14 ++++- .../components/SettingsAppearance.tsx | 16 +++++- .../SettingsServerlessFunctionDetail.tsx | 31 ++++++----- .../SettingsServerlessFunctions.tsx | 14 +++-- .../SettingsServerlessFunctionsNew.tsx | 21 ++++--- 45 files changed, 504 insertions(+), 323 deletions(-) diff --git a/packages/twenty-front/src/modules/navigation/components/AppNavigationDrawer.tsx b/packages/twenty-front/src/modules/navigation/components/AppNavigationDrawer.tsx index 1dbe04bad..da636fe02 100644 --- a/packages/twenty-front/src/modules/navigation/components/AppNavigationDrawer.tsx +++ b/packages/twenty-front/src/modules/navigation/components/AppNavigationDrawer.tsx @@ -42,7 +42,7 @@ export const AppNavigationDrawer = ({ const drawerProps: NavigationDrawerProps = isSettingsDrawer ? { isSubMenu: true, - title: 'Settings', + title: 'Exit Settings', children: , footer: , } diff --git a/packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx b/packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx index 2818f9e84..04f110207 100644 --- a/packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx +++ b/packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx @@ -96,7 +96,7 @@ export const SettingsNavigationDrawerItems = () => { Icon={IconUserCircle} /> diff --git a/packages/twenty-front/src/modules/settings/components/SettingsPageContainer.tsx b/packages/twenty-front/src/modules/settings/components/SettingsPageContainer.tsx index d33f1493d..926fa57bc 100644 --- a/packages/twenty-front/src/modules/settings/components/SettingsPageContainer.tsx +++ b/packages/twenty-front/src/modules/settings/components/SettingsPageContainer.tsx @@ -10,7 +10,7 @@ const StyledSettingsPageContainer = styled.div<{ width?: number }>` flex-direction: column; gap: ${({ theme }) => theme.spacing(8)}; overflow: auto; - padding: ${({ theme }) => theme.spacing(8)}; + padding: ${({ theme }) => theme.spacing(6, 8, 8)}; width: ${({ width }) => { if (isDefined(width)) { return width + 'px'; diff --git a/packages/twenty-front/src/modules/settings/developers/components/SettingsReadDocumentationButton.tsx b/packages/twenty-front/src/modules/settings/developers/components/SettingsReadDocumentationButton.tsx index 1ac2596a0..c4cc6432d 100644 --- a/packages/twenty-front/src/modules/settings/developers/components/SettingsReadDocumentationButton.tsx +++ b/packages/twenty-front/src/modules/settings/developers/components/SettingsReadDocumentationButton.tsx @@ -6,7 +6,7 @@ export const SettingsReadDocumentationButton = () => { return (