mirror of
https://github.com/lingble/twenty.git
synced 2025-10-29 20:02:29 +00:00
03b3c8a67a
This PR is the second part of https://github.com/twentyhq/twenty/pull/5693. It optimizes all remaining field types. The observed improvements are : - x2 loading time improvement on table rows - more consistent render time Here's a summary of measured improvements, what's given here is the average of hundreds of renders with a React Profiler component. (in our Storybook performance stories) | Component | Before (µs) | After (µs) | | ----- | ------------- | --- | | TextFieldDisplay | 127 | 83 | | EmailFieldDisplay | 117 | 83 | | NumberFieldDisplay | 97 | 56 | | DateFieldDisplay | 240 | 52 | | CurrencyFieldDisplay | 236 | 110 | | FullNameFieldDisplay | 131 | 85 | | AddressFieldDisplay | 118 | 81 | | BooleanFieldDisplay | 130 | 100 | | JSONFieldDisplay | 248 | 49 | | LinksFieldDisplay | 1180 | 140 | | LinkFieldDisplay | 140 | 78 | | MultiSelectFieldDisplay | 770 | 130 | | SelectFieldDisplay | 230 | 87 |
53 lines
1.5 KiB
TypeScript
53 lines
1.5 KiB
TypeScript
import { useTheme } from '@emotion/react';
|
|
import { styled } from '@linaria/react';
|
|
|
|
import { FieldCurrencyValue } from '@/object-record/record-field/types/FieldMetadata';
|
|
import { SETTINGS_FIELD_CURRENCY_CODES } from '@/settings/data-model/constants/SettingsFieldCurrencyCodes';
|
|
import { formatAmount } from '~/utils/format/formatAmount';
|
|
import { isDefined } from '~/utils/isDefined';
|
|
|
|
type CurrencyDisplayProps = {
|
|
currencyValue: FieldCurrencyValue | null | undefined;
|
|
};
|
|
|
|
const StyledEllipsisDisplay = styled.div`
|
|
align-items: center;
|
|
display: flex;
|
|
max-width: 100%;
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
width: 100%;
|
|
`;
|
|
|
|
export const CurrencyDisplay = ({ currencyValue }: CurrencyDisplayProps) => {
|
|
const theme = useTheme();
|
|
|
|
const shouldDisplayCurrency = isDefined(currencyValue?.currencyCode);
|
|
|
|
const CurrencyIcon = isDefined(currencyValue?.currencyCode)
|
|
? SETTINGS_FIELD_CURRENCY_CODES[currencyValue?.currencyCode]?.Icon
|
|
: null;
|
|
|
|
const amountToDisplay = (currencyValue?.amountMicros ?? 0) / 1000000;
|
|
|
|
if (!shouldDisplayCurrency) {
|
|
return <StyledEllipsisDisplay>{0}</StyledEllipsisDisplay>;
|
|
}
|
|
|
|
return (
|
|
<StyledEllipsisDisplay>
|
|
{isDefined(CurrencyIcon) && (
|
|
<>
|
|
<CurrencyIcon
|
|
color={theme.font.color.primary}
|
|
size={theme.icon.size.md}
|
|
stroke={theme.icon.stroke.sm}
|
|
/>{' '}
|
|
</>
|
|
)}
|
|
{amountToDisplay !== 0 ? formatAmount(amountToDisplay) : ''}
|
|
</StyledEllipsisDisplay>
|
|
);
|
|
};
|